From nobody Sat May 18 08:46:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571237888; cv=none; d=zoho.com; s=zohoarc; b=KauJuZ5duV8JfVwDdJFAQScBZsrftIuDWIs0rKkOBX0Gd0iCGEuR/HDHtgJUebXdyoGofw00zfHKpGLz90AVWhROO9vY1E5C/nByAt6M5BhfA1YWgtwyu9//9FRLTAkE/ccluoy9JbGJTgo1XqmEsSgjA+PnV1zAPuAupbNWvOg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571237888; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=88D/5iOf0mBcXuGtqKcijuaqCLCh7Q29z5mgWYUhsYQ=; b=ibUWQpcWM3EHuX5xD6kPW8H032RUgKZfIQ5vSvS4ww2y1ZFl6ZRcesD0Ie88/t2w7cHFVNDUMB1R5bcRzQybo4yzw1DIZNYYljqkfoSjxk+FhNbzHPOzM24JVjhpJmgYvV84Pr8z6uGgz+bk8qLSdUsij3yUKKpbgLxX+hbBZHw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571237888326149.09114261600246; Wed, 16 Oct 2019 07:58:08 -0700 (PDT) Received: from localhost ([::1]:43648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKkkW-0002s7-RZ for importer@patchew.org; Wed, 16 Oct 2019 10:58:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44613) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKkhI-0008Td-K6 for qemu-devel@nongnu.org; Wed, 16 Oct 2019 10:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKkhF-0000uw-Ps for qemu-devel@nongnu.org; Wed, 16 Oct 2019 10:54:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60396) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKkhF-0000uW-Er; Wed, 16 Oct 2019 10:54:41 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FE9B30860C1; Wed, 16 Oct 2019 14:54:40 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTP id 49E5219C70; Wed, 16 Oct 2019 14:54:36 +0000 (UTC) From: Andrew Jones To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org Subject: [PATCH] s390x/cpumodel: Add missing visit_free Date: Wed, 16 Oct 2019 16:54:34 +0200 Message-Id: <20191016145434.7007-1-drjones@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 16 Oct 2019 14:54:40 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pasic@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Beata Michalska noticed this missing visit_free() while reviewing arm's implementation of qmp_query_cpu_model_expansion(), which is modeled off this s390x implementation. Signed-off-by: Andrew Jones Reviewed-by: David Hildenbrand --- target/s390x/cpu_models.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 009afc38b92d..7e92fb2e156d 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, co= nst CpuModelInfo *info, visitor =3D qobject_input_visitor_new(info->props); visit_start_struct(visitor, NULL, NULL, 0, errp); if (*errp) { + visit_free(visitor); object_unref(obj); return; } --=20 2.21.0