[v1] s390x/tcg update

[PULL 00/31] s390x/tcg update

Posted by David Hildenbrand 4 years, 6 months ago

Hi Peter,

The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:

  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)

are available in the Git repository at:

  https://github.com/davidhildenbrand/qemu.git tags/s390x-tcg-2019-10-10

for you to fetch changes up to 1f6493be088da969efeeee0100ea4330fb804cdf:

  s390x/tcg: MVCL: Exit to main loop if requested (2019-10-10 12:27:15 +0200)

----------------------------------------------------------------
- MMU DAT translation rewrite and cleanup
- Implement more TCG CPU features related to the MMU (e.g., IEP)
- Add the current instruction length to unwind data and clean up
- Resolve one TODO for the MVCL instruction

----------------------------------------------------------------
David Hildenbrand (13):
  s390x/mmu: Drop debug logging from MMU code
  s390x/mmu: Move DAT protection handling out of mmu_translate_asce()
  s390x/mmu: Inject DAT exceptions from a single place
  s390x/mmu: Inject PGM_ADDRESSING on bogus table addresses
  s390x/mmu: Use TARGET_PAGE_MASK in mmu_translate_pte()
  s390x/mmu: DAT table definition overhaul
  s390x/mmu: Convert to non-recursive page table walk
  s390x/mmu: Add EDAT2 translation support
  s390x/mmu: Implement ESOP-2 and
    access-exception-fetch/store-indication facility
  s390x/mmu: Implement Instruction-Execution-Protection Facility
  s390x/cpumodel: Prepare for changes of QEMU model
  s390x/cpumodel: Add new TCG features to QEMU cpu model
  s390x/tcg: MVCL: Exit to main loop if requested

Richard Henderson (18):
  target/s390x: Add ilen to unwind data
  target/s390x: Remove ilen parameter from tcg_s390_program_interrupt
  target/s390x: Remove ilen parameter from s390_program_interrupt
  target/s390x: Use tcg_s390_program_interrupt in TCG helpers
  target/s390x: Push trigger_pgm_exception lower in s390_cpu_tlb_fill
  target/s390x: Handle tec in s390_cpu_tlb_fill
  target/s390x: Return exception from mmu_translate_real
  target/s390x: Remove exc argument to mmu_translate_asce
  target/s390x: Return exception from mmu_translate
  target/s390x: Return exception from translate_pages
  target/s390x: Remove fail variable from s390_cpu_tlb_fill
  target/s390x: Simplify helper_lra
  target/s390x: Rely on unwinding in s390_cpu_tlb_fill
  target/s390x: Rely on unwinding in s390_cpu_virt_mem_rw
  target/s390x: Remove ILEN_AUTO
  target/s390x: Remove ilen argument from trigger_access_exception
  target/s390x: Remove ilen argument from trigger_pgm_exception
  target/s390x: Remove ILEN_UNWIND

 hw/s390x/s390-pci-inst.c     |  58 ++---
 hw/s390x/s390-virtio-ccw.c   |   2 +
 include/exec/exec-all.h      |  17 ++
 target/s390x/cc_helper.c     |   4 +-
 target/s390x/cpu.h           |  86 +++++--
 target/s390x/crypto_helper.c |   7 +-
 target/s390x/diag.c          |  14 +-
 target/s390x/excp_helper.c   |  58 +++--
 target/s390x/fpu_helper.c    |   6 +-
 target/s390x/gen-features.c  |  11 +-
 target/s390x/helper.c        |   7 +-
 target/s390x/int_helper.c    |  15 +-
 target/s390x/internal.h      |   6 +-
 target/s390x/interrupt.c     |   9 +-
 target/s390x/ioinst.c        |  40 ++--
 target/s390x/mem_helper.c    |  84 +++----
 target/s390x/misc_helper.c   |  27 +--
 target/s390x/mmu_helper.c    | 429 ++++++++++++++++-------------------
 target/s390x/tcg-stub.c      |   4 +-
 target/s390x/tcg_s390x.h     |   4 +-
 target/s390x/translate.c     |  20 +-
 21 files changed, 475 insertions(+), 433 deletions(-)

-- 
2.21.0

Re: [PULL 00/31] s390x/tcg update

Posted by no-reply@patchew.org 4 years, 6 months ago

Patchew URL: https://patchew.org/QEMU/20191010113356.5017-1-david@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      stubs/pc_madt_cpu_entry.o
  CC      stubs/vmgenid.o
  CC      stubs/xen-common.o
make: *** [Makefile:994: docs/interop/index.html] Error 2
make: *** Deleting file 'docs/interop/index.html'
make: *** Waiting for unfinished jobs....
Traceback (most recent call last):
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=ac34ecad3e534df8b0eacbb2152563e8', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-wk1otdub/src/docker-src.2019-10-10-08.31.07.10413:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=ac34ecad3e534df8b0eacbb2152563e8
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-wk1otdub/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real    2m12.498s
user    0m6.664s


The full log is available at
http://patchew.org/logs/20191010113356.5017-1-david@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL 00/31] s390x/tcg update

Posted by David Hildenbrand 4 years, 6 months ago

On 10.10.19 14:33, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20191010113356.5017-1-david@redhat.com/
> 
> 
> 
> Hi,
> 
> This series failed the docker-mingw@fedora build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
> 
> === TEST SCRIPT BEGIN ===
> #! /bin/bash
> export ARCH=x86_64
> make docker-image-fedora V=1 NETWORK=1
> time make docker-test-mingw@fedora J=14 NETWORK=1
> === TEST SCRIPT END ===
> 
>   CC      stubs/pc_madt_cpu_entry.o
>   CC      stubs/vmgenid.o
>   CC      stubs/xen-common.o
> make: *** [Makefile:994: docs/interop/index.html] Error 2
> make: *** Deleting file 'docs/interop/index.html'
> make: *** Waiting for unfinished jobs....
> Traceback (most recent call last):
> ---
>     raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=ac34ecad3e534df8b0eacbb2152563e8', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-wk1otdub/src/docker-src.2019-10-10-08.31.07.10413:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2.
> filter=--filter=label=com.qemu.instance.uuid=ac34ecad3e534df8b0eacbb2152563e8
> make[1]: *** [docker-run] Error 1
> make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-wk1otdub/src'
> make: *** [docker-run-test-mingw@fedora] Error 2
> 
> real    2m12.498s
> user    0m6.664s

False negative, just tried to reproduce and the build succeeded without
an issue.

rm -f qapi-gen-timestamp
rm -rf qga/qapi-generated
rm -f config-all-devices.mak
    CLEANUP /home/dhildenb/git/qemu/docker-src.2019-10-10-15.06.03.19743
make[1]: Verzeichnis „/home/dhildenb/git/qemu“ wird verlassen

real    3m30,648s
user    0m1,855s
sys     0m0,885s


-- 

Thanks,

David / dhildenb

Re: [PULL 00/31] s390x/tcg update

Posted by Peter Maydell 4 years, 6 months ago

On Thu, 10 Oct 2019 at 12:34, David Hildenbrand <david@redhat.com> wrote:
>
> Hi Peter,
>
> The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
>
>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/davidhildenbrand/qemu.git tags/s390x-tcg-2019-10-10
>
> for you to fetch changes up to 1f6493be088da969efeeee0100ea4330fb804cdf:
>
>   s390x/tcg: MVCL: Exit to main loop if requested (2019-10-10 12:27:15 +0200)
>
> ----------------------------------------------------------------
> - MMU DAT translation rewrite and cleanup
> - Implement more TCG CPU features related to the MMU (e.g., IEP)
> - Add the current instruction length to unwind data and clean up
> - Resolve one TODO for the MVCL instruction
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.

-- PMM