kvm: Initialize kvm_physical_log_clear ret local variable

[PATCH] kvm: Initialize kvm_physical_log_clear ret local variable

Eric Auger posted 1 patch 4 years, 6 months ago

Download mbox

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu failed

Test asan failed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191003113226.27515-1-eric.auger@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>

accel/kvm/kvm-all.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] kvm: Initialize kvm_physical_log_clear ret local variable

Posted by Eric Auger 4 years, 6 months ago

If there is no slot in the section ret is not initialized. This triggers
a compilation error at caller site.

error: ‘ret’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
     if (r < 0) {

Fixes: 84516e5b8d ("kvm: clear dirty bitmaps from all overlapping memslots")
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 accel/kvm/kvm-all.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index aabe097c41..e2605da22e 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -712,7 +712,7 @@ static int kvm_physical_log_clear(KVMMemoryListener *kml,
     KVMState *s = kvm_state;
     uint64_t start, size, offset, count;
     KVMSlot *mem;
-    int ret, i;
+    int ret = 0, i;
 
     if (!s->manual_dirty_log_protect) {
         /* No need to do explicit clear */
-- 
2.20.1