From nobody Sun May 19 00:17:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570102420; cv=none; d=zoho.com; s=zohoarc; b=SiVVIRIV3JPQYKIT7x1sWQ2vWmHHXDSyu13D9D+tR28aiyq2zIuqvzJ9zG8qPQje9JiONXechNEUtG3t9M1yEomWerP6ApkzyqIJ95Z4dvupgT9mXRSsUCa+5MJbyLLLK/lnm8zH0UDj/qErljR2dXpcDz0pVpqX/Wjpj4rYAW0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570102420; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=I6vSk8jhMds+08BsrJi02ZYD1NfJflDzLn0PfV8cmz0=; b=Ydz66VW/Ynfb9oQIfDlFizzQLwZE10vgwmmp8yJa2PsX0CB4FgJ303D6DETWVw5te+xFbrnhCL0l9ww62UTaqfi54ojdn0RIReb+YDFDmSuQ2HqEA2IHeTSqZqsEk6peGVlTNEOl4KnwrICE0tCigYPQ+IBvzs8j7XDO4pXhDWs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 15701024201562.0100931048542634; Thu, 3 Oct 2019 04:33:40 -0700 (PDT) Received: from localhost ([::1]:35080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFzMO-0001L2-I9 for importer@patchew.org; Thu, 03 Oct 2019 07:33:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36106) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFzLf-0000wC-0b for qemu-devel@nongnu.org; Thu, 03 Oct 2019 07:32:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFzLd-0004q5-Ir for qemu-devel@nongnu.org; Thu, 03 Oct 2019 07:32:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36516) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFzLd-0004p7-DW for qemu-devel@nongnu.org; Thu, 03 Oct 2019 07:32:41 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9CEF130ADBA1; Thu, 3 Oct 2019 11:32:39 +0000 (UTC) Received: from laptop.redhat.com (ovpn-117-64.ams2.redhat.com [10.36.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 06A8060BF3; Thu, 3 Oct 2019 11:32:33 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com Subject: [PATCH] kvm: Initialize kvm_physical_log_clear ret local variable Date: Thu, 3 Oct 2019 13:32:26 +0200 Message-Id: <20191003113226.27515-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 03 Oct 2019 11:32:39 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If there is no slot in the section ret is not initialized. This triggers a compilation error at caller site. error: =E2=80=98ret=E2=80=99 may be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] if (r < 0) { Fixes: 84516e5b8d ("kvm: clear dirty bitmaps from all overlapping memslots") Signed-off-by: Eric Auger --- accel/kvm/kvm-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index aabe097c41..e2605da22e 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -712,7 +712,7 @@ static int kvm_physical_log_clear(KVMMemoryListener *km= l, KVMState *s =3D kvm_state; uint64_t start, size, offset, count; KVMSlot *mem; - int ret, i; + int ret =3D 0, i; =20 if (!s->manual_dirty_log_protect) { /* No need to do explicit clear */ --=20 2.20.1