[Qemu-devel] [PATCH v2 0/1] Export machine type deprecation info through QMP

Eduardo Habkost posted 1 patch 4 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190608233447.27970-1-ehabkost@redhat.com
Test s390x passed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Maintainers: Eric Blake <eblake@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Markus Armbruster <armbru@redhat.com>
qapi/misc.json | 7 ++++++-
vl.c           | 1 +
2 files changed, 7 insertions(+), 1 deletion(-)
[Qemu-devel] [PATCH v2 0/1] Export machine type deprecation info through QMP
Posted by Eduardo Habkost 4 years, 11 months ago
Changes v1 -> v2:
* I've decided to get rid of the status-message and
  suggested-alternative fields, to avoid more bikeshedding.

This series adds machine type deprecation information to the
output of the `query-machines` QMP command.  With this, libvirt
and management software will be able to show this information to
users and/or suggest changes to VM configuration to avoid
deprecated machine types.

Eduardo Habkost (1):
  qmp: Add deprecation information to query-machines

 qapi/misc.json | 7 ++++++-
 vl.c           | 1 +
 2 files changed, 7 insertions(+), 1 deletion(-)

-- 
2.18.0.rc1.1.g3f1ff2140


Re: [Qemu-devel] [PATCH v2 0/1] Export machine type deprecation info through QMP
Posted by Eduardo Habkost 4 years, 10 months ago
Any objections to this?  I'm planning to merge it this week.

On Sat, Jun 08, 2019 at 08:34:46PM -0300, Eduardo Habkost wrote:
> Changes v1 -> v2:
> * I've decided to get rid of the status-message and
>   suggested-alternative fields, to avoid more bikeshedding.
> 
> This series adds machine type deprecation information to the
> output of the `query-machines` QMP command.  With this, libvirt
> and management software will be able to show this information to
> users and/or suggest changes to VM configuration to avoid
> deprecated machine types.
> 
> Eduardo Habkost (1):
>   qmp: Add deprecation information to query-machines
> 
>  qapi/misc.json | 7 ++++++-
>  vl.c           | 1 +
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> -- 
> 2.18.0.rc1.1.g3f1ff2140
> 

-- 
Eduardo

Re: [Qemu-devel] [PATCH v2 0/1] Export machine type deprecation info through QMP
Posted by Wainer dos Santos Moschetta 4 years, 10 months ago

On 06/24/2019 03:03 PM, Eduardo Habkost wrote:
> Any objections to this?  I'm planning to merge it this week.

IMHO, 1+. So I don't have objections.

- Wainer

>
> On Sat, Jun 08, 2019 at 08:34:46PM -0300, Eduardo Habkost wrote:
>> Changes v1 -> v2:
>> * I've decided to get rid of the status-message and
>>    suggested-alternative fields, to avoid more bikeshedding.
>>
>> This series adds machine type deprecation information to the
>> output of the `query-machines` QMP command.  With this, libvirt
>> and management software will be able to show this information to
>> users and/or suggest changes to VM configuration to avoid
>> deprecated machine types.
>>
>> Eduardo Habkost (1):
>>    qmp: Add deprecation information to query-machines
>>
>>   qapi/misc.json | 7 ++++++-
>>   vl.c           | 1 +
>>   2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> -- 
>> 2.18.0.rc1.1.g3f1ff2140
>>


Re: [Qemu-devel] [PATCH v2 0/1] Export machine type deprecation info through QMP
Posted by Markus Armbruster 4 years, 10 months ago
Eduardo Habkost <ehabkost@redhat.com> writes:

> Any objections to this?  I'm planning to merge it this week.

No objection, in fact:
Reviewed-by: Markus Armbruster <armbru@redhat.com>

The QAPI feature flags work, once finished, might render this redundant,
but I'd rather not have my unfinished solution for a wider problem block
your working solution for a narrower problem.