From nobody Mon May 20 13:41:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560037031; cv=none; d=zoho.com; s=zohoarc; b=n2Fwv/0D3Nq+3OiFJ0kfcoeTlJgd3ESr4yasHCbHdACFj0VQoi4ala7Esf/oGIyY1h2C3wtilxiesP8f5s6IjoAlVqzs/sHsKdFkixW7FSsWd80GCn8b7b19n2WgWlrvQc/ruHo35mA4TKKemaW9pRvQf9WVV1oUmJ2rvZC6FPM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560037031; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=sgAMOM7o9V3ycf96Q8ZWr1F6oqShVjSjQuPQSmT1e0E=; b=gag0ZENcN1rbiTfUM1uoudYvyIWZcEOVCXOPAcxHYX/T/b5OJxA3I7BYvHWcUB38UEYkFED9habao6ZrlI0Ol6wQ0GiIhwfSF05p5N34tRZGkZZ3PknIkfdzje5Mbu1Js43SY5j5/m7iB/mPEH9381TPGvq0QH4E3NM8wc/Jbes= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1560037031707912.7568049425477; Sat, 8 Jun 2019 16:37:11 -0700 (PDT) Received: from localhost ([::1]:32844 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZktP-0004yT-Gy for importer@patchew.org; Sat, 08 Jun 2019 19:36:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59404) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZkra-0003wh-0p for qemu-devel@nongnu.org; Sat, 08 Jun 2019 19:35:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZkrZ-0006aJ-3A for qemu-devel@nongnu.org; Sat, 08 Jun 2019 19:35:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44260) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hZkrY-0006Yq-Td for qemu-devel@nongnu.org; Sat, 08 Jun 2019 19:35:05 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 27F373082145; Sat, 8 Jun 2019 23:35:02 +0000 (UTC) Received: from localhost (ovpn-116-9.gru2.redhat.com [10.97.116.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 33493608A5; Sat, 8 Jun 2019 23:34:56 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Sat, 8 Jun 2019 20:34:47 -0300 Message-Id: <20190608233447.27970-2-ehabkost@redhat.com> In-Reply-To: <20190608233447.27970-1-ehabkost@redhat.com> References: <20190608233447.27970-1-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Sat, 08 Jun 2019 23:35:02 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/1] qmp: Add deprecation information to query-machines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Daniel P. Berrange" , Markus Armbruster , Wainer dos Santos Moschetta , Michal Privoznik , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Export machine type deprecation status through the query-machines QMP command. With this, libvirt and management software will be able to show this information to users and/or suggest changes to VM configuration to avoid deprecated machines. Signed-off-by: Eduardo Habkost Reviewed-by: Marcel Apfelbaum Reviewed-by: Markus Armbruster --- Changes v1 -> v2: * Take a much simpler approach: add a simple `deprecated` bool field, instead of including a human-readable message and suggested alternatives --- qapi/misc.json | 7 ++++++- vl.c | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/qapi/misc.json b/qapi/misc.json index 8b3ca4fdd3..fca793d39c 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -2018,12 +2018,17 @@ # # @hotpluggable-cpus: cpu hotplug via -device is supported (since 2.7.0) # +# @deprecated: if true, the machine type is deprecated and may be removed +# in future versions of QEMU according to the QEMU deprecation +# policy (since 4.1.0) +# # Since: 1.2.0 ## { 'struct': 'MachineInfo', 'data': { 'name': 'str', '*alias': 'str', '*is-default': 'bool', 'cpu-max': 'int', - 'hotpluggable-cpus': 'bool'} } + 'hotpluggable-cpus': 'bool', + 'deprecated': 'bool' } } =20 ## # @query-machines: diff --git a/vl.c b/vl.c index cd1fbc4cdc..f825d2159c 100644 --- a/vl.c +++ b/vl.c @@ -1428,6 +1428,7 @@ MachineInfoList *qmp_query_machines(Error **errp) info->name =3D g_strdup(mc->name); info->cpu_max =3D !mc->max_cpus ? 1 : mc->max_cpus; info->hotpluggable_cpus =3D mc->has_hotpluggable_cpus; + info->deprecated =3D !!mc->deprecation_reason; =20 entry =3D g_malloc0(sizeof(*entry)); entry->value =3D info; --=20 2.18.0.rc1.1.g3f1ff2140