[v1] docs/devel/build-system: Update an example

[Qemu-devel] [PATCH] docs/devel/build-system: Update an example

Posted by Philippe Mathieu-Daudé 4 years, 11 months ago

The default-configs/ example added in 717171bd2025 is no
more accurate since fa212a2b8b60 (and various further other
commits).

The Kconfig build system is now in place.
Use the aarch64-softmmu config as example.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 docs/devel/build-system.txt | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt
index addd274eebd..79a85bfba06 100644
--- a/docs/devel/build-system.txt
+++ b/docs/devel/build-system.txt
@@ -415,16 +415,11 @@ context.
 The files under default-configs/ control what emulated hardware is built
 into each QEMU system and userspace emulator targets. They merely
 contain a long list of config variable definitions. For example,
-default-configs/x86_64-softmmu.mak has:
-
-  include sound.mak
-  include usb.mak
-  CONFIG_QXL=$(CONFIG_SPICE)
-  CONFIG_VGA_ISA=y
-  CONFIG_VGA_CIRRUS=y
-  CONFIG_VMWARE_VGA=y
-  CONFIG_VIRTIO_VGA=y
-  ...snip...
+default-configs/aarch64-softmmu.mak has:
+
+  include arm-softmmu.mak
+  CONFIG_XLNX_ZYNQMP_ARM=y
+  CONFIG_XLNX_VERSAL=y
 
 These files rarely need changing unless new devices / hardware need to
 be enabled for a particular system/userspace emulation target
-- 
2.20.1

Re: [Qemu-devel] [PATCH] docs/devel/build-system: Update an example

Posted by Thomas Huth 4 years, 11 months ago

On 15/05/2019 09.03, Philippe Mathieu-Daudé wrote:
> The default-configs/ example added in 717171bd2025 is no
> more accurate since fa212a2b8b60 (and various further other
> commits).
> 
> The Kconfig build system is now in place.
> Use the aarch64-softmmu config as example.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  docs/devel/build-system.txt | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt
> index addd274eebd..79a85bfba06 100644
> --- a/docs/devel/build-system.txt
> +++ b/docs/devel/build-system.txt
> @@ -415,16 +415,11 @@ context.
>  The files under default-configs/ control what emulated hardware is built
>  into each QEMU system and userspace emulator targets. They merely
>  contain a long list of config variable definitions. For example,

"long list" is now often also not very accurate anymore. Maybe rephrase
that sentence à la: "contain a list of config variable definitions like
the machines that should be included" ?

> -default-configs/x86_64-softmmu.mak has:
> -
> -  include sound.mak
> -  include usb.mak
> -  CONFIG_QXL=$(CONFIG_SPICE)
> -  CONFIG_VGA_ISA=y
> -  CONFIG_VGA_CIRRUS=y
> -  CONFIG_VMWARE_VGA=y
> -  CONFIG_VIRTIO_VGA=y
> -  ...snip...
> +default-configs/aarch64-softmmu.mak has:
> +
> +  include arm-softmmu.mak
> +  CONFIG_XLNX_ZYNQMP_ARM=y
> +  CONFIG_XLNX_VERSAL=y
>  
>  These files rarely need changing unless new devices / hardware need to
>  be enabled for a particular system/userspace emulation target
> 

Anyway,

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH] docs/devel/build-system: Update an example

Posted by Philippe Mathieu-Daudé 4 years, 11 months ago

On 5/15/19 9:16 AM, Thomas Huth wrote:
> On 15/05/2019 09.03, Philippe Mathieu-Daudé wrote:
>> The default-configs/ example added in 717171bd2025 is no
>> more accurate since fa212a2b8b60 (and various further other
>> commits).
>>
>> The Kconfig build system is now in place.
>> Use the aarch64-softmmu config as example.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  docs/devel/build-system.txt | 15 +++++----------
>>  1 file changed, 5 insertions(+), 10 deletions(-)
>>
>> diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt
>> index addd274eebd..79a85bfba06 100644
>> --- a/docs/devel/build-system.txt
>> +++ b/docs/devel/build-system.txt
>> @@ -415,16 +415,11 @@ context.
>>  The files under default-configs/ control what emulated hardware is built
>>  into each QEMU system and userspace emulator targets. They merely
>>  contain a long list of config variable definitions. For example,
> 
> "long list" is now often also not very accurate anymore. Maybe rephrase

Still accurate for MIPS :(

> that sentence à la: "contain a list of config variable definitions like
> the machines that should be included" ?

Good idea.

> 
>> -default-configs/x86_64-softmmu.mak has:
>> -
>> -  include sound.mak
>> -  include usb.mak
>> -  CONFIG_QXL=$(CONFIG_SPICE)
>> -  CONFIG_VGA_ISA=y
>> -  CONFIG_VGA_CIRRUS=y
>> -  CONFIG_VMWARE_VGA=y
>> -  CONFIG_VIRTIO_VGA=y
>> -  ...snip...
>> +default-configs/aarch64-softmmu.mak has:
>> +
>> +  include arm-softmmu.mak
>> +  CONFIG_XLNX_ZYNQMP_ARM=y
>> +  CONFIG_XLNX_VERSAL=y
>>  
>>  These files rarely need changing unless new devices / hardware need to
>>  be enabled for a particular system/userspace emulation target
>>
> 
> Anyway,
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 

Thanks!

Phil.