[Qemu-devel] [PATCH v2] docs/devel/build-system: Update an example

Philippe Mathieu-Daudé posted 1 patch 4 years, 10 months ago
Test s390x passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190529140504.21580-1-philmd@redhat.com
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>
docs/devel/build-system.txt | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
[Qemu-devel] [PATCH v2] docs/devel/build-system: Update an example
Posted by Philippe Mathieu-Daudé 4 years, 10 months ago
The default-configs/ example added in 717171bd2025 is no
more accurate since fa212a2b8b60 (and various further other
commits).

The Kconfig build system is now in place.
Use the aarch64-softmmu config as example.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: rephrased the sentence using Thomas suggestion
---
 docs/devel/build-system.txt | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt
index addd274eeb..41bd08ea3a 100644
--- a/docs/devel/build-system.txt
+++ b/docs/devel/build-system.txt
@@ -413,18 +413,13 @@ context.
 - default-configs/*.mak
 
 The files under default-configs/ control what emulated hardware is built
-into each QEMU system and userspace emulator targets. They merely
-contain a long list of config variable definitions. For example,
-default-configs/x86_64-softmmu.mak has:
-
-  include sound.mak
-  include usb.mak
-  CONFIG_QXL=$(CONFIG_SPICE)
-  CONFIG_VGA_ISA=y
-  CONFIG_VGA_CIRRUS=y
-  CONFIG_VMWARE_VGA=y
-  CONFIG_VIRTIO_VGA=y
-  ...snip...
+into each QEMU system and userspace emulator targets. They merely contain
+a list of config variable definitions like the machines that should be
+included. For example, default-configs/aarch64-softmmu.mak has:
+
+  include arm-softmmu.mak
+  CONFIG_XLNX_ZYNQMP_ARM=y
+  CONFIG_XLNX_VERSAL=y
 
 These files rarely need changing unless new devices / hardware need to
 be enabled for a particular system/userspace emulation target
-- 
2.20.1


Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] docs/devel/build-system: Update an example
Posted by Laurent Vivier 4 years, 9 months ago
Le 29/05/2019 à 16:05, Philippe Mathieu-Daudé a écrit :
> The default-configs/ example added in 717171bd2025 is no
> more accurate since fa212a2b8b60 (and various further other
> commits).
> 
> The Kconfig build system is now in place.
> Use the aarch64-softmmu config as example.
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: rephrased the sentence using Thomas suggestion
> ---
>  docs/devel/build-system.txt | 19 +++++++------------
>  1 file changed, 7 insertions(+), 12 deletions(-)
> 
> diff --git a/docs/devel/build-system.txt b/docs/devel/build-system.txt
> index addd274eeb..41bd08ea3a 100644
> --- a/docs/devel/build-system.txt
> +++ b/docs/devel/build-system.txt
> @@ -413,18 +413,13 @@ context.
>  - default-configs/*.mak
>  
>  The files under default-configs/ control what emulated hardware is built
> -into each QEMU system and userspace emulator targets. They merely
> -contain a long list of config variable definitions. For example,
> -default-configs/x86_64-softmmu.mak has:
> -
> -  include sound.mak
> -  include usb.mak
> -  CONFIG_QXL=$(CONFIG_SPICE)
> -  CONFIG_VGA_ISA=y
> -  CONFIG_VGA_CIRRUS=y
> -  CONFIG_VMWARE_VGA=y
> -  CONFIG_VIRTIO_VGA=y
> -  ...snip...
> +into each QEMU system and userspace emulator targets. They merely contain
> +a list of config variable definitions like the machines that should be
> +included. For example, default-configs/aarch64-softmmu.mak has:
> +
> +  include arm-softmmu.mak
> +  CONFIG_XLNX_ZYNQMP_ARM=y
> +  CONFIG_XLNX_VERSAL=y
>  
>  These files rarely need changing unless new devices / hardware need to
>  be enabled for a particular system/userspace emulation target
> 

Applied to my trivial-patches branch.

Thanks,
Laurent