[v1] tests/docker: Update the Fedora image to Fedora 30

[Qemu-devel] [PATCH] tests/docker: Update the Fedora image to Fedora 30

Posted by Philippe Mathieu-Daudé 6 years, 9 months ago

Fedora 30 got released:

  https://fedoramagazine.org/announcing-fedora-30/

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Based-on: <20190408201203.28924-1-marcandre.lureau@redhat.com>
          qxl: fix -Waddress-of-packed-member

Based-on: <20190503112654.4393-1-laurent@vivier.eu>
          Pull request trivial branch 2019-05-03
---
 tests/docker/dockerfiles/fedora.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 69d4a7f5d75..1496b68ba15 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -1,4 +1,4 @@
-FROM fedora:29
+FROM fedora:30
 ENV PACKAGES \
     bc \
     bison \
-- 
2.20.1

Re: [Qemu-devel] [PATCH] tests/docker: Update the Fedora image to Fedora 30

Posted by Philippe Mathieu-Daudé 6 years, 8 months ago

On 5/4/19 8:03 AM, Philippe Mathieu-Daudé wrote:
> Fedora 30 got released:
> 
>   https://fedoramagazine.org/announcing-fedora-30/
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20190408201203.28924-1-marcandre.lureau@redhat.com>
>           qxl: fix -Waddress-of-packed-member
> 
> Based-on: <20190503112654.4393-1-laurent@vivier.eu>
>           Pull request trivial branch 2019-05-03

'based-on' series got merged, ping?

> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 69d4a7f5d75..1496b68ba15 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:29
> +FROM fedora:30
>  ENV PACKAGES \
>      bc \
>      bison \
>

Re: [Qemu-devel] [PATCH] tests/docker: Update the Fedora image to Fedora 30

Posted by Stefano Garzarella 6 years, 8 months ago

On Fri, May 24, 2019 at 09:44:41AM +0200, Philippe Mathieu-Daudé wrote:
> On 5/4/19 8:03 AM, Philippe Mathieu-Daudé wrote:
> > Fedora 30 got released:
> > 
> >   https://fedoramagazine.org/announcing-fedora-30/
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > Based-on: <20190408201203.28924-1-marcandre.lureau@redhat.com>
> >           qxl: fix -Waddress-of-packed-member
> > 
> > Based-on: <20190503112654.4393-1-laurent@vivier.eu>
> >           Pull request trivial branch 2019-05-03
> 
> 'based-on' series got merged, ping?
> 

Tested running 'make docker-test-build@fedora'

Tested-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano

Re: [Qemu-devel] [PATCH] tests/docker: Update the Fedora image to Fedora 30

Posted by no-reply@patchew.org 6 years, 8 months ago

Patchew URL: https://patchew.org/QEMU/20190504060336.21060-1-philmd@redhat.com/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa
=== TEST SCRIPT END ===

    inlined from ‘fill_psinfo’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3208:12,
    inlined from ‘fill_note_info’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3390:5,
    inlined from ‘elf_core_dump’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3539:9:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Werror=stringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


The full log is available at
http://patchew.org/logs/20190504060336.21060-1-philmd@redhat.com/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH] tests/docker: Update the Fedora image to Fedora 30

Posted by Philippe Mathieu-Daudé 6 years, 8 months ago

Hi Patchew,

On 5/24/19 3:28 PM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190504060336.21060-1-philmd@redhat.com/
> 
> 
> 
> Hi,
> 
> This series failed build test on s390x host. Please find the details below.

"20 days later", not yet a movie title.

>     inlined from ‘fill_psinfo’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3208:12,
>     inlined from ‘fill_note_info’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3390:5,
>     inlined from ‘elf_core_dump’ at /var/tmp/patchew-tester-tmp-3g8u4fv2/src/linux-user/elfload.c:3539:9:
> /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Werror=stringop-truncation]
>   106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

This has been fixed by the following commit, merged earlier today:

commit d7eb2b928a855a2e8038e8e75f7edf1a12226bd3
Author: Alistair Francis <Alistair.Francis@wdc.com>
Date:   Tue Apr 30 23:29:01 2019 +0000

    linux-user/elfload: Fix GCC 9 build warnings

    Fix this warning when building with GCC9 on Fedora 30:
    In function ‘strncpy’,
        inlined from ‘fill_psinfo’ at
/home/alistair/qemu/linux-user/elfload.c:3208:12,
        inlined from ‘fill_note_info’ at
/home/alistair/qemu/linux-user/elfload.c:3390:5,
        inlined from ‘elf_core_dump’ at
/home/alistair/qemu/linux-user/elfload.c:3539:9:
    /usr/include/bits/string_fortified.h:106:10: error:
‘__builtin_strncpy’ specified bound 16 equals destination size
[-Werror=stringop-truncation]
      106 |   return __builtin___strncpy_chk (__dest, __src, __len,
__bos (__dest));
          |
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com

Done!

Re: [Qemu-devel] [PATCH] tests/docker: Update the Fedora image to Fedora 30

Posted by Alex Bennée 6 years, 8 months ago

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Fedora 30 got released:
>
>   https://fedoramagazine.org/announcing-fedora-30/
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Queued to testing/next, thanks.

> ---
> Based-on: <20190408201203.28924-1-marcandre.lureau@redhat.com>
>           qxl: fix -Waddress-of-packed-member
>
> Based-on: <20190503112654.4393-1-laurent@vivier.eu>
>           Pull request trivial branch 2019-05-03
> ---
>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 69d4a7f5d75..1496b68ba15 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:29
> +FROM fedora:30
>  ENV PACKAGES \
>      bc \
>      bison \


--
Alex Bennée