[Qemu-devel] [PATCH v2] tests/docker: Update the Fedora image to Fedora 30

Philippe Mathieu-Daudé posted 1 patch 4 years, 10 months ago
Test s390x failed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190528153304.27157-1-philmd@redhat.com
Maintainers: Fam Zheng <fam@euphon.net>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>
tests/docker/dockerfiles/fedora.docker | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH v2] tests/docker: Update the Fedora image to Fedora 30
Posted by Philippe Mathieu-Daudé 4 years, 10 months ago
Fedora 30 got released:

  https://fedoramagazine.org/announcing-fedora-30/

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
---
v2: Added Marc-André and Stefano tags
---
 tests/docker/dockerfiles/fedora.docker | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 69d4a7f5d7..1496b68ba1 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -1,4 +1,4 @@
-FROM fedora:29
+FROM fedora:30
 ENV PACKAGES \
     bc \
     bison \
-- 
2.20.1


Re: [Qemu-devel] [PATCH v2] tests/docker: Update the Fedora image to Fedora 30
Posted by Philippe Mathieu-Daudé 4 years, 10 months ago
Cc'ing Michael/Igor/Stefan about git comment format.

On 5/28/19 5:33 PM, Philippe Mathieu-Daudé wrote:
> Fedora 30 got released:
> 
>   https://fedoramagazine.org/announcing-fedora-30/
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Tested-by: Stefano Garzarella <sgarzare@redhat.com>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> v2: Added Marc-André and Stefano tags

^ This is my local commit

> ---

^ This line was added by git publish via format-patch

Michael is that what break your patch workflow?

>  tests/docker/dockerfiles/fedora.docker | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index 69d4a7f5d7..1496b68ba1 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,4 +1,4 @@
> -FROM fedora:29
> +FROM fedora:30
>  ENV PACKAGES \
>      bc \
>      bison \
> 

Re: [Qemu-devel] [PATCH v2] tests/docker: Update the Fedora image to Fedora 30
Posted by Michael S. Tsirkin 4 years, 10 months ago
On Tue, May 28, 2019 at 05:36:54PM +0200, Philippe Mathieu-Daudé wrote:
> Cc'ing Michael/Igor/Stefan about git comment format.
> 
> On 5/28/19 5:33 PM, Philippe Mathieu-Daudé wrote:
> > Fedora 30 got released:
> > 
> >   https://fedoramagazine.org/announcing-fedora-30/
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Tested-by: Stefano Garzarella <sgarzare@redhat.com>
> > Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> > ---
> > v2: Added Marc-André and Stefano tags
> 
> ^ This is my local commit
> 
> > ---
> 
> ^ This line was added by git publish via format-patch
> 
> Michael is that what break your patch workflow?


Used to but seems to work fine now.
So I guess you can ignore me sorry about the noise.

> >  tests/docker/dockerfiles/fedora.docker | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> > index 69d4a7f5d7..1496b68ba1 100644
> > --- a/tests/docker/dockerfiles/fedora.docker
> > +++ b/tests/docker/dockerfiles/fedora.docker
> > @@ -1,4 +1,4 @@
> > -FROM fedora:29
> > +FROM fedora:30
> >  ENV PACKAGES \
> >      bc \
> >      bison \
> > 

Re: [Qemu-devel] [PATCH v2] tests/docker: Update the Fedora image to Fedora 30
Posted by Philippe Mathieu-Daudé 4 years, 10 months ago
On 5/28/19 6:08 PM, Michael S. Tsirkin wrote:
> On Tue, May 28, 2019 at 05:36:54PM +0200, Philippe Mathieu-Daudé wrote:
>> Cc'ing Michael/Igor/Stefan about git comment format.
>>
>> On 5/28/19 5:33 PM, Philippe Mathieu-Daudé wrote:
>>> Fedora 30 got released:
>>>
>>>   https://fedoramagazine.org/announcing-fedora-30/
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>>> Tested-by: Stefano Garzarella <sgarzare@redhat.com>
>>> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>>> ---
>>> v2: Added Marc-André and Stefano tags
>>
>> ^ This is my local commit
>>
>>> ---
>>
>> ^ This line was added by git publish via format-patch
>>
>> Michael is that what break your patch workflow?
> 
> 
> Used to but seems to work fine now.
> So I guess you can ignore me sorry about the noise.

Good to know :)

Thanks,

Phil.

Re: [Qemu-devel] [PATCH v2] tests/docker: Update the Fedora image to Fedora 30
Posted by Alex Bennée 4 years, 10 months ago
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Fedora 30 got released:
>
>   https://fedoramagazine.org/announcing-fedora-30/
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Tested-by: Stefano Garzarella <sgarzare@redhat.com>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> v2: Added Marc-André and Stefano tags


Queued to testing/next, thanks (right one this time).

--
Alex Bennée