[v2] configure: disallow spaces and colons in source path and build path

[Qemu-devel] [PATCH v2 0/2] configure: disallow spaces and colons in source path and build path

Antonio Ospite posted 2 patches 4 years, 12 months ago

Diff against v3
Download series mbox

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190503082728.16485-1-ao2@ao2.it

There is a newer version of this series

Makefile  |  4 ++++
configure | 12 +++++++++---
2 files changed, 13 insertions(+), 3 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/2] configure: disallow spaces and colons in source path and build path

Posted by Antonio Ospite 4 years, 12 months ago

Hi,

Here is a v2 patch set to address
https://bugs.launchpad.net/qemu/+bug/1817345

The series follows up to:
https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05290.html
https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05573.html

Changes since v1:
  - Add a preparatory patch to set source_path only once and in a more
    robust way.

  - Move the checks in configure after the source_path definition to
    avoid using realpath which is not available everywhere.

  - Cover also the build path in Makefile. An extensive explanation of
    why I think this is needed is here:
    https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05398.html

Thanks,
   Antonio

Antonio Ospite (2):
  configure: set source_path only once and make its definition more
    robust
  configure: disallow spaces and colons in source path and build path

 Makefile  |  4 ++++
 configure | 12 +++++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?