[Qemu-devel] [PATCH v3 0/2] configure: disallow spaces and colons in source path and build path

Antonio Ospite posted 2 patches 4 years, 10 months ago
Test FreeBSD passed
Test docker-clang@ubuntu passed
Test s390x failed
Test docker-mingw@fedora passed
Test checkpatch passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190526144747.30019-1-ao2@ao2.it
Makefile  |  4 ++++
configure | 11 ++++++++---
2 files changed, 12 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH v3 0/2] configure: disallow spaces and colons in source path and build path
Posted by Antonio Ospite 4 years, 10 months ago
Hi,

Here is a v3 set to address
https://bugs.launchpad.net/qemu/+bug/1817345

CCing Laurent Vivier as the patch is going through the trivial-patches
branch.

The series follows up to:
https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg00562.html

Changes since v2:
  - Shorten 'if' check as suggested by Eric Blake in
    https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg01190.html

  - Added Reviewed-by tags by Eric Blake.


Changes since v1:
  - Add a preparatory patch to set source_path only once and in a more
    robust way.

  - Move the checks in configure after the source_path definition to
    avoid using realpath which is not available everywhere.

  - Cover also the build path in Makefile. An extensive explanation of
    why I think this is needed is here:
    https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05398.html

Thank you,
   Antonio


Antonio Ospite (2):
  configure: set source_path only once and make its definition more
    robust
  configure: disallow spaces and colons in source path and build path

 Makefile  |  4 ++++
 configure | 11 ++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Re: [Qemu-devel] [PATCH v3 0/2] configure: disallow spaces and colons in source path and build path
Posted by Antonio Ospite 4 years, 9 months ago
On 26/05/19 16:47, Antonio Ospite wrote:
> Hi,
> 
> Here is a v3 set to address
> https://bugs.launchpad.net/qemu/+bug/1817345
> 
> CCing Laurent Vivier as the patch is going through the trivial-patches
> branch.
>

Ping.

I cannot see this in the trivial-patches repository nor in mainline qemu.

Thanks,
    Antonio

> The series follows up to:
> https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg00562.html
> 
> Changes since v2:
>    - Shorten 'if' check as suggested by Eric Blake in
>      https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg01190.html
> 
>    - Added Reviewed-by tags by Eric Blake.
> 
> 
> Changes since v1:
>    - Add a preparatory patch to set source_path only once and in a more
>      robust way.
> 
>    - Move the checks in configure after the source_path definition to
>      avoid using realpath which is not available everywhere.
> 
>    - Cover also the build path in Makefile. An extensive explanation of
>      why I think this is needed is here:
>      https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05398.html
> 
> Thank you,
>     Antonio
> 
> 
> Antonio Ospite (2):
>    configure: set source_path only once and make its definition more
>      robust
>    configure: disallow spaces and colons in source path and build path
> 
>   Makefile  |  4 ++++
>   configure | 11 ++++++++---
>   2 files changed, 12 insertions(+), 3 deletions(-)
> 


Re: [Qemu-devel] [PATCH v3 0/2] configure: disallow spaces and colons in source path and build path
Posted by Eric Blake 4 years, 9 months ago
On 6/26/19 10:16 AM, Antonio Ospite wrote:
> On 26/05/19 16:47, Antonio Ospite wrote:
>> Hi,
>>
>> Here is a v3 set to address
>> https://bugs.launchpad.net/qemu/+bug/1817345
>>
>> CCing Laurent Vivier as the patch is going through the trivial-patches
>> branch.
>>
> 
> Ping.
> 
> I cannot see this in the trivial-patches repository nor in mainline qemu.
> 

Explicitly adding qemu-trivial in cc may help (done now).

>> Antonio Ospite (2):
>>    configure: set source_path only once and make its definition more
>>      robust
>>    configure: disallow spaces and colons in source path and build path
>>
>>   Makefile  |  4 ++++
>>   configure | 11 ++++++++---
>>   2 files changed, 12 insertions(+), 3 deletions(-)
>>
> 
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH v3 0/2] configure: disallow spaces and colons in source path and build path
Posted by Laurent Vivier 4 years, 9 months ago
Le 26/06/2019 à 17:16, Antonio Ospite a écrit :
> On 26/05/19 16:47, Antonio Ospite wrote:
>> Hi,
>>
>> Here is a v3 set to address
>> https://bugs.launchpad.net/qemu/+bug/1817345
>>
>> CCing Laurent Vivier as the patch is going through the trivial-patches
>> branch.
>>
> 
> Ping.
> 
> I cannot see this in the trivial-patches repository nor in mainline qemu.
> 

I missed it because you didn't cc: qemu-trivial ML (I use this list to
pick up the patches).

I'm going to add them to the next pull request.

Thanks,
Laurent

Re: [Qemu-devel] [PATCH v3 0/2] configure: disallow spaces and colons in source path and build path
Posted by Antonio Ospite 4 years, 9 months ago
On 26/06/19 17:50, Laurent Vivier wrote:
> Le 26/06/2019 à 17:16, Antonio Ospite a écrit :
>> On 26/05/19 16:47, Antonio Ospite wrote:
>>> Hi,
>>>
>>> Here is a v3 set to address
>>> https://bugs.launchpad.net/qemu/+bug/1817345
>>>
>>> CCing Laurent Vivier as the patch is going through the trivial-patches
>>> branch.
>>>
>>
>> Ping.
>>
>> I cannot see this in the trivial-patches repository nor in mainline qemu.
>>
> 
> I missed it because you didn't cc: qemu-trivial ML (I use this list to
> pick up the patches).
>

Ah yes, I had read that on
https://wiki.qemu.org/Contribute/TrivialPatches
but then forgot about it.

> I'm going to add them to the next pull request.
> 
> Thanks,
> Laurent
> 

Thank you,
    Antonio