target/mips: Errors and warnings cleanup

[Qemu-devel] [PATCH v4 0/3] target/mips: Errors and warnings cleanup

Posted by Jules Irenge 5 years ago

This v4 series combines two previously distinct patches into one patch
replace tab code indent patch and the add or rmove space into 
one patch add or remove space patch.

Jules Irenge (3):
  target/mips: add or remove space to fix checkpatch errors
  target/mips: realign comments to fix checkpatch warnings
  target/mips: wrap lines to fix checkpatch errors

 target/mips/cpu.h | 211 +++++++++++++++++++++++++---------------------
 1 file changed, 117 insertions(+), 94 deletions(-)

-- 
2.20.1

Re: [Qemu-devel] [PATCH v4 0/3] target/mips: Errors and warnings cleanup

Posted by no-reply@patchew.org 5 years ago

Patchew URL: https://patchew.org/QEMU/20190413011302.6610-1-jbi.octave@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190413011302.6610-1-jbi.octave@gmail.com
Subject: [Qemu-devel] [PATCH v4 0/3] target/mips: Errors and warnings cleanup
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190411100836.646-1-david@redhat.com -> patchew/20190411100836.646-1-david@redhat.com
 t [tag update]            patchew/20190411135602.21725-1-armbru@redhat.com -> patchew/20190411135602.21725-1-armbru@redhat.com
 * [new tag]               patchew/20190413011302.6610-1-jbi.octave@gmail.com -> patchew/20190413011302.6610-1-jbi.octave@gmail.com
Switched to a new branch 'test'
b82e079d5d target/mips: wrap lines to fix checkpatch errors
e3336f43ef target/mips: realign comments to fix checkpatch warnings
24e1c597a9 target/mips: add or remove space to fix checkpatch errors

=== OUTPUT BEGIN ===
1/3 Checking commit 24e1c597a9f5 (target/mips: add or remove space to fix checkpatch errors)
ERROR: line over 90 characters
#44: FILE: target/mips/cpu.h:74:
+#define SET_FP_COND(num, env)     do { ((env).fcr31) |= ((num) ? (1 << ((num) + 24)) : (1 << 23)); } while (0)

ERROR: line over 90 characters
#45: FILE: target/mips/cpu.h:75:
+#define CLEAR_FP_COND(num, env)   do { ((env).fcr31) &= ~((num) ? (1 << ((num) + 24)) : (1 << 23)); } while (0)

ERROR: line over 90 characters
#54: FILE: target/mips/cpu.h:80:
+#define SET_FP_CAUSE(reg, v)      do { (reg) = ((reg) & ~(0x3f << 12)) | ((v & 0x3f) << 12); } while (0)

ERROR: line over 90 characters
#55: FILE: target/mips/cpu.h:81:
+#define SET_FP_ENABLE(reg, v)     do { (reg) = ((reg) & ~(0x1f <<  7)) | ((v & 0x1f) << 7); } while (0)

ERROR: line over 90 characters
#56: FILE: target/mips/cpu.h:82:
+#define SET_FP_FLAGS(reg, v)      do { (reg) = ((reg) & ~(0x1f <<  2)) | ((v & 0x1f) << 2); } while (0)

total: 5 errors, 0 warnings, 230 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit e3336f43efe0 (target/mips: realign comments to fix checkpatch warnings)
3/3 Checking commit b82e079d5d91 (target/mips: wrap lines to fix checkpatch errors)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190413011302.6610-1-jbi.octave@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com