[Qemu-devel] [PATCH v2 0/2] target/mips: errors and warnings cleanups

Jules Irenge posted 2 patches 5 years, 1 month ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch failed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190404173921.30841-1-jbi.octave@gmail.com
Maintainers: Aleksandar Markovic <amarkovic@wavecomp.com>, Aleksandar Rikalo <arikalo@wavecomp.com>, Aurelien Jarno <aurelien@aurel32.net>
There is a newer version of this series
target/mips/cpu.h | 60 +++++++++++++++++++++++++++--------------------
1 file changed, 35 insertions(+), 25 deletions(-)
[Qemu-devel] [PATCH v2 0/2] target/mips: errors and warnings cleanups
Posted by Jules Irenge 5 years, 1 month ago
This v2 series combines previous two patches into one and removes some
left trailing spaces

Jules Irenge (2):
  target/mips: realign comments to fix checkpatch warnings
  target/mips: add or remove space to fix checkpatch errors

 target/mips/cpu.h | 60 +++++++++++++++++++++++++++--------------------
 1 file changed, 35 insertions(+), 25 deletions(-)

-- 
2.20.1


Re: [Qemu-devel] [PATCH v2 0/2] target/mips: errors and warnings cleanups
Posted by no-reply@patchew.org 5 years, 1 month ago
Patchew URL: https://patchew.org/QEMU/20190404173921.30841-1-jbi.octave@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v2 0/2] target/mips: errors and warnings cleanups
Message-id: 20190404173921.30841-1-jbi.octave@gmail.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20190404173921.30841-1-jbi.octave@gmail.com -> patchew/20190404173921.30841-1-jbi.octave@gmail.com
Switched to a new branch 'test'
98abd4d target/mips: add or remove space to fix checkpatch errors
11f40fe target/mips: realign comments to fix checkpatch warnings

=== OUTPUT BEGIN ===
1/2 Checking commit 11f40fe1fa16 (target/mips: realign comments to fix checkpatch warnings)
2/2 Checking commit 98abd4d88462 (target/mips: add or remove space to fix checkpatch errors)
ERROR: line over 90 characters
#42: FILE: target/mips/cpu.h:75:
+#define SET_FP_COND(num, env)     do { ((env).fcr31) |= ((num) ? (1 << ((num) + 24)) : (1 << 23)); } while (0)

ERROR: line over 90 characters
#43: FILE: target/mips/cpu.h:76:
+#define CLEAR_FP_COND(num, env)   do { ((env).fcr31) &= ~((num) ? (1 << ((num) + 24)) : (1 << 23)); } while (0)

ERROR: line over 90 characters
#52: FILE: target/mips/cpu.h:81:
+#define SET_FP_CAUSE(reg, v)      do { (reg) = ((reg) & ~(0x3f << 12)) | ((v & 0x3f) << 12); } while (0)

ERROR: line over 90 characters
#53: FILE: target/mips/cpu.h:82:
+#define SET_FP_ENABLE(reg, v)     do { (reg) = ((reg) & ~(0x1f <<  7)) | ((v & 0x1f) << 7); } while (0)

ERROR: line over 90 characters
#54: FILE: target/mips/cpu.h:83:
+#define SET_FP_FLAGS(reg, v)      do { (reg) = ((reg) & ~(0x1f <<  2)) | ((v & 0x1f) << 2); } while (0)

total: 5 errors, 0 warnings, 68 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190404173921.30841-1-jbi.octave@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com