[v1] build: cleanup in Makefile.objs

[Qemu-devel] [PATCH 0/4] build: cleanup in Makefile.objs

Laurent Vivier posted 4 patches 5 years, 1 month ago

Diff against v2 v3
Download series mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu failed

Test asan passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190321124624.26131-1-lvivier@redhat.com

There is a newer version of this series

Makefile               |  2 ++
Makefile.objs          | 44 ++++++++++++++++++++++++------------------
tests/Makefile.include | 26 ++++++++++++++-----------
3 files changed, 42 insertions(+), 30 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/4] build: cleanup in Makefile.objs

Posted by Laurent Vivier 5 years, 1 month ago

This cleanup removes hardware objects from the list of files to be
built for linux-user only targets.

It also builds traces files only when the related file is built.

Tested with:

   configure --enable-user --disable-system
   configure --disable-user --disable-system
   configure --disable-user --enable-system

Laurent Vivier (4):
  trace: only include trace-event-subdirs when they are needed
  ui: build keymap only with softmmu targets
  tools: edid-generate.c is part of the tools
  build: don't build hardware objects with linux-user

 Makefile               |  2 ++
 Makefile.objs          | 44 ++++++++++++++++++++++++------------------
 tests/Makefile.include | 26 ++++++++++++++-----------
 3 files changed, 42 insertions(+), 30 deletions(-)

-- 
2.20.1

Re: [Qemu-devel] [PATCH 0/4] build: cleanup in Makefile.objs

Posted by Paolo Bonzini 5 years, 1 month ago

On 21/03/19 13:46, Laurent Vivier wrote:
> This cleanup removes hardware objects from the list of files to be
> built for linux-user only targets.
> 
> It also builds traces files only when the related file is built.
> 
> Tested with:
> 
>    configure --enable-user --disable-system
>    configure --disable-user --disable-system
>    configure --disable-user --enable-system
> 
> Laurent Vivier (4):
>   trace: only include trace-event-subdirs when they are needed
>   ui: build keymap only with softmmu targets
>   tools: edid-generate.c is part of the tools
>   build: don't build hardware objects with linux-user
> 
>  Makefile               |  2 ++
>  Makefile.objs          | 44 ++++++++++++++++++++++++------------------
>  tests/Makefile.include | 26 ++++++++++++++-----------
>  3 files changed, 42 insertions(+), 30 deletions(-)
> 

Hi Laurent,

I am not sure if the extra complexity is worth the reduction in build
times for the --disable-system case, but I guess a simpler version of
these patches would be okay.

Paolo