[Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs

Laurent Vivier posted 5 patches 4 years, 12 months ago
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190401141222.30034-1-lvivier@redhat.com
Maintainers: David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <rth@twiddle.net>
Makefile                   |  43 +++++++-------
Makefile.objs              |  22 ++++---
Makefile.target            |   6 +-
configure                  |   4 +-
target/s390x/Makefile.objs |   2 +-
tests/Makefile.include     | 116 ++++++++++++++++++-------------------
6 files changed, 102 insertions(+), 91 deletions(-)
[Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs
Posted by Laurent Vivier 4 years, 12 months ago
This cleanup removes hardware objects from the list of files to be
built for linux-user only targets.

It also builds traces files only when the related file is built.

Tested with all combinations of --{disable,enable}-{system,user,tools}

v3:
  - don't move hw/display to CONFIG_BLOCK section
v2:
  - add CONFIG_TOOLS and CONFIG_BLOCK
  - replace GENERATED_FILES by generated-files-y
    and use generated-files-${CONFIG_TRACE_UST} and
    generated-files-${CONFIG_SOFTMMU}
  - move chardev-obj-y from SUBDIR_RULES to SOFTMMU_SUBDIR_RULES
  - use $(CONFIG_BLOCK) in tests/Makefile.include
  - disable qemu-ga with linux-user only

Laurent Vivier (5):
  trace: only include trace-event-subdirs when they are needed
  build: replace GENERATED_FILES by generated-files-y
  configure: qemu-ga is only needed with softmmu targets
  build: chardev is only needed for softmmu targets
  build: don't build hardware objects with linux-user

 Makefile                   |  43 +++++++-------
 Makefile.objs              |  22 ++++---
 Makefile.target            |   6 +-
 configure                  |   4 +-
 target/s390x/Makefile.objs |   2 +-
 tests/Makefile.include     | 116 ++++++++++++++++++-------------------
 6 files changed, 102 insertions(+), 91 deletions(-)

-- 
2.20.1


Re: [Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs
Posted by Paolo Bonzini 4 years, 12 months ago
On 01/04/19 16:12, Laurent Vivier wrote:
> This cleanup removes hardware objects from the list of files to be
> built for linux-user only targets.
> 
> It also builds traces files only when the related file is built.
> 
> Tested with all combinations of --{disable,enable}-{system,user,tools}
> 
> v3:
>   - don't move hw/display to CONFIG_BLOCK section
> v2:
>   - add CONFIG_TOOLS and CONFIG_BLOCK
>   - replace GENERATED_FILES by generated-files-y
>     and use generated-files-${CONFIG_TRACE_UST} and
>     generated-files-${CONFIG_SOFTMMU}
>   - move chardev-obj-y from SUBDIR_RULES to SOFTMMU_SUBDIR_RULES
>   - use $(CONFIG_BLOCK) in tests/Makefile.include
>   - disable qemu-ga with linux-user only
> 
> Laurent Vivier (5):
>   trace: only include trace-event-subdirs when they are needed
>   build: replace GENERATED_FILES by generated-files-y
>   configure: qemu-ga is only needed with softmmu targets
>   build: chardev is only needed for softmmu targets
>   build: don't build hardware objects with linux-user
> 
>  Makefile                   |  43 +++++++-------
>  Makefile.objs              |  22 ++++---
>  Makefile.target            |   6 +-
>  configure                  |   4 +-
>  target/s390x/Makefile.objs |   2 +-
>  tests/Makefile.include     | 116 ++++++++++++++++++-------------------
>  6 files changed, 102 insertions(+), 91 deletions(-)
> 

Queued for 4.1, thanks.

Paolo

Re: [Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs
Posted by Laurent Vivier 4 years, 10 months ago
On 02/04/2019 10:08, Paolo Bonzini wrote:
> On 01/04/19 16:12, Laurent Vivier wrote:
>> This cleanup removes hardware objects from the list of files to be
>> built for linux-user only targets.
>>
>> It also builds traces files only when the related file is built.
>>
>> Tested with all combinations of --{disable,enable}-{system,user,tools}
>>
>> v3:
>>    - don't move hw/display to CONFIG_BLOCK section
>> v2:
>>    - add CONFIG_TOOLS and CONFIG_BLOCK
>>    - replace GENERATED_FILES by generated-files-y
>>      and use generated-files-${CONFIG_TRACE_UST} and
>>      generated-files-${CONFIG_SOFTMMU}
>>    - move chardev-obj-y from SUBDIR_RULES to SOFTMMU_SUBDIR_RULES
>>    - use $(CONFIG_BLOCK) in tests/Makefile.include
>>    - disable qemu-ga with linux-user only
>>
>> Laurent Vivier (5):
>>    trace: only include trace-event-subdirs when they are needed
>>    build: replace GENERATED_FILES by generated-files-y
>>    configure: qemu-ga is only needed with softmmu targets
>>    build: chardev is only needed for softmmu targets
>>    build: don't build hardware objects with linux-user
>>
>>   Makefile                   |  43 +++++++-------
>>   Makefile.objs              |  22 ++++---
>>   Makefile.target            |   6 +-
>>   configure                  |   4 +-
>>   target/s390x/Makefile.objs |   2 +-
>>   tests/Makefile.include     | 116 ++++++++++++++++++-------------------
>>   6 files changed, 102 insertions(+), 91 deletions(-)
>>
> 
> Queued for 4.1, thanks.

Any news?

Thanks,
Laurent


Re: [Qemu-devel] [PATCH v3 0/5] build: cleanup in Makefile.objs
Posted by Paolo Bonzini 4 years, 10 months ago
Will send it out this week.

Paolo


Il lun 13 mag 2019, 16:18 Laurent Vivier <lvivier@redhat.com> ha scritto:

> On 02/04/2019 10:08, Paolo Bonzini wrote:
> > On 01/04/19 16:12, Laurent Vivier wrote:
> >> This cleanup removes hardware objects from the list of files to be
> >> built for linux-user only targets.
> >>
> >> It also builds traces files only when the related file is built.
> >>
> >> Tested with all combinations of --{disable,enable}-{system,user,tools}
> >>
> >> v3:
> >>    - don't move hw/display to CONFIG_BLOCK section
> >> v2:
> >>    - add CONFIG_TOOLS and CONFIG_BLOCK
> >>    - replace GENERATED_FILES by generated-files-y
> >>      and use generated-files-${CONFIG_TRACE_UST} and
> >>      generated-files-${CONFIG_SOFTMMU}
> >>    - move chardev-obj-y from SUBDIR_RULES to SOFTMMU_SUBDIR_RULES
> >>    - use $(CONFIG_BLOCK) in tests/Makefile.include
> >>    - disable qemu-ga with linux-user only
> >>
> >> Laurent Vivier (5):
> >>    trace: only include trace-event-subdirs when they are needed
> >>    build: replace GENERATED_FILES by generated-files-y
> >>    configure: qemu-ga is only needed with softmmu targets
> >>    build: chardev is only needed for softmmu targets
> >>    build: don't build hardware objects with linux-user
> >>
> >>   Makefile                   |  43 +++++++-------
> >>   Makefile.objs              |  22 ++++---
> >>   Makefile.target            |   6 +-
> >>   configure                  |   4 +-
> >>   target/s390x/Makefile.objs |   2 +-
> >>   tests/Makefile.include     | 116 ++++++++++++++++++-------------------
> >>   6 files changed, 102 insertions(+), 91 deletions(-)
> >>
> >
> > Queued for 4.1, thanks.
>
> Any news?
>
> Thanks,
> Laurent
>
>