[v4] Fixes for PulseAudio driver

[Qemu-devel] [PATCH V4 0/3] Fixes for PulseAudio driver

Martin Schrodt posted 3 patches 5 years, 1 month ago

Diff against v1 v2
Download series mbox

Test checkpatch passed

Test docker-clang@ubuntu passed

Test asan passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190315084653.120020-1-martin@schrodt.org

Maintainers: Eric Blake <eblake@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>

audio/paaudio.c | 44 ++++++++++++++++++++++++++++++++++----------
qapi/audio.json |  6 +++++-
2 files changed, 39 insertions(+), 11 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH V4 0/3] Fixes for PulseAudio driver

Posted by Martin Schrodt 5 years, 1 month ago

Version 2 of the series added proper commit messages 
and fixed a typo.

Version 3 fixes coding style problems

Version 4 reintroduces the check, whether PA support adjusting
latency, and sets the default buffer_length to the constant value
that was present beforehand (works well, and testing revealed that 
having a longer buffer does not hurt, so it's propably better to 
not make it artificially short when the user chooses shorter 
timer periods)

Martin Schrodt (3):
  audio/paaudio: fix ignored buffer_length setting
  audio/paaudio: prolong and make latency configurable
  audio/paaudio: fix microphone input being unusable

 audio/paaudio.c | 44 ++++++++++++++++++++++++++++++++++----------
 qapi/audio.json |  6 +++++-
 2 files changed, 39 insertions(+), 11 deletions(-)

-- 
2.21.0

Re: [Qemu-devel] [PATCH V4 0/3] Fixes for PulseAudio driver

Posted by Gerd Hoffmann 5 years, 1 month ago

On Fri, Mar 15, 2019 at 09:46:50AM +0100, Martin Schrodt wrote:
> Version 2 of the series added proper commit messages 
> and fixed a typo.
> 
> Version 3 fixes coding style problems
> 
> Version 4 reintroduces the check, whether PA support adjusting
> latency, and sets the default buffer_length to the constant value
> that was present beforehand (works well, and testing revealed that 
> having a longer buffer does not hurt, so it's propably better to 
> not make it artificially short when the user chooses shorter 
> timer periods)
> 
> Martin Schrodt (3):
>   audio/paaudio: fix ignored buffer_length setting
>   audio/paaudio: prolong and make latency configurable
>   audio/paaudio: fix microphone input being unusable

Added to audio queue.

thanks,
  Gerd