From nobody Thu Apr 25 17:17:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552639756026299.93131318164797; Fri, 15 Mar 2019 01:49:16 -0700 (PDT) Received: from localhost ([127.0.0.1]:51938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4iWc-0007mT-S2 for importer@patchew.org; Fri, 15 Mar 2019 04:49:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4iUc-0006vl-0R for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4iUY-0001B5-7H for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:05 -0400 Received: from [2a01:4f8:141:20d3::2] (port=58396 helo=zapp.schrodt.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4iUU-00017D-JV for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:00 -0400 Received: from schapa.schrodt.org ([46.237.225.84]:39904 helo=zoidberg.machine.schrodt.org) by zapp.schrodt.org with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1h4iUQ-0000zR-8W; Fri, 15 Mar 2019 09:46:54 +0100 Received: from spheenik by zoidberg.machine.schrodt.org with local (Exim 4.92) (envelope-from ) id 1h4iUP-000VGy-VJ; Fri, 15 Mar 2019 09:46:53 +0100 From: Martin Schrodt To: qemu-devel@nongnu.org Date: Fri, 15 Mar 2019 09:46:51 +0100 Message-Id: <20190315084653.120020-2-martin@schrodt.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190315084653.120020-1-martin@schrodt.org> References: <20190315084653.120020-1-martin@schrodt.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:141:20d3::2 Subject: [Qemu-devel] [PATCH V4 1/3] audio/paaudio: fix ignored buffer_length setting X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Audiodev configuration allows to set the length of the buffered data. The setting was ignored and a constant value used instead. This patch makes the code apply the setting properly, and uses the previous default if nothing is supplied. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 24 +++++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 5d410ed73f..ab2a37bbdb 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -577,7 +577,8 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsetti= ngs *as, =20 audio_pcm_init_info (&hw->info, &obt_as); hw->samples =3D pa->samples =3D audio_buffer_samples( - qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); + qapi_AudiodevPaPerDirectionOptions_base(ppdo), + &obt_as, ppdo->buffer_length); pa->pcm_buf =3D audio_calloc(__func__, hw->samples, 1 << hw->info.shif= t); pa->rpos =3D hw->rpos; if (!pa->pcm_buf) { @@ -637,7 +638,8 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsetting= s *as, void *drv_opaque) =20 audio_pcm_init_info (&hw->info, &obt_as); hw->samples =3D pa->samples =3D audio_buffer_samples( - qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440); + qapi_AudiodevPaPerDirectionOptions_base(ppdo), + &obt_as, ppdo->buffer_length); pa->pcm_buf =3D audio_calloc(__func__, hw->samples, 1 << hw->info.shif= t); pa->wpos =3D hw->wpos; if (!pa->pcm_buf) { @@ -809,7 +811,16 @@ static int qpa_ctl_in (HWVoiceIn *hw, int cmd, ...) return 0; } =20 -/* common */ +static int qpa_validate_per_direction_opts(Audiodev *dev, + AudiodevPaPerDirectionOptions *= pdo) +{ + if (!pdo->has_buffer_length) { + pdo->has_buffer_length =3D true; + pdo->buffer_length =3D 46440; + } + return 1; +} + static void *qpa_audio_init(Audiodev *dev) { paaudio *g; @@ -836,6 +847,13 @@ static void *qpa_audio_init(Audiodev *dev) g =3D g_malloc(sizeof(paaudio)); server =3D popts->has_server ? popts->server : NULL; =20 + if (!qpa_validate_per_direction_opts(dev, popts->in)) { + goto fail; + } + if (!qpa_validate_per_direction_opts(dev, popts->out)) { + goto fail; + } + g->dev =3D dev; g->mainloop =3D NULL; g->context =3D NULL; --=20 2.21.0 From nobody Thu Apr 25 17:17:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552639757825256.51716298042595; Fri, 15 Mar 2019 01:49:17 -0700 (PDT) Received: from localhost ([127.0.0.1]:51942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4iWd-0007nz-LR for importer@patchew.org; Fri, 15 Mar 2019 04:49:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4iUc-0006vk-0Z for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4iUY-0001BW-HF for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:05 -0400 Received: from [2a01:4f8:141:20d3::2] (port=58400 helo=zapp.schrodt.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4iUW-00017A-4f for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:02 -0400 Received: from schapa.schrodt.org ([46.237.225.84]:39898 helo=zoidberg.machine.schrodt.org) by zapp.schrodt.org with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1h4iUQ-0000zO-8V; Fri, 15 Mar 2019 09:46:54 +0100 Received: from spheenik by zoidberg.machine.schrodt.org with local (Exim 4.92) (envelope-from ) id 1h4iUP-000VH0-Vt; Fri, 15 Mar 2019 09:46:53 +0100 From: Martin Schrodt To: qemu-devel@nongnu.org Date: Fri, 15 Mar 2019 09:46:52 +0100 Message-Id: <20190315084653.120020-3-martin@schrodt.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190315084653.120020-1-martin@schrodt.org> References: <20190315084653.120020-1-martin@schrodt.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:141:20d3::2 Subject: [Qemu-devel] [PATCH V4 2/3] audio/paaudio: prolong and make latency configurable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The latency of a connection to the PulseAudio server is determined by the tlength parameter. This was hardcoded to 10ms, which is a bit too tight on my machine, causing audio on host and guest to malfunction. A setting of 15ms works fine here. To allow tweaking, I also made the setting configurable via the new -audiodev config. This allows to squeeze o= ut better timings in scenarios where the emulation allows it. I also removed setting of the minreq parameter to (seemingly arbitrary) hal= f the latency, since it showed worse audio quality during my tests. Allowin= g PulseAudio to request smaller chunks helped. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 12 ++++++------ qapi/audio.json | 6 +++++- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index ab2a37bbdb..be27c73f09 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -549,12 +549,8 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsett= ings *as, ss.channels =3D as->nchannels; ss.rate =3D as->freq; =20 - /* - * qemu audio tick runs at 100 Hz (by default), so processing - * data chunks worth 10 ms of sound should be a good fit. - */ - ba.tlength =3D pa_usec_to_bytes (10 * 1000, &ss); - ba.minreq =3D pa_usec_to_bytes (5 * 1000, &ss); + ba.tlength =3D pa_usec_to_bytes(ppdo->latency, &ss); + ba.minreq =3D -1; ba.maxlength =3D -1; ba.prebuf =3D -1; =20 @@ -818,6 +814,10 @@ static int qpa_validate_per_direction_opts(Audiodev *d= ev, pdo->has_buffer_length =3D true; pdo->buffer_length =3D 46440; } + if (!pdo->has_latency) { + pdo->has_latency =3D true; + pdo->latency =3D 15000; + } return 1; } =20 diff --git a/qapi/audio.json b/qapi/audio.json index 97aee37288..9fefdf5186 100644 --- a/qapi/audio.json +++ b/qapi/audio.json @@ -206,12 +206,16 @@ # # @name: name of the sink/source to use # +# @latency: latency you want PulseAudio to achieve in microseconds +# (default 15000) +# # Since: 4.0 ## { 'struct': 'AudiodevPaPerDirectionOptions', 'base': 'AudiodevPerDirectionOptions', 'data': { - '*name': 'str' } } + '*name': 'str', + '*latency': 'uint32' } } =20 ## # @AudiodevPaOptions: --=20 2.21.0 From nobody Thu Apr 25 17:17:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1552639865037870.1406259266605; Fri, 15 Mar 2019 01:51:05 -0700 (PDT) Received: from localhost ([127.0.0.1]:51984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4iYO-0000yE-Lx for importer@patchew.org; Fri, 15 Mar 2019 04:51:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4iUb-0006vi-TI for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4iUY-0001B1-7A for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:04 -0400 Received: from [2a01:4f8:141:20d3::2] (port=58394 helo=zapp.schrodt.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h4iUW-00017B-41 for qemu-devel@nongnu.org; Fri, 15 Mar 2019 04:47:01 -0400 Received: from schapa.schrodt.org ([46.237.225.84]:39902 helo=zoidberg.machine.schrodt.org) by zapp.schrodt.org with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1h4iUQ-0000zQ-8V; Fri, 15 Mar 2019 09:46:54 +0100 Received: from spheenik by zoidberg.machine.schrodt.org with local (Exim 4.92) (envelope-from ) id 1h4iUQ-000VH2-0A; Fri, 15 Mar 2019 09:46:54 +0100 From: Martin Schrodt To: qemu-devel@nongnu.org Date: Fri, 15 Mar 2019 09:46:53 +0100 Message-Id: <20190315084653.120020-4-martin@schrodt.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190315084653.120020-1-martin@schrodt.org> References: <20190315084653.120020-1-martin@schrodt.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:141:20d3::2 Subject: [Qemu-devel] [PATCH V4 3/3] audio/paaudio: fix microphone input being unusable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The current code does not specify the metrics of the buffers for the input device. This makes PulseAudio choose very bad defaults, which causes input to be unusable: Audio put in gets out 30 seconds later. This patch fixes that and makes the latency configurable as well. Signed-off-by: Martin Schrodt --- audio/paaudio.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index be27c73f09..45295b4e5e 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -605,6 +605,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsetting= s *as, void *drv_opaque) { int error; pa_sample_spec ss; + pa_buffer_attr ba; struct audsettings obt_as =3D *as; PAVoiceIn *pa =3D (PAVoiceIn *) hw; paaudio *g =3D pa->g =3D drv_opaque; @@ -615,6 +616,11 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsettin= gs *as, void *drv_opaque) ss.channels =3D as->nchannels; ss.rate =3D as->freq; =20 + ba.fragsize =3D pa_usec_to_bytes(ppdo->latency, &ss); + ba.maxlength =3D -1; + ba.minreq =3D -1; + ba.prebuf =3D -1; + obt_as.fmt =3D pa_to_audfmt (ss.format, &obt_as.endianness); =20 pa->stream =3D qpa_simple_new ( @@ -624,7 +630,7 @@ static int qpa_init_in(HWVoiceIn *hw, struct audsetting= s *as, void *drv_opaque) ppdo->has_name ? ppdo->name : NULL, &ss, NULL, /* channel map */ - NULL, /* buffering attributes */ + &ba, /* buffering attributes */ &error ); if (!pa->stream) { --=20 2.21.0