[Qemu-devel] [PATCH V2 0/3] Fixes for PulseAudio driver

Martin Schrodt posted 3 patches 9 weeks ago
Test asan passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190314142634.34537-1-martin@schrodt.org
Maintainers: Eric Blake <eblake@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>
audio/paaudio.c | 45 +++++++++++++++++++++++++++++++--------------
qapi/audio.json |  6 +++++-
2 files changed, 36 insertions(+), 15 deletions(-)

[Qemu-devel] [PATCH V2 0/3] Fixes for PulseAudio driver

Posted by Martin Schrodt 9 weeks ago
Version 2 of the series, adds proper commit messages 
and fixes a typo.

Martin Schrodt (3):
  audio/paaudio: fix ignored buffer_length setting
  audio/paaudio: prolong and make latency configurable
  audio/paaudio: fix microphone input being unusable

 audio/paaudio.c | 45 +++++++++++++++++++++++++++++++--------------
 qapi/audio.json |  6 +++++-
 2 files changed, 36 insertions(+), 15 deletions(-)

-- 
2.21.0


Re: [Qemu-devel] [PATCH V2 0/3] Fixes for PulseAudio driver

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/20190314142634.34537-1-martin@schrodt.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190314142634.34537-1-martin@schrodt.org
Subject: [Qemu-devel] [PATCH V2 0/3] Fixes for PulseAudio driver

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   dbbc277510..9164add701  master     -> master
 t [tag update]            patchew/20190313115121.7611-1-quintela@redhat.com -> patchew/20190313115121.7611-1-quintela@redhat.com
 t [tag update]            patchew/20190313174433.12966-1-armbru@redhat.com -> patchew/20190313174433.12966-1-armbru@redhat.com
 t [tag update]            patchew/20190314045526.13342-1-richard.henderson@linaro.org -> patchew/20190314045526.13342-1-richard.henderson@linaro.org
 t [tag update]            patchew/20190314085221.13483-1-vsementsov@virtuozzo.com -> patchew/20190314085221.13483-1-vsementsov@virtuozzo.com
 t [tag update]            patchew/20190314104622.101715-1-sgarzare@redhat.com -> patchew/20190314104622.101715-1-sgarzare@redhat.com
 * [new tag]               patchew/20190314142634.34537-1-martin@schrodt.org -> patchew/20190314142634.34537-1-martin@schrodt.org
 * [new tag]               patchew/20190314151527.25533-1-berrange@redhat.com -> patchew/20190314151527.25533-1-berrange@redhat.com
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
error: The last gc run reported the following. Please correct the root cause
and remove gc.log.
Automatic cleanup will not be performed until the file is removed.

warning: There are too many unreachable loose objects; run 'git prune' to remove them.

Switched to a new branch 'test'
d2a4e2039c audio/paaudio: fix microphone input being unusable
621bc13e2b audio/paaudio: prolong and make latency configurable
7fbc5dfe98 audio/paaudio: fix ignored buffer_length setting

=== OUTPUT BEGIN ===
1/3 Checking commit 7fbc5dfe98ae (audio/paaudio: fix ignored buffer_length setting)
WARNING: line over 80 characters
#21: FILE: audio/paaudio.c:580:
+        qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, ppdo->buffer_length);

WARNING: line over 80 characters
#30: FILE: audio/paaudio.c:640:
+        qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, ppdo->buffer_length);

ERROR: line over 90 characters
#39: FILE: audio/paaudio.c:812:
+static int qpa_validate_per_direction_opts (Audiodev *dev, AudiodevPaPerDirectionOptions *pdo)

ERROR: space prohibited between function name and open parenthesis '('
#39: FILE: audio/paaudio.c:812:
+static int qpa_validate_per_direction_opts (Audiodev *dev, AudiodevPaPerDirectionOptions *pdo)

total: 2 errors, 2 warnings, 45 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit 621bc13e2b8c (audio/paaudio: prolong and make latency configurable)
ERROR: space prohibited between function name and open parenthesis '('
#43: FILE: audio/paaudio.c:548:
+    ba.tlength = pa_usec_to_bytes (ppdo->latency, &ss);

total: 1 errors, 0 warnings, 59 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit d2a4e2039c7f (audio/paaudio: fix microphone input being unusable)
ERROR: space prohibited between function name and open parenthesis '('
#28: FILE: audio/paaudio.c:614:
+    ba.fragsize = pa_usec_to_bytes (ppdo->latency, &ss);

total: 1 errors, 0 warnings, 26 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190314142634.34537-1-martin@schrodt.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com