Load the element and replicate it using gvec_dup.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 target/s390x/insn-data.def      |  2 ++
 target/s390x/translate_vx.inc.c | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def
index 7314ae4704..14e010765d 100644
--- a/target/s390x/insn-data.def
+++ b/target/s390x/insn-data.def
@@ -1023,6 +1023,8 @@
     F(0xe78c, VPERM,   VRR_e, V,   0, 0, 0, 0, vperm, 0, IF_VEC)
 /* VECTOR PERMUTE DOUBLEWORD IMMEDIATE */
     F(0xe784, VPDI,    VRR_c, V,   0, 0, 0, 0, vpdi, 0, IF_VEC)
+/* VECTOR REPLICATE */
+    F(0xe74d, VREP,    VRI_c, V,   0, 0, 0, 0, vrep, 0, IF_VEC)
 
 #ifndef CONFIG_USER_ONLY
 /* COMPARE AND SWAP AND PURGE */
diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_vx.inc.c
index 8afde8fe2c..63bb37d0a1 100644
--- a/target/s390x/translate_vx.inc.c
+++ b/target/s390x/translate_vx.inc.c
@@ -685,3 +685,21 @@ static DisasJumpType op_vpdi(DisasContext *s, DisasOps *o)
     tcg_temp_free_i64(t1);
     return DISAS_NEXT;
 }
+
+static DisasJumpType op_vrep(DisasContext *s, DisasOps *o)
+{
+    const uint8_t enr = get_field(s->fields, i2);
+    const uint8_t es = get_field(s->fields, m4);
+    TCGv_i64 tmp;
+
+    if (es > ES_64 || !valid_vec_element(enr, es)) {
+        gen_program_exception(s, PGM_SPECIFICATION);
+        return DISAS_NORETURN;
+    }
+
+    tmp = tcg_temp_new_i64();
+    read_vec_element_i64(tmp, get_field(s->fields, v3), enr, es);
+    gen_gvec_dup_i64(es, get_field(s->fields, v1), tmp);
+    tcg_temp_free_i64(tmp);
+    return DISAS_NEXT;
+}
-- 
2.17.2

On 3/1/19 3:54 AM, David Hildenbrand wrote:
> +    read_vec_element_i64(tmp, get_field(s->fields, v3), enr, es);
> +    gen_gvec_dup_i64(es, get_field(s->fields, v1), tmp);

Ah!  I just remembered.  There is a special gvec primitive for this.

  tcg_gen_gvec_dup_mem(es, vec_full_reg_offset(v1),
                       vec_reg_offset(v3, enr, es), 16, 16);


r~

On 01.03.19 18:35, Richard Henderson wrote:
> On 3/1/19 3:54 AM, David Hildenbrand wrote:
>> +    read_vec_element_i64(tmp, get_field(s->fields, v3), enr, es);
>> +    gen_gvec_dup_i64(es, get_field(s->fields, v1), tmp);
> 
> Ah!  I just remembered.  There is a special gvec primitive for this.
> 
>   tcg_gen_gvec_dup_mem(es, vec_full_reg_offset(v1),
>                        vec_reg_offset(v3, enr, es), 16, 16);
> 

Sweet - Thanks!


-- 

Thanks,

David / dhildenb