[v3] s390x/tcg: Vector Instruction Support Part 1

[Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by David Hildenbrand 5 years, 2 months ago

This is the first part of vector instruction support for s390x. Parts
will be sent and reviewed piece by piece.

Part 1: Vector Support Instructions
Part 2: Vector Integer Instructions
Part 3: Vector String Instructions
Part 4: Vector Floating-Point Instructions

The current state can be found at (kept updated):
    https://github.com/davidhildenbrand/qemu/tree/vx
It is based on
    https://github.com/cohuck/qemu/tree/s390-next

With the current state I can boot Linux kernel + user space compiled with
SIMD support. This allows to boot distributions compiled exclusively for
z13, requiring SIMD support. Also, I have a growing set of tests for
kvm-unit-tests and tests/tcg which I cross-test on a real s390x system.

In this part, the basic infrastructure and all Vector Support Instructions
introduced with the "Vector Facility" are added. The Vector Extension
Facilities are not considered for now.

We make use of the existing gvec expansion + ool (out-of-line) support.
This will be heavily used especially for part 2 (Integer Instructions)
where we can actually reuse quite some existing gvec expansions.

v2 -> v3:
- "s390x/tcg: Utilities for vector instruction helpers"
-- inline helpers in header file
- "s390x/tcg: Implement VECTOR LOAD MULTIPLE"
-- optimize loading of last element
- "s390x/tcg: Implement VECTOR PACK *"
-- make the static funtion arrays const
- "s390x/tcg: Implement VECTOR REPLICATE"
-- use "tcg_gen_gvec_dup_mem"
- "s390x/tcg: Provide probe_write helper"
-- Add check for CONFIG_USER_ONLY
-- Optimize calculation of length
- Added r-b's

v1 -> v2:
- Basically address all wonderful review comments from Richard (too many
  to name them all)
- Probe write access to get rid of FIXMEs
- Heavily rework "s390x/tcg: Implement VECTOR PACK *"
-- Process cc and !cc separately.
-- Helper for VPK
- Don't use a temporary vector register (for now)
- Drop load_vec_element() and store_vec_element()
- Use ES_* instead of MO_*, will come in handy when we use ES_128 later
- .... many many other minor things

David Hildenbrand (32):
  s390x/tcg: Define vector instruction formats
  s390x/tcg: Check vector register instructions at central point
  s390x/tcg: Utilities for vector instruction helpers
  s390x/tcg: Implement VECTOR GATHER ELEMENT
  s390x/tcg: Implement VECTOR GENERATE BYTE MASK
  s390x/tcg: Implement VECTOR GENERATE MASK
  s390x/tcg: Implement VECTOR LOAD
  s390x/tcg: Implement VECTOR LOAD AND REPLICATE
  s390x/tcg: Implement VECTOR LOAD ELEMENT
  s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
  s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
  s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
  s390x/tcg: Implement VECTOR LOAD MULTIPLE
  s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
  s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
  s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
  s390x/tcg: Implement VECTOR LOAD WITH LENGTH
  s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
  s390x/tcg: Implement VECTOR PACK *
  s390x/tcg: Implement VECTOR PERMUTE
  s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
  s390x/tcg: Implement VECTOR REPLICATE
  s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
  s390x/tcg: Implement VECTOR SCATTER ELEMENT
  s390x/tcg: Implement VECTOR SELECT
  s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
  s390x/tcg: Provide probe_write_access helper
  s390x/tcg: Implement VECTOR STORE
  s390x/tcg: Implement VECTOR STORE ELEMENT
  s390x/tcg: Implement VECTOR STORE MULTIPLE
  s390x/tcg: Implement VECTOR STORE WITH LENGTH
  s390x/tcg: Implement VECTOR UNPACK *

 target/s390x/Makefile.objs      |   1 +
 target/s390x/cpu.h              |   7 +
 target/s390x/helper.h           |  21 +
 target/s390x/insn-data.def      |  82 +++
 target/s390x/insn-format.def    |  25 +
 target/s390x/internal.h         |   2 +
 target/s390x/mem_helper.c       |  25 +
 target/s390x/translate.c        |  61 ++-
 target/s390x/translate_vx.inc.c | 935 ++++++++++++++++++++++++++++++++
 target/s390x/vec.h              | 101 ++++
 target/s390x/vec_helper.c       | 193 +++++++
 11 files changed, 1452 insertions(+), 1 deletion(-)
 create mode 100644 target/s390x/translate_vx.inc.c
 create mode 100644 target/s390x/vec.h
 create mode 100644 target/s390x/vec_helper.c

-- 
2.17.2

Re: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 5 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20190307121539.12842-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307121539.12842-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307121539.12842-1-david@redhat.com -> patchew/20190307121539.12842-1-david@redhat.com
Switched to a new branch 'test'
580513b499 s390x/tcg: Implement VECTOR UNPACK *
60d054d17e s390x/tcg: Implement VECTOR STORE WITH LENGTH
8768efe234 s390x/tcg: Implement VECTOR STORE MULTIPLE
2c1a3aa9ba s390x/tcg: Implement VECTOR STORE ELEMENT
2a1c3a459d s390x/tcg: Implement VECTOR STORE
6125818044 s390x/tcg: Provide probe_write_access helper
12242884af s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
04466fb6cc s390x/tcg: Implement VECTOR SELECT
5b9fee2855 s390x/tcg: Implement VECTOR SCATTER ELEMENT
d67d89a961 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
367aa4a804 s390x/tcg: Implement VECTOR REPLICATE
79ad209659 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
8bf1ae3faa s390x/tcg: Implement VECTOR PERMUTE
211a230122 s390x/tcg: Implement VECTOR PACK *
20cee317af s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
224771a1cd s390x/tcg: Implement VECTOR LOAD WITH LENGTH
4749ebb288 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
0fff847013 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
37a909d151 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
79c915533c s390x/tcg: Implement VECTOR LOAD MULTIPLE
24c1d17dab s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
85b51d12c6 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
9f02cf09a3 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
75536edab1 s390x/tcg: Implement VECTOR LOAD ELEMENT
48429cf743 s390x/tcg: Implement VECTOR LOAD AND REPLICATE
2369662b74 s390x/tcg: Implement VECTOR LOAD
790356aa6e s390x/tcg: Implement VECTOR GENERATE MASK
d267631a44 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
99152d0942 s390x/tcg: Implement VECTOR GATHER ELEMENT
cf78908216 s390x/tcg: Utilities for vector instruction helpers
ca8433ca52 s390x/tcg: Check vector register instructions at central point
1f23f9b130 s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 1f23f9b1306f (s390x/tcg: Define vector instruction formats)
2/32 Checking commit ca8433ca52cc (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit cf78908216c1 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 99152d0942c9 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit d267631a44ab (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 790356aa6e3e (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit 2369662b7437 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 48429cf743f7 (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 75536edab11e (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 9f02cf09a392 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit 85b51d12c6c9 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 24c1d17dabf5 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 79c915533c2e (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 37a909d15183 (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 14/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/32 Checking commit 0fff8470136e (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit 4749ebb28844 (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit 224771a1cd71 (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 20cee317afb1 (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 211a23012232 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#183: FILE: target/s390x/vec_helper.c:48:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 8bf1ae3faa3b (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:144:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 79ad20965945 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 367aa4a8045b (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit d67d89a961c8 (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 5b9fee28556d (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 04466fb6cc86 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 12242884af29 (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit 612581804455 (s390x/tcg: Provide probe_write_access helper)
28/32 Checking commit 2a1c3a459da3 (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 2c1a3aa9ba36 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit 8768efe23460 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 60d054d17ebe (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 580513b499b7 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307121539.12842-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 5 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20190307121539.12842-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307121539.12842-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190307121539.12842-1-david@redhat.com -> patchew/20190307121539.12842-1-david@redhat.com
Switched to a new branch 'test'
dd15f0c0e0 s390x/tcg: Implement VECTOR UNPACK *
5469da27ba s390x/tcg: Implement VECTOR STORE WITH LENGTH
31f8d4ec4c s390x/tcg: Implement VECTOR STORE MULTIPLE
6de9465914 s390x/tcg: Implement VECTOR STORE ELEMENT
19cc52c3d2 s390x/tcg: Implement VECTOR STORE
2c4714a42d s390x/tcg: Provide probe_write_access helper
90fb919c9e s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
2992d1f3f1 s390x/tcg: Implement VECTOR SELECT
f82d8a987a s390x/tcg: Implement VECTOR SCATTER ELEMENT
db0d7a56b0 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
4c15d35ddd s390x/tcg: Implement VECTOR REPLICATE
9712ce8638 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
8d66a75a6b s390x/tcg: Implement VECTOR PERMUTE
8a0c283202 s390x/tcg: Implement VECTOR PACK *
a3d128e6fe s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
8a01124342 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
29b6dfd4be s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
67a0b63e9c s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
0bf3c03799 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
7926496f72 s390x/tcg: Implement VECTOR LOAD MULTIPLE
af823e986e s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
f054650162 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
e68dbb9e5f s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
808ab4e4df s390x/tcg: Implement VECTOR LOAD ELEMENT
8e9b8ed6f0 s390x/tcg: Implement VECTOR LOAD AND REPLICATE
ab0ad884ad s390x/tcg: Implement VECTOR LOAD
45def93691 s390x/tcg: Implement VECTOR GENERATE MASK
d0a1e4a8b5 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
2e8c1ed0c3 s390x/tcg: Implement VECTOR GATHER ELEMENT
be06a3dc42 s390x/tcg: Utilities for vector instruction helpers
40f44c517d s390x/tcg: Check vector register instructions at central point
065fe07ea4 s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 065fe07ea481 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 40f44c517dc2 (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit be06a3dc4268 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 2e8c1ed0c337 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit d0a1e4a8b579 (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 45def93691ce (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit ab0ad884ad95 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 8e9b8ed6f03c (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 808ab4e4dfda (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit e68dbb9e5fc7 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit f05465016299 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit af823e986e19 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 7926496f721a (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 0bf3c0379974 (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 14/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/32 Checking commit 67a0b63e9c60 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit 29b6dfd4be93 (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit 8a0112434299 (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit a3d128e6fea5 (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 8a0c28320214 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#183: FILE: target/s390x/vec_helper.c:48:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 8d66a75a6b4b (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:144:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 9712ce8638ec (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 4c15d35dddce (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit db0d7a56b0ac (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit f82d8a987aa8 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 2992d1f3f1db (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 90fb919c9e5a (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit 2c4714a42d04 (s390x/tcg: Provide probe_write_access helper)
28/32 Checking commit 19cc52c3d24d (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 6de946591469 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit 31f8d4ec4cee (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 5469da27ba7f (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit dd15f0c0e0f1 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307121539.12842-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by Cornelia Huck 5 years, 2 months ago

On Thu,  7 Mar 2019 13:15:07 +0100
David Hildenbrand <david@redhat.com> wrote:

> This is the first part of vector instruction support for s390x. Parts
> will be sent and reviewed piece by piece.
> 
> Part 1: Vector Support Instructions
> Part 2: Vector Integer Instructions
> Part 3: Vector String Instructions
> Part 4: Vector Floating-Point Instructions
> 
> The current state can be found at (kept updated):
>     https://github.com/davidhildenbrand/qemu/tree/vx
> It is based on
>     https://github.com/cohuck/qemu/tree/s390-next
> 
> With the current state I can boot Linux kernel + user space compiled with
> SIMD support. This allows to boot distributions compiled exclusively for
> z13, requiring SIMD support. Also, I have a growing set of tests for
> kvm-unit-tests and tests/tcg which I cross-test on a real s390x system.
> 
> In this part, the basic infrastructure and all Vector Support Instructions
> introduced with the "Vector Facility" are added. The Vector Extension
> Facilities are not considered for now.
> 
> We make use of the existing gvec expansion + ool (out-of-line) support.
> This will be heavily used especially for part 2 (Integer Instructions)
> where we can actually reuse quite some existing gvec expansions.
> 
> v2 -> v3:
> - "s390x/tcg: Utilities for vector instruction helpers"
> -- inline helpers in header file
> - "s390x/tcg: Implement VECTOR LOAD MULTIPLE"
> -- optimize loading of last element
> - "s390x/tcg: Implement VECTOR PACK *"
> -- make the static funtion arrays const
> - "s390x/tcg: Implement VECTOR REPLICATE"
> -- use "tcg_gen_gvec_dup_mem"
> - "s390x/tcg: Provide probe_write helper"
> -- Add check for CONFIG_USER_ONLY
> -- Optimize calculation of length
> - Added r-b's
> 
> v1 -> v2:
> - Basically address all wonderful review comments from Richard (too many
>   to name them all)
> - Probe write access to get rid of FIXMEs
> - Heavily rework "s390x/tcg: Implement VECTOR PACK *"
> -- Process cc and !cc separately.
> -- Helper for VPK
> - Don't use a temporary vector register (for now)
> - Drop load_vec_element() and store_vec_element()
> - Use ES_* instead of MO_*, will come in handy when we use ES_128 later
> - .... many many other minor things
> 
> David Hildenbrand (32):
>   s390x/tcg: Define vector instruction formats
>   s390x/tcg: Check vector register instructions at central point
>   s390x/tcg: Utilities for vector instruction helpers
>   s390x/tcg: Implement VECTOR GATHER ELEMENT
>   s390x/tcg: Implement VECTOR GENERATE BYTE MASK
>   s390x/tcg: Implement VECTOR GENERATE MASK
>   s390x/tcg: Implement VECTOR LOAD
>   s390x/tcg: Implement VECTOR LOAD AND REPLICATE
>   s390x/tcg: Implement VECTOR LOAD ELEMENT
>   s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
>   s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
>   s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
>   s390x/tcg: Implement VECTOR LOAD MULTIPLE
>   s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
>   s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
>   s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
>   s390x/tcg: Implement VECTOR LOAD WITH LENGTH
>   s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
>   s390x/tcg: Implement VECTOR PACK *
>   s390x/tcg: Implement VECTOR PERMUTE
>   s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
>   s390x/tcg: Implement VECTOR REPLICATE
>   s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
>   s390x/tcg: Implement VECTOR SCATTER ELEMENT
>   s390x/tcg: Implement VECTOR SELECT
>   s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
>   s390x/tcg: Provide probe_write_access helper
>   s390x/tcg: Implement VECTOR STORE
>   s390x/tcg: Implement VECTOR STORE ELEMENT
>   s390x/tcg: Implement VECTOR STORE MULTIPLE
>   s390x/tcg: Implement VECTOR STORE WITH LENGTH
>   s390x/tcg: Implement VECTOR UNPACK *
> 
>  target/s390x/Makefile.objs      |   1 +
>  target/s390x/cpu.h              |   7 +
>  target/s390x/helper.h           |  21 +
>  target/s390x/insn-data.def      |  82 +++
>  target/s390x/insn-format.def    |  25 +
>  target/s390x/internal.h         |   2 +
>  target/s390x/mem_helper.c       |  25 +
>  target/s390x/translate.c        |  61 ++-
>  target/s390x/translate_vx.inc.c | 935 ++++++++++++++++++++++++++++++++
>  target/s390x/vec.h              | 101 ++++
>  target/s390x/vec_helper.c       | 193 +++++++
>  11 files changed, 1452 insertions(+), 1 deletion(-)
>  create mode 100644 target/s390x/translate_vx.inc.c
>  create mode 100644 target/s390x/vec.h
>  create mode 100644 target/s390x/vec_helper.c
> 

Thanks, applied.

Re: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 5 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20190307121539.12842-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307121539.12842-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307121539.12842-1-david@redhat.com -> patchew/20190307121539.12842-1-david@redhat.com
Switched to a new branch 'test'
5848dfc88a s390x/tcg: Implement VECTOR UNPACK *
7e368477c5 s390x/tcg: Implement VECTOR STORE WITH LENGTH
609977f736 s390x/tcg: Implement VECTOR STORE MULTIPLE
db01dbf76f s390x/tcg: Implement VECTOR STORE ELEMENT
84c37b8f82 s390x/tcg: Implement VECTOR STORE
6ffbe981b0 s390x/tcg: Provide probe_write_access helper
5d1e9782e4 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
d477bf8a42 s390x/tcg: Implement VECTOR SELECT
4ada4aa4e8 s390x/tcg: Implement VECTOR SCATTER ELEMENT
54495356f0 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
53fd66335c s390x/tcg: Implement VECTOR REPLICATE
2f7d5675bf s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
1b0ea7576b s390x/tcg: Implement VECTOR PERMUTE
00d9df92c1 s390x/tcg: Implement VECTOR PACK *
3701ea61fb s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
29f6183c82 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
c7914c98ce s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
a02ffced91 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
0749abdbd4 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
9bec1d6b0b s390x/tcg: Implement VECTOR LOAD MULTIPLE
4b839be686 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
6198c749ec s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
23f6ed0387 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
2168f3ed0e s390x/tcg: Implement VECTOR LOAD ELEMENT
961ce46497 s390x/tcg: Implement VECTOR LOAD AND REPLICATE
24e44fb771 s390x/tcg: Implement VECTOR LOAD
128d7ccfec s390x/tcg: Implement VECTOR GENERATE MASK
4b7349dc7e s390x/tcg: Implement VECTOR GENERATE BYTE MASK
54557b2dda s390x/tcg: Implement VECTOR GATHER ELEMENT
82ba050cbd s390x/tcg: Utilities for vector instruction helpers
1066457e34 s390x/tcg: Check vector register instructions at central point
bb70511084 s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit bb7051108455 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 1066457e346b (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit 82ba050cbd09 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 54557b2dda03 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 4b7349dc7eee (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 128d7ccfec4e (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit 24e44fb7712f (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 961ce46497cf (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 2168f3ed0e0c (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 23f6ed038729 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit 6198c749ec94 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 4b839be6865f (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 9bec1d6b0b63 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 0749abdbd438 (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 14/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/32 Checking commit a02ffced918f (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit c7914c98ce0e (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit 29f6183c820a (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 3701ea61fbbc (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 00d9df92c1a8 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#183: FILE: target/s390x/vec_helper.c:48:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 1b0ea7576bec (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:144:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 2f7d5675bf89 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 53fd66335c53 (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 54495356f06c (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 4ada4aa4e80b (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit d477bf8a42d9 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 5d1e9782e43a (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit 6ffbe981b0c1 (s390x/tcg: Provide probe_write_access helper)
28/32 Checking commit 84c37b8f821a (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit db01dbf76f04 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit 609977f73603 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 7e368477c537 (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 5848dfc88ab1 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307121539.12842-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 5 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20190307121539.12842-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307121539.12842-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307121539.12842-1-david@redhat.com -> patchew/20190307121539.12842-1-david@redhat.com
Switched to a new branch 'test'
26fb2d7a48 s390x/tcg: Implement VECTOR UNPACK *
df2340ec06 s390x/tcg: Implement VECTOR STORE WITH LENGTH
809ea72f2a s390x/tcg: Implement VECTOR STORE MULTIPLE
bc20fcf1e4 s390x/tcg: Implement VECTOR STORE ELEMENT
79dc189d2c s390x/tcg: Implement VECTOR STORE
82ae500ad9 s390x/tcg: Provide probe_write_access helper
70ad09ba01 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
387ce0c789 s390x/tcg: Implement VECTOR SELECT
428c54de2d s390x/tcg: Implement VECTOR SCATTER ELEMENT
14165826a8 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
62b8dd3043 s390x/tcg: Implement VECTOR REPLICATE
a0bbd82903 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
fc9d89b81a s390x/tcg: Implement VECTOR PERMUTE
e118ce0140 s390x/tcg: Implement VECTOR PACK *
9eae02d1e8 s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
f43ab11966 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
90b085e683 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
c0d9c4a22b s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
cf328654bc s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
e87662b255 s390x/tcg: Implement VECTOR LOAD MULTIPLE
a871ece7dd s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
dd9cc4ad61 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
b7af5ff813 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
dd197feff8 s390x/tcg: Implement VECTOR LOAD ELEMENT
e6244fc7f9 s390x/tcg: Implement VECTOR LOAD AND REPLICATE
484d13e05f s390x/tcg: Implement VECTOR LOAD
712ac0b13a s390x/tcg: Implement VECTOR GENERATE MASK
6c8dbd8eae s390x/tcg: Implement VECTOR GENERATE BYTE MASK
013df3f91c s390x/tcg: Implement VECTOR GATHER ELEMENT
d3cdda2073 s390x/tcg: Utilities for vector instruction helpers
57c9e3d42b s390x/tcg: Check vector register instructions at central point
379a1fb237 s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 379a1fb237fa (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 57c9e3d42b26 (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit d3cdda20732a (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 013df3f91c15 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 6c8dbd8eaeeb (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 712ac0b13a69 (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit 484d13e05f3d (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit e6244fc7f980 (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit dd197feff85a (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit b7af5ff813f6 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit dd9cc4ad61e4 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit a871ece7ddd2 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit e87662b2559f (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit cf328654bc45 (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 14/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/32 Checking commit c0d9c4a22ba1 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit 90b085e683ed (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit f43ab119664b (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 9eae02d1e8d0 (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit e118ce014086 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#183: FILE: target/s390x/vec_helper.c:48:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit fc9d89b81a36 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:144:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit a0bbd8290392 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 62b8dd304335 (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 14165826a8bc (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 428c54de2dc0 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 387ce0c789f8 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 70ad09ba01c3 (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit 82ae500ad9b1 (s390x/tcg: Provide probe_write_access helper)
28/32 Checking commit 79dc189d2c1d (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit bc20fcf1e442 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit 809ea72f2ab2 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit df2340ec061e (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 26fb2d7a4829 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307121539.12842-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 5 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20190307121539.12842-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307121539.12842-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307121539.12842-1-david@redhat.com -> patchew/20190307121539.12842-1-david@redhat.com
Switched to a new branch 'test'
f6954a7939 s390x/tcg: Implement VECTOR UNPACK *
79bdca318a s390x/tcg: Implement VECTOR STORE WITH LENGTH
b9021c771e s390x/tcg: Implement VECTOR STORE MULTIPLE
83e2794e3d s390x/tcg: Implement VECTOR STORE ELEMENT
829e3fb3e7 s390x/tcg: Implement VECTOR STORE
bd7415ba28 s390x/tcg: Provide probe_write_access helper
1e6e15312b s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
9364f826a7 s390x/tcg: Implement VECTOR SELECT
11059139e9 s390x/tcg: Implement VECTOR SCATTER ELEMENT
9f252fbd49 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
1c6291228f s390x/tcg: Implement VECTOR REPLICATE
9da07a7588 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
7d3e23524d s390x/tcg: Implement VECTOR PERMUTE
e164481b3a s390x/tcg: Implement VECTOR PACK *
5bcdba5d59 s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
8131f03bcb s390x/tcg: Implement VECTOR LOAD WITH LENGTH
6b3e1a5833 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
9b9456df6c s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
3e3137fc5a s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
e13b78fa3a s390x/tcg: Implement VECTOR LOAD MULTIPLE
5dd092c443 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
73a7d5936f s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
4c3cac7dea s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
2ee78ce167 s390x/tcg: Implement VECTOR LOAD ELEMENT
654c614c56 s390x/tcg: Implement VECTOR LOAD AND REPLICATE
d606d0b7f2 s390x/tcg: Implement VECTOR LOAD
15ae8fa740 s390x/tcg: Implement VECTOR GENERATE MASK
80cb753278 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
3822dd2633 s390x/tcg: Implement VECTOR GATHER ELEMENT
3c360b8b2a s390x/tcg: Utilities for vector instruction helpers
21c62197c5 s390x/tcg: Check vector register instructions at central point
1eea0f8b7a s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 1eea0f8b7a4c (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 21c62197c5d5 (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit 3c360b8b2ae6 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 3822dd263336 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 80cb7532789c (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 15ae8fa740db (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit d606d0b7f275 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 654c614c569e (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 2ee78ce167c7 (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 4c3cac7dea14 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit 73a7d5936fcb (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 5dd092c44399 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit e13b78fa3a2f (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 3e3137fc5ada (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 14/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/32 Checking commit 9b9456df6c4f (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit 6b3e1a5833f8 (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit 8131f03bcb21 (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 5bcdba5d593d (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit e164481b3a2a (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#183: FILE: target/s390x/vec_helper.c:48:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 7d3e23524d30 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:144:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 9da07a75887b (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 1c6291228f55 (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 9f252fbd49d5 (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 11059139e9c2 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 9364f826a70a (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 1e6e15312b1f (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit bd7415ba2871 (s390x/tcg: Provide probe_write_access helper)
28/32 Checking commit 829e3fb3e7bf (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 83e2794e3d7f (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit b9021c771e51 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 79bdca318a28 (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit f6954a793960 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307121539.12842-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 5 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20190307121539.12842-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307121539.12842-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307121539.12842-1-david@redhat.com -> patchew/20190307121539.12842-1-david@redhat.com
Switched to a new branch 'test'
5a2b60cdfb s390x/tcg: Implement VECTOR UNPACK *
e44f61a293 s390x/tcg: Implement VECTOR STORE WITH LENGTH
aaff19a223 s390x/tcg: Implement VECTOR STORE MULTIPLE
5bc9a4d3fc s390x/tcg: Implement VECTOR STORE ELEMENT
4a1d19133b s390x/tcg: Implement VECTOR STORE
a2b52e36cf s390x/tcg: Provide probe_write_access helper
2e2b0b7fa9 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
597f117f0a s390x/tcg: Implement VECTOR SELECT
d9447b1e56 s390x/tcg: Implement VECTOR SCATTER ELEMENT
7b7cba6fe9 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
205ece0c65 s390x/tcg: Implement VECTOR REPLICATE
a315de6305 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
73b80eeca1 s390x/tcg: Implement VECTOR PERMUTE
1f2e90d518 s390x/tcg: Implement VECTOR PACK *
2d35935e85 s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
49cc55b02b s390x/tcg: Implement VECTOR LOAD WITH LENGTH
c9e430c6e1 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
2ff9e61202 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
e6852c11e3 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
c56f6d6229 s390x/tcg: Implement VECTOR LOAD MULTIPLE
3f392b0093 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
9a2014681a s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
1fd9f4467f s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
770dcdb9a3 s390x/tcg: Implement VECTOR LOAD ELEMENT
b15a110f20 s390x/tcg: Implement VECTOR LOAD AND REPLICATE
c63a56fc9a s390x/tcg: Implement VECTOR LOAD
a0c84dfb55 s390x/tcg: Implement VECTOR GENERATE MASK
e49400c153 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
fc5057a465 s390x/tcg: Implement VECTOR GATHER ELEMENT
7f20b31570 s390x/tcg: Utilities for vector instruction helpers
62756eecc5 s390x/tcg: Check vector register instructions at central point
ebe24ba51f s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit ebe24ba51fcc (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 62756eecc56f (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit 7f20b31570ba (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit fc5057a465cc (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit e49400c15376 (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit a0c84dfb55f2 (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit c63a56fc9a23 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit b15a110f2029 (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 770dcdb9a393 (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 1fd9f4467f0d (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit 9a2014681a81 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 3f392b009361 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit c56f6d6229fa (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit e6852c11e3f9 (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 14/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/32 Checking commit 2ff9e6120212 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit c9e430c6e10b (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit 49cc55b02b81 (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 2d35935e851b (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 1f2e90d5182d (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#183: FILE: target/s390x/vec_helper.c:48:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 73b80eeca182 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:144:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit a315de6305c7 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 205ece0c65dd (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 7b7cba6fe94c (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit d9447b1e5632 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 597f117f0a85 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 2e2b0b7fa918 (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit a2b52e36cf82 (s390x/tcg: Provide probe_write_access helper)
28/32 Checking commit 4a1d19133ba4 (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 5bc9a4d3fc79 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit aaff19a2236d (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit e44f61a2935d (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 5a2b60cdfba8 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307121539.12842-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 5 years, 2 months ago

Patchew URL: https://patchew.org/QEMU/20190307121539.12842-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190307121539.12842-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/32] s390x/tcg: Vector Instruction Support Part 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190307121539.12842-1-david@redhat.com -> patchew/20190307121539.12842-1-david@redhat.com
Switched to a new branch 'test'
8d0aa17606 s390x/tcg: Implement VECTOR UNPACK *
37636b591f s390x/tcg: Implement VECTOR STORE WITH LENGTH
6e1dfde0bd s390x/tcg: Implement VECTOR STORE MULTIPLE
859d21b77d s390x/tcg: Implement VECTOR STORE ELEMENT
4de96c3f56 s390x/tcg: Implement VECTOR STORE
87bf3f8544 s390x/tcg: Provide probe_write_access helper
4bc6b49371 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
c32754d25c s390x/tcg: Implement VECTOR SELECT
2056f3d754 s390x/tcg: Implement VECTOR SCATTER ELEMENT
cb5e0ccad6 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
76ce69b4fb s390x/tcg: Implement VECTOR REPLICATE
76cfadc9a1 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
507dbe068d s390x/tcg: Implement VECTOR PERMUTE
17c46f0fa0 s390x/tcg: Implement VECTOR PACK *
b36fc71793 s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
f4bdf81489 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
42fd374329 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
47cfb40ff7 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
85b178934a s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
963cbd7c53 s390x/tcg: Implement VECTOR LOAD MULTIPLE
ca71a83f40 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
edb2f7e2a0 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
1372baf785 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
f6e6ee9d3e s390x/tcg: Implement VECTOR LOAD ELEMENT
5b2c3f2ebd s390x/tcg: Implement VECTOR LOAD AND REPLICATE
c4cdedec4f s390x/tcg: Implement VECTOR LOAD
96a031b008 s390x/tcg: Implement VECTOR GENERATE MASK
38d6de5718 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
d2ef6fbd45 s390x/tcg: Implement VECTOR GATHER ELEMENT
0e60ea6953 s390x/tcg: Utilities for vector instruction helpers
16bf5f9541 s390x/tcg: Check vector register instructions at central point
7d0bdaedb7 s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 7d0bdaedb7e4 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 16bf5f9541e6 (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit 0e60ea695385 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 101 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit d2ef6fbd45dd (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 38d6de5718bc (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 96a031b0085f (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit c4cdedec4f7e (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 5b2c3f2ebd02 (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit f6e6ee9d3e55 (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 1372baf7858e (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit edb2f7e2a09f (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit ca71a83f4056 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 963cbd7c5326 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 85b178934a8d (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 96 lines checked

Patch 14/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/32 Checking commit 47cfb40ff7a8 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit 42fd37432941 (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit f4bdf81489dd (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit b36fc717934b (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 17c46f0fa09c (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#183: FILE: target/s390x/vec_helper.c:48:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 507dbe068dfb (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:144:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 76cfadc9a15a (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 76ce69b4fb36 (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit cb5e0ccad69d (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 2056f3d7543c (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit c32754d25ccc (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 4bc6b49371dd (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit 87bf3f85446e (s390x/tcg: Provide probe_write_access helper)
28/32 Checking commit 4de96c3f5688 (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 859d21b77de2 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit 6e1dfde0bd6a (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 37636b591f70 (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 8d0aa1760631 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190307121539.12842-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com