[v2] s390x/tcg: Vector Instruction Support Part 1

[Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by David Hildenbrand 6 years, 7 months ago

This is the first part of vector instruction support for s390x. Parts
will be sent and reviewed piece by piece.

Part 1: Vector Support Instructions
Part 2: Vector Integer Instructions
Part 3: Vector String Instructions
Part 4: Vector Floating-Point Instructions

The current state can be found at (kept updated):
    https://github.com/davidhildenbrand/qemu/tree/vx
It is based on
    https://github.com/cohuck/qemu/tree/s390-next

To make use of vector instructions on my branch, make sure to specify
"-cpu max" for now.

With the current state I can boot Linux kernel + user space compiled with
SIMD support. This allows to boot distributions compiled exclusively for
z13, requiring SIMD support. Also, I have a growing set of tests for
kvm-unit-tests and tests/tcg which I cross-test on a real s390x system.

In this part, the basic infrastructure and all Vector Support Instructions
introduced with the "Vector Facility" are added. The Vector Extension
Facilities are not considered for now.

We make use of the existing gvec expansion + ool (out-of-line) support.
This will be heavily used especially for part 2 (Integer Instructions)
where we can actually reuse quite some existing gvec expansions.

v1 -> v2:
- Basically address all wonderful review comments from Richard (too many
  to name them all)
- Probe write access to get rid of FIXMEs
- Heavily rework "s390x/tcg: Implement VECTOR PACK *"
-- Process cc and !cc separately.
-- Helper for VPK
- Don't use a temporary vector register (for now)
- Drop load_vec_element() and store_vec_element()
- Use ES_* instead of MO_*, will come in handy when we use ES_128 later
- .... many many other minor things

David Hildenbrand (32):
  s390x/tcg: Define vector instruction formats
  s390x/tcg: Check vector register instructions at central point
  s390x/tcg: Utilities for vector instruction helpers
  s390x/tcg: Implement VECTOR GATHER ELEMENT
  s390x/tcg: Implement VECTOR GENERATE BYTE MASK
  s390x/tcg: Implement VECTOR GENERATE MASK
  s390x/tcg: Implement VECTOR LOAD
  s390x/tcg: Implement VECTOR LOAD AND REPLICATE
  s390x/tcg: Implement VECTOR LOAD ELEMENT
  s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
  s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
  s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
  s390x/tcg: Implement VECTOR LOAD MULTIPLE
  s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
  s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
  s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
  s390x/tcg: Implement VECTOR LOAD WITH LENGTH
  s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
  s390x/tcg: Implement VECTOR PACK *
  s390x/tcg: Implement VECTOR PERMUTE
  s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
  s390x/tcg: Implement VECTOR REPLICATE
  s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
  s390x/tcg: Implement VECTOR SCATTER ELEMENT
  s390x/tcg: Implement VECTOR SELECT
  s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
  s390x/tcg: Provide probe_write helper
  s390x/tcg: Implement VECTOR STORE
  s390x/tcg: Implement VECTOR STORE ELEMENT
  s390x/tcg: Implement VECTOR STORE MULTIPLE
  s390x/tcg: Implement VECTOR STORE WITH LENGTH
  s390x/tcg: Implement VECTOR UNPACK *

 target/s390x/Makefile.objs      |   1 +
 target/s390x/cpu.h              |   7 +
 target/s390x/helper.h           |  21 +
 target/s390x/insn-data.def      |  82 +++
 target/s390x/insn-format.def    |  25 +
 target/s390x/internal.h         |   2 +
 target/s390x/mem_helper.c       |  21 +
 target/s390x/translate.c        |  61 ++-
 target/s390x/translate_vx.inc.c | 931 ++++++++++++++++++++++++++++++++
 target/s390x/vec.h              |  31 ++
 target/s390x/vec_helper.c       | 268 +++++++++
 11 files changed, 1449 insertions(+), 1 deletion(-)
 create mode 100644 target/s390x/translate_vx.inc.c
 create mode 100644 target/s390x/vec.h
 create mode 100644 target/s390x/vec_helper.c

-- 
2.17.2

Re: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 6 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20190301115413.27153-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190301115413.27153-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/20190301115413.27153-1-david@redhat.com -> patchew/20190301115413.27153-1-david@redhat.com
Switched to a new branch 'test'
2cf1c9be3e s390x/tcg: Implement VECTOR UNPACK *
7897872a59 s390x/tcg: Implement VECTOR STORE WITH LENGTH
e66ed1c42e s390x/tcg: Implement VECTOR STORE MULTIPLE
7dfc2fbe57 s390x/tcg: Implement VECTOR STORE ELEMENT
d0cde859d0 s390x/tcg: Implement VECTOR STORE
6deb281d6b s390x/tcg: Provide probe_write helper
ba102170b4 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
8fd2f114d9 s390x/tcg: Implement VECTOR SELECT
553b1a5922 s390x/tcg: Implement VECTOR SCATTER ELEMENT
1ea76ab1c4 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
16604c3623 s390x/tcg: Implement VECTOR REPLICATE
61061d0414 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
0bb6fa6313 s390x/tcg: Implement VECTOR PERMUTE
72dd7592a1 s390x/tcg: Implement VECTOR PACK *
4659517461 s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
ffcd45a343 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
e3598b6c85 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
7580f4bf7a s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
ae27bf6d15 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
8aa2e3308b s390x/tcg: Implement VECTOR LOAD MULTIPLE
4b09f2eece s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
a9b5d89fa7 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
984bb05544 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
27b26e1777 s390x/tcg: Implement VECTOR LOAD ELEMENT
b42ac2ddcf s390x/tcg: Implement VECTOR LOAD AND REPLICATE
a3c14955b7 s390x/tcg: Implement VECTOR LOAD
1228406ab1 s390x/tcg: Implement VECTOR GENERATE MASK
3587dcd290 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
87f83ff1bd s390x/tcg: Implement VECTOR GATHER ELEMENT
b2cbc8e51f s390x/tcg: Utilities for vector instruction helpers
ced2810ddd s390x/tcg: Check vector register instructions at central point
07add5355c s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 07add5355c96 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit ced2810ddd6b (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit b2cbc8e51f01 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 128 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 87f83ff1bd8a (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 3587dcd2901b (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 1228406ab149 (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit a3c14955b7c2 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit b42ac2ddcf41 (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 27b26e177729 (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 984bb0554447 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit a9b5d89fa716 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 4b09f2eece29 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 8aa2e3308b72 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit ae27bf6d157e (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
15/32 Checking commit 7580f4bf7a18 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit e3598b6c85ca (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit ffcd45a34334 (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 4659517461c6 (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 72dd7592a169 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#182: FILE: target/s390x/vec_helper.c:123:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 0bb6fa6313ac (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:143:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 61061d041413 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 16604c36236e (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 1ea76ab1c492 (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 553b1a5922a8 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 8fd2f114d942 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit ba102170b4e7 (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit 6deb281d6b60 (s390x/tcg: Provide probe_write helper)
28/32 Checking commit d0cde859d00e (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 7dfc2fbe5782 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit e66ed1c42e49 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 7897872a59fd (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 2cf1c9be3e94 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190301115413.27153-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 6 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20190301115413.27153-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190301115413.27153-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190301115413.27153-1-david@redhat.com -> patchew/20190301115413.27153-1-david@redhat.com
Switched to a new branch 'test'
77d73c7ed1 s390x/tcg: Implement VECTOR UNPACK *
ea715fef81 s390x/tcg: Implement VECTOR STORE WITH LENGTH
b124f9241e s390x/tcg: Implement VECTOR STORE MULTIPLE
b9879a4396 s390x/tcg: Implement VECTOR STORE ELEMENT
fba93be27b s390x/tcg: Implement VECTOR STORE
b603c0f392 s390x/tcg: Provide probe_write helper
99bb9a3b94 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
7882f2005e s390x/tcg: Implement VECTOR SELECT
0e6a1cd319 s390x/tcg: Implement VECTOR SCATTER ELEMENT
6f09c5514d s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
62ee114489 s390x/tcg: Implement VECTOR REPLICATE
39a1f68aea s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
8484c31053 s390x/tcg: Implement VECTOR PERMUTE
1ba7797b77 s390x/tcg: Implement VECTOR PACK *
bbf762520a s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
bf4c15ff5e s390x/tcg: Implement VECTOR LOAD WITH LENGTH
387f12ebf2 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
b32be93319 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
acce2e18b0 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
28dba86a8d s390x/tcg: Implement VECTOR LOAD MULTIPLE
861f401bd7 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
cbacc44de5 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
937df5685c s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
4dd1f64c18 s390x/tcg: Implement VECTOR LOAD ELEMENT
175cb562db s390x/tcg: Implement VECTOR LOAD AND REPLICATE
cb411cd963 s390x/tcg: Implement VECTOR LOAD
6c969cc824 s390x/tcg: Implement VECTOR GENERATE MASK
987032c5c6 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
227c308c9c s390x/tcg: Implement VECTOR GATHER ELEMENT
e377b691e0 s390x/tcg: Utilities for vector instruction helpers
5dbf75fdbe s390x/tcg: Check vector register instructions at central point
aa3ea725ba s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit aa3ea725ba88 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 5dbf75fdbeff (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit e377b691e0fa (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 128 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 227c308c9c3c (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 987032c5c666 (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 6c969cc82417 (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit cb411cd963d9 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 175cb562db07 (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 4dd1f64c186e (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 937df5685c48 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit cbacc44de5a4 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 861f401bd70a (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 28dba86a8d4a (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit acce2e18b0df (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
15/32 Checking commit b32be9331903 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit 387f12ebf2ca (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit bf4c15ff5e3b (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit bbf762520a38 (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 1ba7797b7750 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#182: FILE: target/s390x/vec_helper.c:123:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 8484c3105305 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:143:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 39a1f68aea92 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 62ee1144895b (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 6f09c5514dc9 (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 0e6a1cd319f2 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 7882f2005ef8 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 99bb9a3b94a5 (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit b603c0f39216 (s390x/tcg: Provide probe_write helper)
28/32 Checking commit fba93be27bb9 (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit b9879a4396c7 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit b124f9241e00 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit ea715fef81db (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 77d73c7ed154 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190301115413.27153-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 6 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20190301115413.27153-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20190301115413.27153-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190301163518.20702-1-stefanha@redhat.com -> patchew/20190301163518.20702-1-stefanha@redhat.com
Switched to a new branch 'test'
84850ebbe5 s390x/tcg: Implement VECTOR UNPACK *
4a4475ac0e s390x/tcg: Implement VECTOR STORE WITH LENGTH
ec74de772b s390x/tcg: Implement VECTOR STORE MULTIPLE
5e3a3ea905 s390x/tcg: Implement VECTOR STORE ELEMENT
e3db4b961f s390x/tcg: Implement VECTOR STORE
099c3b979c s390x/tcg: Provide probe_write helper
9fa21c4255 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
70120ed4af s390x/tcg: Implement VECTOR SELECT
b0a62b201e s390x/tcg: Implement VECTOR SCATTER ELEMENT
3db62903ba s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
01235266a7 s390x/tcg: Implement VECTOR REPLICATE
ca3a745319 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
bf493cb73c s390x/tcg: Implement VECTOR PERMUTE
093ba1a6ff s390x/tcg: Implement VECTOR PACK *
5e6bf1f928 s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
d473c40eab s390x/tcg: Implement VECTOR LOAD WITH LENGTH
46210eab13 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
d07ab92ed5 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
231b505f97 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
728a1ef5b4 s390x/tcg: Implement VECTOR LOAD MULTIPLE
7cb070298d s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
96bd2799d1 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
bb4dfe8dff s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
305d58aff1 s390x/tcg: Implement VECTOR LOAD ELEMENT
e7e51bb4e4 s390x/tcg: Implement VECTOR LOAD AND REPLICATE
8b2082138f s390x/tcg: Implement VECTOR LOAD
b3fb39d42c s390x/tcg: Implement VECTOR GENERATE MASK
7ab6a198f6 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
8d65a412c5 s390x/tcg: Implement VECTOR GATHER ELEMENT
3f2a134615 s390x/tcg: Utilities for vector instruction helpers
6270c25595 s390x/tcg: Check vector register instructions at central point
5cd350e99f s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 5cd350e99f98 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 6270c2559553 (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit 3f2a134615d7 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 128 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 8d65a412c5dd (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 7ab6a198f644 (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit b3fb39d42caf (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit 8b2082138f01 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit e7e51bb4e48e (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 305d58aff1d0 (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit bb4dfe8dff05 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit 96bd2799d11a (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 7cb070298dba (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 728a1ef5b4da (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 231b505f974f (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
15/32 Checking commit d07ab92ed56c (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit 46210eab13ff (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit d473c40eab43 (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 5e6bf1f92827 (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 093ba1a6fffc (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#183: FILE: target/s390x/vec_helper.c:123:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit bf493cb73cbe (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:143:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit ca3a74531932 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 01235266a7b7 (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 3db62903ba7c (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit b0a62b201e53 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 70120ed4aff3 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 9fa21c42553e (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit 099c3b979c16 (s390x/tcg: Provide probe_write helper)
28/32 Checking commit e3db4b961f80 (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 5e3a3ea9052d (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit ec74de772b1d (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 4a4475ac0e5f (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 84850ebbe5a5 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190301115413.27153-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 6 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20190301115413.27153-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190301115413.27153-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190301115413.27153-1-david@redhat.com -> patchew/20190301115413.27153-1-david@redhat.com
Switched to a new branch 'test'
0ac11c9c15 s390x/tcg: Implement VECTOR UNPACK *
5a49ebf4e8 s390x/tcg: Implement VECTOR STORE WITH LENGTH
4d3377c434 s390x/tcg: Implement VECTOR STORE MULTIPLE
8b7bef7bb1 s390x/tcg: Implement VECTOR STORE ELEMENT
4c1389d499 s390x/tcg: Implement VECTOR STORE
f263bd5abf s390x/tcg: Provide probe_write helper
2656298ce4 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
11a18a7c7a s390x/tcg: Implement VECTOR SELECT
cfefe3b4e5 s390x/tcg: Implement VECTOR SCATTER ELEMENT
d37e771f93 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
fe16a34aff s390x/tcg: Implement VECTOR REPLICATE
448206eac2 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
b004b8aca7 s390x/tcg: Implement VECTOR PERMUTE
0eca96087e s390x/tcg: Implement VECTOR PACK *
89103d1726 s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
316ef22fe0 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
aaa23d4046 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
2ad9c8af70 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
0cb0e0c8dd s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
8956d4b299 s390x/tcg: Implement VECTOR LOAD MULTIPLE
6b0215cba5 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
0402a6b515 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
7e69c68810 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
a73099e2f3 s390x/tcg: Implement VECTOR LOAD ELEMENT
3b45e2cedc s390x/tcg: Implement VECTOR LOAD AND REPLICATE
ee0c0fd7e9 s390x/tcg: Implement VECTOR LOAD
81b9dfde6a s390x/tcg: Implement VECTOR GENERATE MASK
46922b0da7 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
03b3fe255d s390x/tcg: Implement VECTOR GATHER ELEMENT
ebd9dced4a s390x/tcg: Utilities for vector instruction helpers
85dff107e2 s390x/tcg: Check vector register instructions at central point
3c063a0270 s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 3c063a027075 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 85dff107e233 (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit ebd9dced4a4a (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 128 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 03b3fe255d38 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 46922b0da75e (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 81b9dfde6a3e (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit ee0c0fd7e940 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 3b45e2cedc0a (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit a73099e2f39b (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 7e69c6881091 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit 0402a6b515d0 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 6b0215cba533 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 8956d4b299a9 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 0cb0e0c8dd60 (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
15/32 Checking commit 2ad9c8af7091 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit aaa23d40467f (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit 316ef22fe0bf (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 89103d17261b (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 0eca96087ec5 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#182: FILE: target/s390x/vec_helper.c:123:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit b004b8aca79d (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:143:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 448206eac2f5 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit fe16a34aff9b (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit d37e771f93e0 (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit cfefe3b4e519 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 11a18a7c7a67 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 2656298ce402 (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit f263bd5abf8b (s390x/tcg: Provide probe_write helper)
28/32 Checking commit 4c1389d499cb (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 8b7bef7bb18e (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit 4d3377c434cd (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 5a49ebf4e884 (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 0ac11c9c1553 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190301115413.27153-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by David Hildenbrand 6 years, 7 months ago

On 01.03.19 17:38, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190301115413.27153-1-david@redhat.com/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Message-id: 20190301115413.27153-1-david@redhat.com
> Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1
> Type: series
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  t [tag update]            patchew/20190301115413.27153-1-david@redhat.com -> patchew/20190301115413.27153-1-david@redhat.com
> Switched to a new branch 'test'
> 0ac11c9c15 s390x/tcg: Implement VECTOR UNPACK *
> 5a49ebf4e8 s390x/tcg: Implement VECTOR STORE WITH LENGTH
> 4d3377c434 s390x/tcg: Implement VECTOR STORE MULTIPLE
> 8b7bef7bb1 s390x/tcg: Implement VECTOR STORE ELEMENT
> 4c1389d499 s390x/tcg: Implement VECTOR STORE
> f263bd5abf s390x/tcg: Provide probe_write helper
> 2656298ce4 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
> 11a18a7c7a s390x/tcg: Implement VECTOR SELECT
> cfefe3b4e5 s390x/tcg: Implement VECTOR SCATTER ELEMENT
> d37e771f93 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
> fe16a34aff s390x/tcg: Implement VECTOR REPLICATE
> 448206eac2 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
> b004b8aca7 s390x/tcg: Implement VECTOR PERMUTE
> 0eca96087e s390x/tcg: Implement VECTOR PACK *
> 89103d1726 s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
> 316ef22fe0 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
> aaa23d4046 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
> 2ad9c8af70 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
> 0cb0e0c8dd s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
> 8956d4b299 s390x/tcg: Implement VECTOR LOAD MULTIPLE
> 6b0215cba5 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
> 0402a6b515 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
> 7e69c68810 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
> a73099e2f3 s390x/tcg: Implement VECTOR LOAD ELEMENT
> 3b45e2cedc s390x/tcg: Implement VECTOR LOAD AND REPLICATE
> ee0c0fd7e9 s390x/tcg: Implement VECTOR LOAD
> 81b9dfde6a s390x/tcg: Implement VECTOR GENERATE MASK
> 46922b0da7 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
> 03b3fe255d s390x/tcg: Implement VECTOR GATHER ELEMENT
> ebd9dced4a s390x/tcg: Utilities for vector instruction helpers
> 85dff107e2 s390x/tcg: Check vector register instructions at central point
> 3c063a0270 s390x/tcg: Define vector instruction formats
> 
> === OUTPUT BEGIN ===
> 1/32 Checking commit 3c063a027075 (s390x/tcg: Define vector instruction formats)
> 2/32 Checking commit 85dff107e233 (s390x/tcg: Check vector register instructions at central point)
> 3/32 Checking commit ebd9dced4a4a (s390x/tcg: Utilities for vector instruction helpers)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #30: 
> new file mode 100644
> 
> total: 0 errors, 1 warnings, 128 lines checked
> 
> Patch 3/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 4/32 Checking commit 03b3fe255d38 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #56: 
> new file mode 100644
> 
> total: 0 errors, 1 warnings, 155 lines checked
> 
> Patch 4/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 5/32 Checking commit 46922b0da75e (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
> 6/32 Checking commit 81b9dfde6a3e (s390x/tcg: Implement VECTOR GENERATE MASK)
> 7/32 Checking commit ee0c0fd7e940 (s390x/tcg: Implement VECTOR LOAD)
> 8/32 Checking commit 3b45e2cedc0a (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
> 9/32 Checking commit a73099e2f39b (s390x/tcg: Implement VECTOR LOAD ELEMENT)
> 10/32 Checking commit 7e69c6881091 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
> 11/32 Checking commit 0402a6b515d0 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
> 12/32 Checking commit 6b0215cba533 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
> 13/32 Checking commit 8956d4b299a9 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
> 14/32 Checking commit 0cb0e0c8dd60 (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
> 15/32 Checking commit 2ad9c8af7091 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
> 16/32 Checking commit aaa23d40467f (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
> 17/32 Checking commit 316ef22fe0bf (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
> 18/32 Checking commit 89103d17261b (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
> 19/32 Checking commit 0eca96087ec5 (s390x/tcg: Implement VECTOR PACK *)
> ERROR: space prohibited between function name and open parenthesis '('
> #182: FILE: target/s390x/vec_helper.c:123:
> +typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \
> 
> total: 1 errors, 0 warnings, 245 lines checked
> 
> Patch 19/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 20/32 Checking commit b004b8aca79d (s390x/tcg: Implement VECTOR PERMUTE)
> WARNING: line over 80 characters
> #21: FILE: target/s390x/helper.h:143:
> +DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)
> 
> total: 0 errors, 1 warnings, 58 lines checked
> 
> Patch 20/32 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 21/32 Checking commit 448206eac2f5 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
> 22/32 Checking commit fe16a34aff9b (s390x/tcg: Implement VECTOR REPLICATE)
> 23/32 Checking commit d37e771f93e0 (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
> 24/32 Checking commit cfefe3b4e519 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
> 25/32 Checking commit 11a18a7c7a67 (s390x/tcg: Implement VECTOR SELECT)
> 26/32 Checking commit 2656298ce402 (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
> 27/32 Checking commit f263bd5abf8b (s390x/tcg: Provide probe_write helper)
> 28/32 Checking commit 4c1389d499cb (s390x/tcg: Implement VECTOR STORE)
> 29/32 Checking commit 8b7bef7bb18e (s390x/tcg: Implement VECTOR STORE ELEMENT)
> 30/32 Checking commit 4d3377c434cd (s390x/tcg: Implement VECTOR STORE MULTIPLE)
> 31/32 Checking commit 5a49ebf4e884 (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
> 32/32 Checking commit 0ac11c9c1553 (s390x/tcg: Implement VECTOR UNPACK *)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/20190301115413.27153-1-david@redhat.com/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
> 

Yes Patchew, I get it, no need to resend 10 times :D

Seriously, one false positive and other stuff that is to be ignored.

-- 

Thanks,

David / dhildenb

Re: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 6 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20190301115413.27153-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190301115413.27153-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190301115413.27153-1-david@redhat.com -> patchew/20190301115413.27153-1-david@redhat.com
Switched to a new branch 'test'
69f8fac141 s390x/tcg: Implement VECTOR UNPACK *
c880cf20c1 s390x/tcg: Implement VECTOR STORE WITH LENGTH
ee2e9af887 s390x/tcg: Implement VECTOR STORE MULTIPLE
7aa62e630a s390x/tcg: Implement VECTOR STORE ELEMENT
c8256f2b1a s390x/tcg: Implement VECTOR STORE
d46406dc22 s390x/tcg: Provide probe_write helper
915399a777 s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
a96e68b664 s390x/tcg: Implement VECTOR SELECT
2e2d6601e9 s390x/tcg: Implement VECTOR SCATTER ELEMENT
dd9b7a4513 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
6fb60fa8ca s390x/tcg: Implement VECTOR REPLICATE
00f45c9b4b s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
991536115b s390x/tcg: Implement VECTOR PERMUTE
1a086e232f s390x/tcg: Implement VECTOR PACK *
441dc1ad6e s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
eea0d21436 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
264aee02c5 s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
178762b2c9 s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
752748c835 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
83a466548d s390x/tcg: Implement VECTOR LOAD MULTIPLE
6f412d9096 s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
a746bae372 s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
2b4edf6d37 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
8920493ccc s390x/tcg: Implement VECTOR LOAD ELEMENT
e6ab4314bc s390x/tcg: Implement VECTOR LOAD AND REPLICATE
e90ac0a19e s390x/tcg: Implement VECTOR LOAD
ca612cd07c s390x/tcg: Implement VECTOR GENERATE MASK
aa887a7c82 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
a06aa08156 s390x/tcg: Implement VECTOR GATHER ELEMENT
0d961d5609 s390x/tcg: Utilities for vector instruction helpers
632b4982bf s390x/tcg: Check vector register instructions at central point
8e61aeb92f s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 8e61aeb92fd9 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 632b4982bfbb (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit 0d961d5609c2 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 128 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit a06aa0815609 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit aa887a7c82c2 (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit ca612cd07c5b (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit e90ac0a19efd (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit e6ab4314bc36 (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 8920493ccc83 (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 2b4edf6d37ed (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit a746bae37239 (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 6f412d909637 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit 83a466548d50 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 752748c83555 (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
15/32 Checking commit 178762b2c92b (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit 264aee02c505 (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit eea0d214368d (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 441dc1ad6e6b (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 1a086e232fcd (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#182: FILE: target/s390x/vec_helper.c:123:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 991536115b82 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:143:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 00f45c9b4bca (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit 6fb60fa8ca15 (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit dd9b7a45130a (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 2e2d6601e96a (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit a96e68b664a1 (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit 915399a777ac (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit d46406dc22b3 (s390x/tcg: Provide probe_write helper)
28/32 Checking commit c8256f2b1a4a (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 7aa62e630a47 (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit ee2e9af88754 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit c880cf20c14c (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 69f8fac14163 (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190301115413.27153-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1

Posted by no-reply@patchew.org 6 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20190301115413.27153-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20190301115413.27153-1-david@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/32] s390x/tcg: Vector Instruction Support Part 1
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190301115413.27153-1-david@redhat.com -> patchew/20190301115413.27153-1-david@redhat.com
Switched to a new branch 'test'
5cae0d10fe s390x/tcg: Implement VECTOR UNPACK *
4f44aa5654 s390x/tcg: Implement VECTOR STORE WITH LENGTH
b9e54c6d14 s390x/tcg: Implement VECTOR STORE MULTIPLE
900959de1e s390x/tcg: Implement VECTOR STORE ELEMENT
a3c7ead3ed s390x/tcg: Implement VECTOR STORE
9d89ffa8dc s390x/tcg: Provide probe_write helper
d493cb908c s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD
239f57c873 s390x/tcg: Implement VECTOR SELECT
06c2b37948 s390x/tcg: Implement VECTOR SCATTER ELEMENT
33913de262 s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE
be76b374bf s390x/tcg: Implement VECTOR REPLICATE
57dc6e4366 s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE
1afedf68d4 s390x/tcg: Implement VECTOR PERMUTE
24f88d3d03 s390x/tcg: Implement VECTOR PACK *
1fb1a87b0e s390x/tcg: Implement VECTOR MERGE (HIGH|LOW)
99c029e225 s390x/tcg: Implement VECTOR LOAD WITH LENGTH
e7a54e791a s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT
a4557b2aac s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR
21d1736c92 s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY
e1f541f5c7 s390x/tcg: Implement VECTOR LOAD MULTIPLE
547df3f09f s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO
9a077d74fb s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT
7877e826b7 s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE
728adba863 s390x/tcg: Implement VECTOR LOAD ELEMENT
8098d3b6aa s390x/tcg: Implement VECTOR LOAD AND REPLICATE
2837793da8 s390x/tcg: Implement VECTOR LOAD
5b86bff39c s390x/tcg: Implement VECTOR GENERATE MASK
3201ce9097 s390x/tcg: Implement VECTOR GENERATE BYTE MASK
e8553a2349 s390x/tcg: Implement VECTOR GATHER ELEMENT
f2c1c776e1 s390x/tcg: Utilities for vector instruction helpers
09866bc43c s390x/tcg: Check vector register instructions at central point
63a10c4c51 s390x/tcg: Define vector instruction formats

=== OUTPUT BEGIN ===
1/32 Checking commit 63a10c4c51c3 (s390x/tcg: Define vector instruction formats)
2/32 Checking commit 09866bc43c18 (s390x/tcg: Check vector register instructions at central point)
3/32 Checking commit f2c1c776e171 (s390x/tcg: Utilities for vector instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 128 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit e8553a234922 (s390x/tcg: Implement VECTOR GATHER ELEMENT)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56: 
new file mode 100644

total: 0 errors, 1 warnings, 155 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/32 Checking commit 3201ce90977e (s390x/tcg: Implement VECTOR GENERATE BYTE MASK)
6/32 Checking commit 5b86bff39c67 (s390x/tcg: Implement VECTOR GENERATE MASK)
7/32 Checking commit 2837793da819 (s390x/tcg: Implement VECTOR LOAD)
8/32 Checking commit 8098d3b6aad4 (s390x/tcg: Implement VECTOR LOAD AND REPLICATE)
9/32 Checking commit 728adba863fe (s390x/tcg: Implement VECTOR LOAD ELEMENT)
10/32 Checking commit 7877e826b7e4 (s390x/tcg: Implement VECTOR LOAD ELEMENT IMMEDIATE)
11/32 Checking commit 9a077d74fbcd (s390x/tcg: Implement VECTOR LOAD GR FROM VR ELEMENT)
12/32 Checking commit 547df3f09fa8 (s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT AND ZERO)
13/32 Checking commit e1f541f5c780 (s390x/tcg: Implement VECTOR LOAD MULTIPLE)
14/32 Checking commit 21d1736c92ef (s390x/tcg: Implement VECTOR LOAD TO BLOCK BOUNDARY)
15/32 Checking commit a4557b2aac41 (s390x/tcg: Implement VECTOR LOAD VR ELEMENT FROM GR)
16/32 Checking commit e7a54e791a48 (s390x/tcg: Implement VECTOR LOAD VR FROM GRS DISJOINT)
17/32 Checking commit 99c029e2250b (s390x/tcg: Implement VECTOR LOAD WITH LENGTH)
18/32 Checking commit 1fb1a87b0e57 (s390x/tcg: Implement VECTOR MERGE (HIGH|LOW))
19/32 Checking commit 24f88d3d0314 (s390x/tcg: Implement VECTOR PACK *)
ERROR: space prohibited between function name and open parenthesis '('
#182: FILE: target/s390x/vec_helper.c:123:
+typedef uint##TBITS##_t (*vpk##BITS##_fn)(uint##BITS##_t, int *);              \

total: 1 errors, 0 warnings, 245 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/32 Checking commit 1afedf68d4e0 (s390x/tcg: Implement VECTOR PERMUTE)
WARNING: line over 80 characters
#21: FILE: target/s390x/helper.h:143:
+DEF_HELPER_FLAGS_5(gvec_vperm, TCG_CALL_NO_RWG, void, ptr, cptr, cptr, cptr, i32)

total: 0 errors, 1 warnings, 58 lines checked

Patch 20/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/32 Checking commit 57dc6e436649 (s390x/tcg: Implement VECTOR PERMUTE DOUBLEWORD IMMEDIATE)
22/32 Checking commit be76b374bf5b (s390x/tcg: Implement VECTOR REPLICATE)
23/32 Checking commit 33913de262e7 (s390x/tcg: Implement VECTOR REPLICATE IMMEDIATE)
24/32 Checking commit 06c2b37948d6 (s390x/tcg: Implement VECTOR SCATTER ELEMENT)
25/32 Checking commit 239f57c873ec (s390x/tcg: Implement VECTOR SELECT)
26/32 Checking commit d493cb908c76 (s390x/tcg: Implement VECTOR SIGN EXTEND TO DOUBLEWORD)
27/32 Checking commit 9d89ffa8dc4f (s390x/tcg: Provide probe_write helper)
28/32 Checking commit a3c7ead3edb3 (s390x/tcg: Implement VECTOR STORE)
29/32 Checking commit 900959de1e8d (s390x/tcg: Implement VECTOR STORE ELEMENT)
30/32 Checking commit b9e54c6d1464 (s390x/tcg: Implement VECTOR STORE MULTIPLE)
31/32 Checking commit 4f44aa5654a9 (s390x/tcg: Implement VECTOR STORE WITH LENGTH)
32/32 Checking commit 5cae0d10fe9e (s390x/tcg: Implement VECTOR UNPACK *)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190301115413.27153-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com