Alex Bennée posted this patch to address an XXX comment in
pflash_cfi01_realize() the other day:

Subject: [PATCH v2] hw/block: report when pflash backing file isn't aligned
Message-Id: <20190215122808.22301-1-alex.bennee@linaro.org>
https://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg04166.html

Review led me to look into its callers.  Most of them are pleasantly
boring: they create flash memory of some fixed size at some fixed
address.  A few are more creative, and some of the creative ones look
quite broken to me.  Fix them, and clean up some along the way.

v2:
* PATCH 01+10: Style cleanups [checkpatch]
* PATCH 02: Rewritten [Peter, Philippe]
* PATCH 03+04: New [Philippe]
* PATCH 06: Commit message improved, FIXME added, accidental
  replacement of 64 * KiB by 65536 backed out [Zoltan]
* PATCH 07: Style tweak [Alex, David]
* PATCH 08: Commit message typo [Philippe]
* PATCH 11: Commit message typo [László]
* Old PATCH 10 dropped [Max, Peter]

Markus Armbruster (11):
  pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
  pflash_cfi01: Do not exit() on guest aborting "write to buffer"
  pflash_cfi01: Log use of flawed "write to buffer"
  pflash: Rename *CFI_PFLASH* to *PFLASH_CFI*
  hw: Use PFLASH_CFI0{1,2} and TYPE_PFLASH_CFI0{1,2}
  sam460ex: Don't size flash memory to match backing image
  ppc405_boards: Don't size flash memory to match backing image
  r2d: Flash memory creation is confused about size, mark FIXME
  mips_malta: Clean up definition of flash memory size somewhat
  pflash: Clean up after commit 368a354f02b part 1
  pflash: Clean up after commit 368a354f02b part 2

 hw/arm/collie.c                          |   9 +-
 hw/arm/digic_boards.c                    |   3 +-
 hw/arm/gumstix.c                         |   8 +-
 hw/arm/mainstone.c                       |   4 +-
 hw/arm/musicpal.c                        |   8 +-
 hw/arm/omap_sx1.c                        |   8 +-
 hw/arm/versatilepb.c                     |   3 +-
 hw/arm/vexpress.c                        |  10 +-
 hw/arm/virt.c                            |   3 +-
 hw/arm/xilinx_zynq.c                     |   5 +-
 hw/arm/z2.c                              |   5 +-
 hw/block/pflash_cfi01.c                  | 123 ++++++++++++-----------
 hw/block/pflash_cfi02.c                  |  79 ++++++++-------
 hw/i386/pc_sysfw.c                       |  10 +-
 hw/lm32/lm32_boards.c                    |   8 +-
 hw/lm32/milkymist.c                      |   4 +-
 hw/microblaze/petalogix_ml605_mmu.c      |   5 +-
 hw/microblaze/petalogix_s3adsp1800_mmu.c |   4 +-
 hw/mips/mips_malta.c                     |  15 ++-
 hw/mips/mips_r4k.c                       |   4 +-
 hw/ppc/ppc405_boards.c                   |  57 ++++-------
 hw/ppc/sam460ex.c                        |  41 +++++---
 hw/ppc/virtex_ml507.c                    |   4 +-
 hw/sh4/r2d.c                             |  11 +-
 hw/xtensa/xtfpga.c                       |  12 +--
 include/hw/block/flash.h                 |  57 +++++++----
 26 files changed, 257 insertions(+), 243 deletions(-)

-- 
2.17.2

Markus Armbruster <armbru@redhat.com> writes:

> Alex Bennée posted this patch to address an XXX comment in
> pflash_cfi01_realize() the other day:

If I send you v5 will you include that in your series?

>
> Subject: [PATCH v2] hw/block: report when pflash backing file isn't aligned
> Message-Id: <20190215122808.22301-1-alex.bennee@linaro.org>
> https://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg04166.html
>
> Review led me to look into its callers.  Most of them are pleasantly
> boring: they create flash memory of some fixed size at some fixed
> address.  A few are more creative, and some of the creative ones look
> quite broken to me.  Fix them, and clean up some along the way.
>
> v2:
> * PATCH 01+10: Style cleanups [checkpatch]
> * PATCH 02: Rewritten [Peter, Philippe]
> * PATCH 03+04: New [Philippe]
> * PATCH 06: Commit message improved, FIXME added, accidental
>   replacement of 64 * KiB by 65536 backed out [Zoltan]
> * PATCH 07: Style tweak [Alex, David]
> * PATCH 08: Commit message typo [Philippe]
> * PATCH 11: Commit message typo [László]
> * Old PATCH 10 dropped [Max, Peter]
>
> Markus Armbruster (11):
>   pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02
>   pflash_cfi01: Do not exit() on guest aborting "write to buffer"
>   pflash_cfi01: Log use of flawed "write to buffer"
>   pflash: Rename *CFI_PFLASH* to *PFLASH_CFI*
>   hw: Use PFLASH_CFI0{1,2} and TYPE_PFLASH_CFI0{1,2}
>   sam460ex: Don't size flash memory to match backing image
>   ppc405_boards: Don't size flash memory to match backing image
>   r2d: Flash memory creation is confused about size, mark FIXME
>   mips_malta: Clean up definition of flash memory size somewhat
>   pflash: Clean up after commit 368a354f02b part 1
>   pflash: Clean up after commit 368a354f02b part 2
>
>  hw/arm/collie.c                          |   9 +-
>  hw/arm/digic_boards.c                    |   3 +-
>  hw/arm/gumstix.c                         |   8 +-
>  hw/arm/mainstone.c                       |   4 +-
>  hw/arm/musicpal.c                        |   8 +-
>  hw/arm/omap_sx1.c                        |   8 +-
>  hw/arm/versatilepb.c                     |   3 +-
>  hw/arm/vexpress.c                        |  10 +-
>  hw/arm/virt.c                            |   3 +-
>  hw/arm/xilinx_zynq.c                     |   5 +-
>  hw/arm/z2.c                              |   5 +-
>  hw/block/pflash_cfi01.c                  | 123 ++++++++++++-----------
>  hw/block/pflash_cfi02.c                  |  79 ++++++++-------
>  hw/i386/pc_sysfw.c                       |  10 +-
>  hw/lm32/lm32_boards.c                    |   8 +-
>  hw/lm32/milkymist.c                      |   4 +-
>  hw/microblaze/petalogix_ml605_mmu.c      |   5 +-
>  hw/microblaze/petalogix_s3adsp1800_mmu.c |   4 +-
>  hw/mips/mips_malta.c                     |  15 ++-
>  hw/mips/mips_r4k.c                       |   4 +-
>  hw/ppc/ppc405_boards.c                   |  57 ++++-------
>  hw/ppc/sam460ex.c                        |  41 +++++---
>  hw/ppc/virtex_ml507.c                    |   4 +-
>  hw/sh4/r2d.c                             |  11 +-
>  hw/xtensa/xtfpga.c                       |  12 +--
>  include/hw/block/flash.h                 |  57 +++++++----
>  26 files changed, 257 insertions(+), 243 deletions(-)


--
Alex Bennée

Alex Bennée <alex.bennee@linaro.org> writes:

> Markus Armbruster <armbru@redhat.com> writes:
>
>> Alex Bennée posted this patch to address an XXX comment in
>> pflash_cfi01_realize() the other day:
>
> If I send you v5 will you include that in your series?

Sure!

Markus Armbruster <armbru@redhat.com> writes:

> Alex Bennée <alex.bennee@linaro.org> writes:
>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Alex Bennée posted this patch to address an XXX comment in
>>> pflash_cfi01_realize() the other day:
>>
>> If I send you v5 will you include that in your series?
>
> Sure!

OK, sent:

  Subject: [PATCH v5] hw/block: better reporting on pflash backing file mismatch
  Date: Wed, 27 Feb 2019 11:13:47 +0000
  Message-Id: <20190227111347.15063-1-alex.bennee@linaro.org>

--
Alex Bennée