[v2] ppc/pnv: increase kernel size limit to 256MiB

[Qemu-devel] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB

Posted by Murilo Opsfelder Araujo 6 years, 8 months ago

First patch increases kernel size limit to 256MiB to fit images generated with
CONFIG_DEBUG_INFO.

Second patch just fixes a misleading comment regarding initrd size limit.

Third patch uses IEC prefixes to represent size constants.

v1..v2:
  Use IEC prefixes as per Eric Blake' suggestion.

Murilo Opsfelder Araujo (3):
  ppc/pnv: increase kernel size limit to 256MiB
  ppc/pnv: add INITRD_MAX_SIZE constant
  ppc/pnv: use IEC binary prefixes to represent sizes

 hw/ppc/pnv.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.20.1

Re: [Qemu-devel] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB

Posted by Cédric Le Goater 6 years, 8 months ago

On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote:
> First patch increases kernel size limit to 256MiB to fit images generated with
> CONFIG_DEBUG_INFO.
> 
> Second patch just fixes a misleading comment regarding initrd size limit.
> 
> Third patch uses IEC prefixes to represent size constants.

They look fine.

Have you tried these patches on a P9 machine ? You will need to use
the powernv-4.0 branch on my github for that.

Thanks,

C. 

> 
> v1..v2:
>   Use IEC prefixes as per Eric Blake' suggestion.
> 
> Murilo Opsfelder Araujo (3):
>   ppc/pnv: increase kernel size limit to 256MiB
>   ppc/pnv: add INITRD_MAX_SIZE constant
>   ppc/pnv: use IEC binary prefixes to represent sizes
> 
>  hw/ppc/pnv.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 0/3] ppc/pnv: increase kernel size limit to 256MiB

Posted by Murilo Opsfelder Araujo 6 years, 8 months ago

On Mon, Feb 25, 2019 at 07:58:06PM +0100, Cédric Le Goater wrote:
> On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote:
> > First patch increases kernel size limit to 256MiB to fit images generated with
> > CONFIG_DEBUG_INFO.
> >
> > Second patch just fixes a misleading comment regarding initrd size limit.
> >
> > Third patch uses IEC prefixes to represent size constants.
>
> They look fine.
>
> Have you tried these patches on a P9 machine ? You will need to use
> the powernv-4.0 branch on my github for that.

I had actually smoke-tested it on my laptop:

[    0.000000] Linux version 5.0.0-rc8-panda (muriloo@localhost) (gcc version 6.4.0 (Buildroot 2018.02-rc2-00006-g39101b7)) #1 SMP Mon Feb 25 11:00:15 -03 2019
[    0.000000] Found initrd at 0xc000000060000000:0xc0000000601e6cfc
[    0.000000] OPAL: Found non-mapped LPC bus on chip 0
[    0.000000] Using PowerNV machine description
[    0.000000] printk: bootconsole [udbg0] enabled
[    0.000000] CPU maps initialized for 1 thread per core
[    0.000000]  (thread shift is 0)
[    0.000000] Allocated 3336 bytes for 1 pacas

My patches apply smoothly on top of your powernv-4.0 branch, in case you're
willing to give it a try.

Let's chat offline to get it tested on a p9 machine.

Thanks for the review!

--
Murilo