From nobody Sun Nov 9 14:49:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551114765003374.6809193705052; Mon, 25 Feb 2019 09:12:45 -0800 (PST) Received: from localhost ([127.0.0.1]:41289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyJo0-0006mk-Sk for importer@patchew.org; Mon, 25 Feb 2019 12:12:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyJeO-0007Ma-HR for qemu-devel@nongnu.org; Mon, 25 Feb 2019 12:02:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyJeI-0007zw-Kn for qemu-devel@nongnu.org; Mon, 25 Feb 2019 12:02:44 -0500 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]:35453) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyJeH-0007vo-Ae; Mon, 25 Feb 2019 12:02:38 -0500 Received: by mail-qt1-x841.google.com with SMTP id p48so11353455qtk.2; Mon, 25 Feb 2019 09:02:29 -0800 (PST) Received: from kermit.br.ibm.com.com ([189.79.172.7]) by smtp.gmail.com with ESMTPSA id v2sm5414972qkc.41.2019.02.25.09.02.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Feb 2019 09:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dxysSrN+FMg8zff2gzn7qCQQHqGhiqeEJ2tn/s5wMGs=; b=EVJo2v/sVa2vnCvHkBeQMNX2FdcaTNCTnpBwmbLD9AYy/ZPU3g0UBjJS2PCS2sM+tF qFXEX7henMElXm95oPgEt/npdzN3OTMszu35ToJkTJjOTn7ysWi909cCcZeWURS53f5H 2dUXSOf8BMdmZgRc20Cs53rvjAd6xd5TK3t2Bg8AxDL8v88D1YhhT3XD17chjnrae19B ieo/r8TXHS3NgQlqweIoTJctDqiF48JEMRqIzmZB8JqXMG364P6LNy1pBBip91iG3+hj NUziqiC3Bk+fnlnEtA2KqlbqrCOpMefHHoqh1M28m+Ax35gV2y/kYl7EalBEeATkP28x MGWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dxysSrN+FMg8zff2gzn7qCQQHqGhiqeEJ2tn/s5wMGs=; b=TFlMi56gFhG7O829g4dIkkkOyxd2IIdk6p68cJO3Wp2cqgZgGexco/pldyWJrSrplD txBPBYJyRIhx8YuZ++sl2OD/3k7lSv3cik+6210ytRg9lnJqRyi3MgKuNSe+1opw9r2x n9lXmn3W+MAvZoCGjYj3of5byVw2xwusS1E+EK13QfYIA7bJWge2mBnoO0inJnkZqt2O LhL0ivkET6qpUuYkBhRXIVpou+0LqJswlrC//fuRZywGttVTtrhHZsLaHCodY3m6PEws ASoho5XLDd0/yQBrIii6aP9QhSCqGYQeCvbF2zDNO1qdDMZ7aN/cCMUnNPISg78JGRw2 Vw9g== X-Gm-Message-State: AHQUAub+Kr1c0Q6JxNvTUkCysBvAK4ytAgjeOd3iWTf8EeVJZtQsaTCZ SHLuEqKWDuz4K5WDI2OLuEEFqaGV X-Google-Smtp-Source: AHgI3Ia5B+NziA2uDMZ7LBHPqXdv8uhihSutdIOgRm4iGv7mH6uia2SvzidU/y/WeTMDk11TtlHWaQ== X-Received: by 2002:ac8:2562:: with SMTP id 31mr14739135qtn.253.1551114148278; Mon, 25 Feb 2019 09:02:28 -0800 (PST) From: Murilo Opsfelder Araujo X-Google-Original-From: Murilo Opsfelder Araujo To: qemu-devel@nongnu.org Date: Mon, 25 Feb 2019 14:01:53 -0300 Message-Id: <20190225170155.1972-2-muriloo@linux.ibm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225170155.1972-1-muriloo@linux.ibm.com> References: <20190225170155.1972-1-muriloo@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::841 Subject: [Qemu-devel] [PATCH v2 1/3] ppc/pnv: increase kernel size limit to 256MiB X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mopsfelder@gmail.com, qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Murilo Opsfelder Araujo , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Building kernel with CONFIG_DEBUG_INFO_REDUCED can generate a ~90MB image a= nd building with CONFIG_DEBUG_INFO can generate a ~225M one, both exceeds the current limit of 32MiB. Increasing kernel size limit to 256MiB should fit for now. Signed-off-by: Murilo Opsfelder Araujo Reviewed-by: C=C3=A9dric Le Goater --- hw/ppc/pnv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index da540860a2..1dbb62c4c9 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -54,6 +54,7 @@ #define FW_MAX_SIZE 0x00400000 =20 #define KERNEL_LOAD_ADDR 0x20000000 +#define KERNEL_MAX_SIZE (256 * MiB) #define INITRD_LOAD_ADDR 0x60000000 =20 static const char *pnv_chip_core_typename(const PnvChip *o) @@ -588,7 +589,7 @@ static void pnv_init(MachineState *machine) long kernel_size; =20 kernel_size =3D load_image_targphys(machine->kernel_filename, - KERNEL_LOAD_ADDR, 0x2000000); + KERNEL_LOAD_ADDR, KERNEL_MAX_SIZ= E); if (kernel_size < 0) { error_report("Could not load kernel '%s'", machine->kernel_filename); --=20 2.20.1 From nobody Sun Nov 9 14:49:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551115264522108.53835237671217; Mon, 25 Feb 2019 09:21:04 -0800 (PST) Received: from localhost ([127.0.0.1]:41705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyJw3-0004DW-DX for importer@patchew.org; Mon, 25 Feb 2019 12:20:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyJeO-0007Md-W0 for qemu-devel@nongnu.org; Mon, 25 Feb 2019 12:02:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyJeK-00081g-92 for qemu-devel@nongnu.org; Mon, 25 Feb 2019 12:02:44 -0500 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]:38155) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyJeK-0007x6-1N; Mon, 25 Feb 2019 12:02:40 -0500 Received: by mail-qt1-x841.google.com with SMTP id s1so11345248qte.5; Mon, 25 Feb 2019 09:02:32 -0800 (PST) Received: from kermit.br.ibm.com.com ([189.79.172.7]) by smtp.gmail.com with ESMTPSA id v2sm5414972qkc.41.2019.02.25.09.02.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Feb 2019 09:02:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dYRtHTr3zwvVNE0iV8eLw8wfZMJC5T6yOlYIgHOU+VY=; b=XflCnGJr8/duMXEr9R892J7Y2zOLQkZm40OBJFctfoEXqr6ye9qxOdmy5WNmev3KYB D1NSnutn39BAFbJAap0jmBMBxMeYqPrHtUUTxQKD/DQ00ue0I+dus5txwUI+AwTm9z2a qCB5+b4ww9A3xq3UKdxabxBX3Ka+Vg0x1FJrsalXyLjim7SBJ78cTqEtEfSTaJSrUtwr RZT1fwkCiY6XOEGtRaCJQ9oGFISGzO64B+KIBGBbaFLF0C803JJ8qu6mYy499qkQ9dRB 5Yxytw5smBXFx8MKj93ltS22UgCOC290V6wY707n8Bod61cyqLG11VOKx9LyKI5nfqi/ 8C2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dYRtHTr3zwvVNE0iV8eLw8wfZMJC5T6yOlYIgHOU+VY=; b=pxLJuCZkYxJZZTl/ErIZxDt1zRG5ixbpbphjgOjaRwIp/9wqfHX02RWCFutgtk7yK3 hRqBPDnMgMx5sYUettUslZWVuLKO9UC3+EYISlgBsPH+igPp+np2rZ8ok6BAXbZG2jbt Uik584Tpo2Bzf7ggzvPLX15LfQ1CD+cz8k7oTk4G657RlDQNlmdMYbWVzZC3//eqJWyP FvU6VUSudSto7Vjk/7TEcog1NWBmrJgb1t7/q/dH6vesBxo7LLEqgLaF/Q9r1mQp2V/i koVit6opVLE6yCRL87E2JIKOyEggmECrIuB8V7Kclhr2lkBJh+u/Bl9+7uFn6KVdBS+D Ryuw== X-Gm-Message-State: AHQUAuY1zMbkk02/zHeZ2ZzMuW5xzD1aChttyDZ9kj+RInn5iWWAJ2Ea 9XoUmKHixc0FxBs/JTCTjnXKpuLh X-Google-Smtp-Source: AHgI3IZoG8sxdQV1qbNvqtuqTdBSMFuPNG1QxTToud5XQaFZA6rFrsDolGCVlFrxfnmJnPcC2Reu4Q== X-Received: by 2002:aed:2268:: with SMTP id o37mr14747099qtc.29.1551114151423; Mon, 25 Feb 2019 09:02:31 -0800 (PST) From: Murilo Opsfelder Araujo X-Google-Original-From: Murilo Opsfelder Araujo To: qemu-devel@nongnu.org Date: Mon, 25 Feb 2019 14:01:54 -0300 Message-Id: <20190225170155.1972-3-muriloo@linux.ibm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225170155.1972-1-muriloo@linux.ibm.com> References: <20190225170155.1972-1-muriloo@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::841 Subject: [Qemu-devel] [PATCH v2 2/3] ppc/pnv: add INITRD_MAX_SIZE constant X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mopsfelder@gmail.com, qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Murilo Opsfelder Araujo , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The current 0x10000000 value is actually 256MiB, not 128MB as the comment suggests. Move it to a constant and fix the comment (no change in the size value). Signed-off-by: Murilo Opsfelder Araujo Reviewed-by: C=C3=A9dric Le Goater --- hw/ppc/pnv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 1dbb62c4c9..c308ae423a 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -56,6 +56,7 @@ #define KERNEL_LOAD_ADDR 0x20000000 #define KERNEL_MAX_SIZE (256 * MiB) #define INITRD_LOAD_ADDR 0x60000000 +#define INITRD_MAX_SIZE (256 * MiB) =20 static const char *pnv_chip_core_typename(const PnvChip *o) { @@ -601,7 +602,7 @@ static void pnv_init(MachineState *machine) if (machine->initrd_filename) { pnv->initrd_base =3D INITRD_LOAD_ADDR; pnv->initrd_size =3D load_image_targphys(machine->initrd_filename, - pnv->initrd_base, 0x10000000); /* 128MB = max */ + pnv->initrd_base, INITRD_MAX_SIZE); if (pnv->initrd_size < 0) { error_report("Could not load initial ram disk '%s'", machine->initrd_filename); --=20 2.20.1 From nobody Sun Nov 9 14:49:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 155111460028145.94002918768524; Mon, 25 Feb 2019 09:10:00 -0800 (PST) Received: from localhost ([127.0.0.1]:41172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyJlM-0004JD-8N for importer@patchew.org; Mon, 25 Feb 2019 12:09:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyJeP-0007Mf-Ej for qemu-devel@nongnu.org; Mon, 25 Feb 2019 12:02:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyJeJ-00080l-Kw for qemu-devel@nongnu.org; Mon, 25 Feb 2019 12:02:45 -0500 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]:43530) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyJeJ-0007yM-DR; Mon, 25 Feb 2019 12:02:39 -0500 Received: by mail-qt1-x841.google.com with SMTP id y4so11291571qtc.10; Mon, 25 Feb 2019 09:02:35 -0800 (PST) Received: from kermit.br.ibm.com.com ([189.79.172.7]) by smtp.gmail.com with ESMTPSA id v2sm5414972qkc.41.2019.02.25.09.02.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Feb 2019 09:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HXZ73LXCMyVqV8zW1hXK49XaZ4PtmS6WwZFihFqXIGE=; b=A6Dz3kCOVwhIAY5Fz5y1ssWpwlGgtd3csuk9l8IXOe3N2c+MZi31RCtaV9OrRCG3A7 y76NygSXUU8QubPY8ytlN9apzpk+f07GQa3oo/ra8pelgtUJCtbOPMJpKWKO1qHVvewE f6q4PSNYWBE+5B1P0x1eSLjmoVpcT8n8N8iY2dADeyCTJlvEsAtkDnjPIviOPJWQNwJT JSaiPQtPGox5wbTJ3NTr0GAV8Xy8CMl4Fe2gbXiVd0x2U/Y05BEw7oYzh4KmqUPqzPA4 D39dXTIeeBl1xO2ThBZFqWZoIDT5JD6yTC9bfumQe8I2Z0zG2cgfDz0E/pe4bnAmI1Eu GrFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HXZ73LXCMyVqV8zW1hXK49XaZ4PtmS6WwZFihFqXIGE=; b=NNMlMKPNB1kOjhOJ9S1UPts/pekMJB6I2h36Vi/ZPzYNvtjJGSA1dgKrn74C653ncn sYEBCpm+dM3c10YS3eEoshzUbu91TLiivQc1EkKajvWZKS/zd7dTIrkH8cIvrcbYI4Jw GvesIBtUMfaHBcNZ4FNUI8u8i72r/V5cgLzJEoN2f2TiD/yxGMCbMX+176gRAeQOxsEL sky53+4BbO4XVPIQPdmf7Blf6oIXXiuTd114bVsiSK0c1nS4aCvTne/SdEC6Xp89Lzl/ JpI99jN+c9KwgQwTpXssggJLkwYMqjX8s21uBbtL3BP9ros0DDlEic0pfuz4JF0nR2x4 dhXg== X-Gm-Message-State: AHQUAuY7i5DqGPXv7Wv8RdmoyNn7YXaezf3pNYaaHJewzFsaGmN1r7ld ZMVYXoyoONBGMjYVwIx8PSzHMB81 X-Google-Smtp-Source: AHgI3Ib2Kqx/DFoDmvOl8fpCxXnNlNQjGDr9x0jmhQcp5HUkDJcU0U7uo9nmXdtmKQEfmJTmINr3zA== X-Received: by 2002:aed:3f2c:: with SMTP id p41mr14382112qtf.261.1551114154458; Mon, 25 Feb 2019 09:02:34 -0800 (PST) From: Murilo Opsfelder Araujo X-Google-Original-From: Murilo Opsfelder Araujo To: qemu-devel@nongnu.org Date: Mon, 25 Feb 2019 14:01:55 -0300 Message-Id: <20190225170155.1972-4-muriloo@linux.ibm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225170155.1972-1-muriloo@linux.ibm.com> References: <20190225170155.1972-1-muriloo@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::841 Subject: [Qemu-devel] [PATCH v2 3/3] ppc/pnv: use IEC binary prefixes to represent sizes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mopsfelder@gmail.com, qemu-ppc@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Murilo Opsfelder Araujo , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Using IEC binary prefixes from qemu/units.h provides a more human-friendly = value to size constants. Suggested-by: Eric Blake Signed-off-by: Murilo Opsfelder Araujo Reviewed-by: C=C3=A9dric Le Goater --- hw/ppc/pnv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index c308ae423a..b6c5d1eff9 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -47,11 +47,11 @@ =20 #include =20 -#define FDT_MAX_SIZE 0x00100000 +#define FDT_MAX_SIZE (1 * MiB) =20 #define FW_FILE_NAME "skiboot.lid" #define FW_LOAD_ADDR 0x0 -#define FW_MAX_SIZE 0x00400000 +#define FW_MAX_SIZE (4 * MiB) =20 #define KERNEL_LOAD_ADDR 0x20000000 #define KERNEL_MAX_SIZE (256 * MiB) --=20 2.20.1