target/arm/cpu.h | 10 +++ target/arm/helper.h | 9 +++ target/arm/cpu.c | 1 + target/arm/cpu64.c | 2 + target/arm/translate-a64.c | 49 +++++++++++- target/arm/translate.c | 104 ++++++++++++++++++------- target/arm/vec_helper.c | 154 +++++++++++++++++++++++++++++++++++++ 7 files changed, 299 insertions(+), 30 deletions(-)
Tested with RISU vs Foundation Model, both a32 and a64. I am aware of a trivial conflict with the ARMv8.3-JSConv patch set. I just thought it was easier to manage separately based on master. r~ Richard Henderson (4): target/arm: Add helpers for FMLAL and FMLSL target/arm: Implement FMLAL and FMLSL for aarch64 target/arm: Implement VFMAL and VFMSL for aarch32 target/arm: Enable ARMv8.2-FHM for -cpu max target/arm/cpu.h | 10 +++ target/arm/helper.h | 9 +++ target/arm/cpu.c | 1 + target/arm/cpu64.c | 2 + target/arm/translate-a64.c | 49 +++++++++++- target/arm/translate.c | 104 ++++++++++++++++++------- target/arm/vec_helper.c | 154 +++++++++++++++++++++++++++++++++++++ 7 files changed, 299 insertions(+), 30 deletions(-) -- 2.17.2
Patchew URL: https://patchew.org/QEMU/20190214034345.24722-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 0/4] target/arm: Implement ARMv8.2-FHM
Type: series
Message-id: 20190214034345.24722-1-richard.henderson@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190214034345.24722-1-richard.henderson@linaro.org -> patchew/20190214034345.24722-1-richard.henderson@linaro.org
Switched to a new branch 'test'
10aad4eb81 target/arm: Enable ARMv8.2-FHM for -cpu max
ff95a88ae6 target/arm: Implement VFMAL and VFMSL for aarch32
598963ad45 target/arm: Implement FMLAL and FMLSL for aarch64
4399afe237 target/arm: Add helpers for FMLAL and FMLSL
=== OUTPUT BEGIN ===
1/4 Checking commit 4399afe237f0 (target/arm: Add helpers for FMLAL and FMLSL)
ERROR: spaces required around that '*' (ctx:VxV)
#130: FILE: target/arm/vec_helper.c:856:
+ d[H4(i)] = fmlal(d[H4(i)], extract64(n_4, i*16, 16),
^
ERROR: spaces required around that '*' (ctx:VxV)
#131: FILE: target/arm/vec_helper.c:857:
+ extract64(m_4, i*16, 16), fpst);
^
ERROR: spaces required around that '*' (ctx:VxV)
#150: FILE: target/arm/vec_helper.c:876:
+ d[H4(i)] = fmlsl(d[H4(i)], extract64(n_4, i*16, 16),
^
ERROR: spaces required around that '*' (ctx:VxV)
#151: FILE: target/arm/vec_helper.c:877:
+ extract64(m_4, i*16, 16), fpst);
^
ERROR: spaces required around that '*' (ctx:VxV)
#193: FILE: target/arm/vec_helper.c:919:
+ d[H4(i)] = fmlsl(d[H4(i)], extract64(n_4, i*16, 16), m_1, fpst);
^
total: 5 errors, 0 warnings, 172 lines checked
Patch 1/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit 598963ad4504 (target/arm: Implement FMLAL and FMLSL for aarch64)
3/4 Checking commit ff95a88ae603 (target/arm: Implement VFMAL and VFMSL for aarch32)
4/4 Checking commit 10aad4eb81e8 (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190214034345.24722-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190214034345.24722-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 0/4] target/arm: Implement ARMv8.2-FHM
Message-id: 20190214034345.24722-1-richard.henderson@linaro.org
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20190214034345.24722-1-richard.henderson@linaro.org -> patchew/20190214034345.24722-1-richard.henderson@linaro.org
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
10aad4e target/arm: Enable ARMv8.2-FHM for -cpu max
ff95a88 target/arm: Implement VFMAL and VFMSL for aarch32
598963a target/arm: Implement FMLAL and FMLSL for aarch64
4399afe target/arm: Add helpers for FMLAL and FMLSL
=== OUTPUT BEGIN ===
1/4 Checking commit 4399afe237f0 (target/arm: Add helpers for FMLAL and FMLSL)
ERROR: spaces required around that '*' (ctx:VxV)
#130: FILE: target/arm/vec_helper.c:856:
+ d[H4(i)] = fmlal(d[H4(i)], extract64(n_4, i*16, 16),
^
ERROR: spaces required around that '*' (ctx:VxV)
#131: FILE: target/arm/vec_helper.c:857:
+ extract64(m_4, i*16, 16), fpst);
^
ERROR: spaces required around that '*' (ctx:VxV)
#150: FILE: target/arm/vec_helper.c:876:
+ d[H4(i)] = fmlsl(d[H4(i)], extract64(n_4, i*16, 16),
^
ERROR: spaces required around that '*' (ctx:VxV)
#151: FILE: target/arm/vec_helper.c:877:
+ extract64(m_4, i*16, 16), fpst);
^
ERROR: spaces required around that '*' (ctx:VxV)
#193: FILE: target/arm/vec_helper.c:919:
+ d[H4(i)] = fmlsl(d[H4(i)], extract64(n_4, i*16, 16), m_1, fpst);
^
total: 5 errors, 0 warnings, 172 lines checked
Patch 1/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit 598963ad4504 (target/arm: Implement FMLAL and FMLSL for aarch64)
3/4 Checking commit ff95a88ae603 (target/arm: Implement VFMAL and VFMSL for aarch32)
4/4 Checking commit 10aad4eb81e8 (target/arm: Enable ARMv8.2-FHM for -cpu max)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190214034345.24722-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.