[Qemu-devel] [PATCH v2 0/3] contrib/rdmacm-mux: fix clang compilation

Marcel Apfelbaum posted 3 patches 5 years, 3 months ago
Test docker-mingw@fedora passed
Test asan passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190118124614.24548-1-marcel.apfelbaum@gmail.com
Maintainers: Yuval Shaia <yuval.shaia@oracle.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Makefile                         |  2 ++
contrib/rdmacm-mux/Makefile.objs |  1 -
contrib/rdmacm-mux/main.c        | 12 +++++++-----
hw/rdma/rdma_backend.c           |  8 ++++----
4 files changed, 13 insertions(+), 10 deletions(-)
[Qemu-devel] [PATCH v2 0/3] contrib/rdmacm-mux: fix clang compilation
Posted by Marcel Apfelbaum 5 years, 3 months ago
v1 -> v2:
 * Use {} construct instead memset to make both gcc and clang happy (Cornelia)
 * Rebased on master
 * Added Yuval's RB and Cornelia's Tested-by tags (thanks!)

Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
                       of RDMA User MAD multiplexer).

The above commit introduces a new contrib target, adding a global dependency
to libumad library in case pvrdma configuration option is enabled.
Clang forbids it:
    clang-6.0: error: -libumad: 'linker' input unused
              [-Werror,-Wunused-command-line-argument]

Fix by limiting the scope to the rdmacm-mux target itself.
Fix related clang errors while at it.

Marcel Apfelbaum (3):
  contrib/rdmacm-mux: remove Wno-format-truncation flag
  hw/rdma: modify struct initialization
  contrib/rdmacm-mux: fix clang compilation

 Makefile                         |  2 ++
 contrib/rdmacm-mux/Makefile.objs |  1 -
 contrib/rdmacm-mux/main.c        | 12 +++++++-----
 hw/rdma/rdma_backend.c           |  8 ++++----
 4 files changed, 13 insertions(+), 10 deletions(-)

-- 
2.17.1