From nobody Fri May 17 09:01:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15478157395531002.1820637810387; Fri, 18 Jan 2019 04:48:59 -0800 (PST) Received: from localhost ([127.0.0.1]:38233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTZy-0004iG-H8 for importer@patchew.org; Fri, 18 Jan 2019 07:48:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTXm-0003W6-Bi for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkTXj-0008CP-LB for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:42 -0500 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:40439) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkTXh-00080y-EU; Fri, 18 Jan 2019 07:46:37 -0500 Received: by mail-wm1-x343.google.com with SMTP id f188so4358631wmf.5; Fri, 18 Jan 2019 04:46:20 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id n15sm69542124wrt.21.2019.01.18.04.46.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jan 2019 04:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VPsuqQD7CnlmDsB6zbi+FLfyXcMrdY20TQwjabS1Gqk=; b=qL0GsGJdbkeVt3IneNVPFwgasLNOFWc4Haocs+CDvSstqvbsnZArCInJwN/6kvzNpJ nFjUuCB1/0/opL+EGPGzkpvit7zveSmgrJYN1qsgkb3ru5Ti6DTnvJzwF5XFg2dkDjZj rOqfUlDFWBttLNmS3VNo/Hy4BtfcZLpkQk//cMtt3ilXZt7caHCB7Cied8Xhgqizk2+t bjAtksz1IPVWpwIikPldcB4vm/B2bqnS1wXIU0IGV2O3jNlV9ViVpC7wnjbm2QVEeTrY s4a3wsLaa/Mz+XrKd4Ide0gVwyPKX7xw7+lBR3jDlw/LvZhjjM70mHunbjw8k6hmIl+Q Mogg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VPsuqQD7CnlmDsB6zbi+FLfyXcMrdY20TQwjabS1Gqk=; b=qro9nQVmIPyHUvew3jA91ReAoCj3MF0sCb/shzvacXYvxJjUz66QBZ+cE+Md1Vv2RF FOtP6SUl5sm0xn+BHtjgzmpCrs91x675sxiEewFxZ1KnH+clKSmqydDOep8X27OS3aul 90rQ8xZdVDWN9VS7k4eaYq7jz3kSQdzZYx2J3s/vM128VGozvyU97G82LfEtIJMjEc/z 5cE5EE+2GVhTDMYGXa9xMUsCIcr0eQROrNqQNbmNDbWMIaByTA5kFCv/cip1ziWTekrA UA1hh2hoqjlEm2pRs28pDPuFnIfRcoLVlhcJ4ZgboxGDSoDgyJP2l46LJ7Egv1QoX34D UwMA== X-Gm-Message-State: AJcUukdnZBEOGh61zMtC33mxgYaWAyo18SLr8RLMLGz7fGQ2YPbl82Nh tBgeFPZpTT+Q7sYcXKHfHoxGzZE/ X-Google-Smtp-Source: ALg8bN4CCDV7ejH16DjtWFRkSoPwbeO/Xs1SpnJnse9cLnEx9OiHakskrUBvhVmxROJL3SdTpHl6zw== X-Received: by 2002:a1c:68d7:: with SMTP id d206mr14999252wmc.43.1547815579235; Fri, 18 Jan 2019 04:46:19 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Fri, 18 Jan 2019 14:46:12 +0200 Message-Id: <20190118124614.24548-2-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> References: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v2 1/3] contrib/rdmacm-mux: remove Wno-format-truncation flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, qemu-stable@nongnu.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The flag is not recognized by some CLANG versions. Add proper constraints in code instead. Reviewed-by: Yuval Shaia Tested-by: Cornelia Huck Signed-off-by: Marcel Apfelbaum --- contrib/rdmacm-mux/Makefile.objs | 2 +- contrib/rdmacm-mux/main.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/contrib/rdmacm-mux/Makefile.objs b/contrib/rdmacm-mux/Makefile= .objs index be3eacb6f7..e1ff4fe569 100644 --- a/contrib/rdmacm-mux/Makefile.objs +++ b/contrib/rdmacm-mux/Makefile.objs @@ -1,4 +1,4 @@ ifdef CONFIG_PVRDMA -CFLAGS +=3D -libumad -Wno-format-truncation +CFLAGS +=3D -libumad rdmacm-mux-obj-y =3D main.o endif diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c index 835a7f9214..64676030c5 100644 --- a/contrib/rdmacm-mux/main.c +++ b/contrib/rdmacm-mux/main.c @@ -42,6 +42,8 @@ =20 /* The below can be override by command line parameter */ #define UNIX_SOCKET_PATH "/var/run/rdmacm-mux" +/* Has format %s-%s-%d" -- */ +#define SOCKET_PATH_MAX (PATH_MAX - NAME_MAX - sizeof(int) - 2) #define RDMA_PORT_NUM 1 =20 typedef struct RdmaCmServerArgs { @@ -95,7 +97,7 @@ static void help(const char *progname) static void parse_args(int argc, char *argv[]) { int c; - char unix_socket_path[PATH_MAX]; + char unix_socket_path[SOCKET_PATH_MAX]; =20 strcpy(server.args.rdma_dev_name, ""); strcpy(unix_socket_path, UNIX_SOCKET_PATH); @@ -113,7 +115,7 @@ static void parse_args(int argc, char *argv[]) =20 case 's': /* This is temporary, final name will build below */ - strncpy(unix_socket_path, optarg, PATH_MAX); + strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX); break; =20 case 'p': --=20 2.17.1 From nobody Fri May 17 09:01:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547815743642500.1355227446958; Fri, 18 Jan 2019 04:49:03 -0800 (PST) Received: from localhost ([127.0.0.1]:38235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTa2-0004k1-K8 for importer@patchew.org; Fri, 18 Jan 2019 07:49:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTXm-0003W7-CI for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkTXj-0008DW-Uw for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:42 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:44391) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkTXj-00081u-Jp; Fri, 18 Jan 2019 07:46:39 -0500 Received: by mail-wr1-x443.google.com with SMTP id z5so14868381wrt.11; Fri, 18 Jan 2019 04:46:22 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id n15sm69542124wrt.21.2019.01.18.04.46.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jan 2019 04:46:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WpXmsnHVnc4IntIIBSWdbeMEjIngri7256gtdpiHNzs=; b=CgJUCigtmJiWPsmfdwv/KHUjmMpAjarsxcL8PUER4zivgehPuWbeOvuJryCg0bRlPC 0JI1IAuSVcA82VLJlcyAQN8ky3jVTZNETSWE14MYl8hJYxDVEPLyXj2oSGr6heBQX5+d M+g4D3ojnag/d7/WRY3vbgFslf/D6NzMd8nVtHB9owuo8MyC1fVWCIeQAiAo3igrs0OJ zwwXfTAnCGWTH23VZXihpElM38u/K0r00UkXy7B76b3xjfCPU2JjL+gJcqbjJ/fdgzUm ExJLlmBDPPa0ymfpS/sXtRGXdDT0++hxzhQoJAX5LX6uo69QaKmxE198M8/woolaVXtb mdWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WpXmsnHVnc4IntIIBSWdbeMEjIngri7256gtdpiHNzs=; b=kPHByHuCbymA/letThbxMG2uLvjgiy4RGhYQfhOqf/uOP9fhXU9SSnLRDQ78Njn8nK AGLdKq6EARnoyb0yJAgdIUFsQzNd5gvdXr4M8PyNuZwThIVTOHGPEWgZWR1OwN/I0JGU VGDYiLDslGHaAOnHClv6HIIZf1KV0VWZta/6jh6xXw2cS/0YUE7yCLfaXt+A/djFHHWY T115A52OBhCDzmQBOJtPsu/pEyqgZwjONcPM9bE8iAETFmv3MXFjkEVS+Cg3rPRXRLl9 Dy8K+7c/LjhFnlXvcChAbb1CfPjauZrnBrt+54T2WAgn45UinkVJrEYQvW6uJWT3jlPI IQvg== X-Gm-Message-State: AJcUukdw9aEUvn/nKhMjmsWG4lorc4pzOE6Mh8sjJxvopToj1xC+T2Ae SMvK25DKHFzwOZYTa9GMIYhVKfHz X-Google-Smtp-Source: ALg8bN5CvyUeOxVbiip2WGrPpJWI7rJeMqFHXPuoOU3PFKSnpchInfZnk+250dBc21lbUK2qUzns3A== X-Received: by 2002:adf:9205:: with SMTP id 5mr16333474wrj.189.1547815580684; Fri, 18 Jan 2019 04:46:20 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Fri, 18 Jan 2019 14:46:13 +0200 Message-Id: <20190118124614.24548-3-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> References: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v2 2/3] hw/rdma: modify struct initialization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, qemu-stable@nongnu.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Do not initialize structs with {0} since some CLANG versions do not support it. Use {} construct instead. Reviewed-by: Yuval Shaia Tested-by: Cornelia Huck Signed-off-by: Marcel Apfelbaum Reviewed-by: Cornelia Huck --- contrib/rdmacm-mux/main.c | 6 +++--- hw/rdma/rdma_backend.c | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c index 64676030c5..ae88c77a1e 100644 --- a/contrib/rdmacm-mux/main.c +++ b/contrib/rdmacm-mux/main.c @@ -350,7 +350,7 @@ static int get_fd(const char *mad, int *fd, __be64 *gid= _ifid) static void *umad_recv_thread_func(void *args) { int rc; - RdmaCmMuxMsg msg =3D {0}; + RdmaCmMuxMsg msg =3D {}; int fd =3D -2; =20 msg.hdr.msg_type =3D RDMACM_MUX_MSG_TYPE_REQ; @@ -387,7 +387,7 @@ static void *umad_recv_thread_func(void *args) static int read_and_process(int fd) { int rc; - RdmaCmMuxMsg msg =3D {0}; + RdmaCmMuxMsg msg =3D {}; struct umad_hdr *hdr; uint32_t *comm_id =3D 0; uint16_t attr_id; @@ -744,7 +744,7 @@ static void signal_handler(int sig, siginfo_t *siginfo,= void *context) static int init(void) { int rc; - struct sigaction sig =3D {0}; + struct sigaction sig =3D {}; =20 rc =3D init_listener(); if (rc) { diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index c28bfbd44d..0b9767fde7 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -190,7 +190,7 @@ static inline int rdmacm_mux_can_process_async(RdmaBack= endDev *backend_dev) =20 static int check_mux_op_status(CharBackend *mad_chr_be) { - RdmaCmMuxMsg msg =3D {0}; + RdmaCmMuxMsg msg =3D {}; int ret; =20 pr_dbg("Reading response\n"); @@ -387,7 +387,7 @@ static int build_host_sge_array(RdmaDeviceResources *rd= ma_dev_res, static int mad_send(RdmaBackendDev *backend_dev, uint8_t sgid_idx, union ibv_gid *sgid, struct ibv_sge *sge, uint32_t num= _sge) { - RdmaCmMuxMsg msg =3D {0}; + RdmaCmMuxMsg msg =3D {}; char *hdr, *data; int ret; =20 @@ -1112,7 +1112,7 @@ int rdma_backend_get_gid_index(RdmaBackendDev *backen= d_dev, int rdma_backend_add_gid(RdmaBackendDev *backend_dev, const char *ifname, union ibv_gid *gid) { - RdmaCmMuxMsg msg =3D {0}; + RdmaCmMuxMsg msg =3D {}; int ret; =20 pr_dbg("0x%llx, 0x%llx\n", @@ -1138,7 +1138,7 @@ int rdma_backend_add_gid(RdmaBackendDev *backend_dev,= const char *ifname, int rdma_backend_del_gid(RdmaBackendDev *backend_dev, const char *ifname, union ibv_gid *gid) { - RdmaCmMuxMsg msg =3D {0}; + RdmaCmMuxMsg msg =3D {}; int ret; =20 pr_dbg("0x%llx, 0x%llx\n", --=20 2.17.1 From nobody Fri May 17 09:01:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1547816266181147.8386209721367; Fri, 18 Jan 2019 04:57:46 -0800 (PST) Received: from localhost ([127.0.0.1]:38437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTiP-0003YC-IK for importer@patchew.org; Fri, 18 Jan 2019 07:57:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTXm-0003W5-Ba for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkTXj-0008DH-V4 for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:42 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:41964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkTXh-00082S-HC; Fri, 18 Jan 2019 07:46:39 -0500 Received: by mail-wr1-x443.google.com with SMTP id x10so14868200wrs.8; Fri, 18 Jan 2019 04:46:23 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id n15sm69542124wrt.21.2019.01.18.04.46.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jan 2019 04:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9zGtyxheSJbBEb3liniqHLckKnDLz5V3hbTZEj54pc0=; b=ndHW/vSmAXCIEiKqZ2lhZvAt3sPyYk+x7EOxtWF17A2hXcnCJLomYNOIDu40iIYPLn ajRMnC4I4w8FFa6zk6GiwsZo7nVYRiHqz5sTKrEQ/+1N41kM6xN+p3LUnfxFTpf7nDZO 6M4Z8Eo/CG+rPtjcrvsZVS4m/cpx/HC5SI/CWfP7YypC4QkJd3sGb7N/mIjKW+TyCMU+ xiiLT0RFbYQDNaslBuvnq6ZL//O45LR0T8/1VCMz4yjhi8hOWm+0aqe58WVCriK2rtYM /23V+NojI3wZ3UWrozlgF9iCD4H6CD2g2zrJo1kDV49SqGKOQaO8QUi+eJP7l2nNp2y1 A3Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9zGtyxheSJbBEb3liniqHLckKnDLz5V3hbTZEj54pc0=; b=OK6hlmMKwPJhCHD3yewGolEORMvbQb3GZCI4kP3/OLhpjqKKZYqGnktyJoBKzuIvxO R/YG6OGJcEX1zYz+O2K2aBsl6DOZ/OBwcJ5mqGy+rmFOcD4B7/8s45xMB7cm+Q7L6ZJA BIIV67FTZVlcrDqf0+AZ4BMyyrOufYnlPOpqI0vZtl6NQ8AXNyK2/Pv150OCRm4APvdk Hv9CmRvjcR9UvRR3IpBwLLyE1NwSHR2hSuMCaUTZ+CIK/ULeUWTketoS6kUOXJbTJYw+ ZAMwgs3SbWFGor5S4PYFN1kHmjq3UCD+qWhfvadxF5wsrL8z5G9EyeOp4uK1epvjusBS 9gjg== X-Gm-Message-State: AJcUukcm/jIZMbOuAskicmRT9F5vKxzwszsTMDRcuQmQOCHyVxRxVmIG ED4dZ52iestVCjJRXZM1GxKNC7sa X-Google-Smtp-Source: ALg8bN4Z5FjztBK8OE2fE5Fq5iNX26G1FdlGuxR2RZTKa1FUMxoC4354TqMm46BTeq7edGewZW9/FA== X-Received: by 2002:adf:e6ce:: with SMTP id y14mr17063501wrm.239.1547815581981; Fri, 18 Jan 2019 04:46:21 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Fri, 18 Jan 2019 14:46:14 +0200 Message-Id: <20190118124614.24548-4-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> References: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v2 3/3] contrib/rdmacm-mux: fix clang compilation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, qemu-stable@nongnu.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer). The above commit introduces a new contrib target, adding a global dependency to libumad library in case pvrdma configuration option is enabled. Clang forbids it: clang-6.0: error: -libumad: 'linker' input unused [-Werror,-Wunused-command-line-argument] Fix by limiting the scope to the rdmacm-mux target itself. Reported-by: Cornelia Huck Reviewed-by: Yuval Shaia Tested-by: Cornelia Huck Signed-off-by: Marcel Apfelbaum --- Makefile | 2 ++ contrib/rdmacm-mux/Makefile.objs | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index dccba1dca2..c9bdb67274 100644 --- a/Makefile +++ b/Makefile @@ -581,6 +581,8 @@ vhost-user-scsi$(EXESUF): $(vhost-user-scsi-obj-y) libv= host-user.a $(call LINK, $^) vhost-user-blk$(EXESUF): $(vhost-user-blk-obj-y) libvhost-user.a $(call LINK, $^) + +rdmacm-mux$(EXESUF): LIBS +=3D "-libumad" rdmacm-mux$(EXESUF): $(rdmacm-mux-obj-y) $(COMMON_LDADDS) $(call LINK, $^) =20 diff --git a/contrib/rdmacm-mux/Makefile.objs b/contrib/rdmacm-mux/Makefile= .objs index e1ff4fe569..3df744af89 100644 --- a/contrib/rdmacm-mux/Makefile.objs +++ b/contrib/rdmacm-mux/Makefile.objs @@ -1,4 +1,3 @@ ifdef CONFIG_PVRDMA -CFLAGS +=3D -libumad rdmacm-mux-obj-y =3D main.o endif --=20 2.17.1