[v4] tests/microbit-test: Add UART device test

[Qemu-devel] [PATCH v4 0/3] tests/microbit-test: Add UART device test

Julia Suvorova via Qemu-devel posted 3 patches 6 years, 9 months ago

Diff against v5
Download series mbox

Failed in applying to current master (apply log)

There is a newer version of this series

tests/libqtest.c      |  26 ++++
tests/libqtest.h      |  11 ++
tests/microbit-test.c | 331 +++++++++++++++++++++++++++---------------
3 files changed, 250 insertions(+), 118 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v4 0/3] tests/microbit-test: Add UART device test

Posted by Julia Suvorova via Qemu-devel 6 years, 9 months ago

v4:
    * Replace sprintf with g_strdup_printf [Peter]
    * Move socket connection to qtest library [Peter]
    * Use memcmp instead of strcmp [Stefan]
    * Remove using global_qtest [Thomas]
v3:
    * Fix directory leak [Stefan]

Based-on: <20190110094020.18354-1-stefanha@redhat.com>

Julia Suvorova (3):
  tests/libqtest: Introduce qtest_init_with_serial()
  tests/microbit-test: Make test independent of global_qtest
  tests/microbit-test: Check nRF51 UART functionality

 tests/libqtest.c      |  26 ++++
 tests/libqtest.h      |  11 ++
 tests/microbit-test.c | 331 +++++++++++++++++++++++++++---------------
 3 files changed, 250 insertions(+), 118 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PATCH v4 0/3] tests/microbit-test: Add UART device test

Posted by Stefan Hajnoczi 6 years, 9 months ago

On Thu, Jan 17, 2019 at 07:16:37PM +0300, Julia Suvorova wrote:
> v4:
>     * Replace sprintf with g_strdup_printf [Peter]
>     * Move socket connection to qtest library [Peter]
>     * Use memcmp instead of strcmp [Stefan]
>     * Remove using global_qtest [Thomas]
> v3:
>     * Fix directory leak [Stefan]
> 
> Based-on: <20190110094020.18354-1-stefanha@redhat.com>
> 
> Julia Suvorova (3):
>   tests/libqtest: Introduce qtest_init_with_serial()
>   tests/microbit-test: Make test independent of global_qtest
>   tests/microbit-test: Check nRF51 UART functionality
> 
>  tests/libqtest.c      |  26 ++++
>  tests/libqtest.h      |  11 ++
>  tests/microbit-test.c | 331 +++++++++++++++++++++++++++---------------
>  3 files changed, 250 insertions(+), 118 deletions(-)

I posted a minor comment which can be touched up when merging.

Thanks for doing the global_qtest removal!

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>