[v1] qcow2: include LUKS payload overhead in qemu-img measure

[Qemu-devel] [PATCH 0/2] qcow2: include LUKS payload overhead in qemu-img measure

Stefan Hajnoczi posted 2 patches 5 years, 5 months ago

Diff against v2 v3
Download series mbox

Test docker-clang@ubuntu passed

Test docker-mingw@fedora passed

Test asan passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190115111007.27159-1-stefanha@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

block/qcow2.c                    | 51 +++++++++++++++++++++++++++++++-
tests/qemu-iotests/178           |  8 +++++
tests/qemu-iotests/178.out.qcow2 | 24 +++++++++++++++
3 files changed, 82 insertions(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/2] qcow2: include LUKS payload overhead in qemu-img measure

Posted by Stefan Hajnoczi 5 years, 5 months ago

The LUKS payload has a significant size (>1 MB).  It must be included in the
qemu-img measure calculation so we arrive at the correct minimum image size.

Stefan Hajnoczi (2):
  qcow2: include LUKS payload overhead in qemu-img measure
  iotests: add LUKS payload overhead to 178 qemu-img measure test

 block/qcow2.c                    | 51 +++++++++++++++++++++++++++++++-
 tests/qemu-iotests/178           |  8 +++++
 tests/qemu-iotests/178.out.qcow2 | 24 +++++++++++++++
 3 files changed, 82 insertions(+), 1 deletion(-)

-- 
2.20.1

Re: [Qemu-devel] [PATCH 0/2] qcow2: include LUKS payload overhead in qemu-img measure

Posted by Philippe Mathieu-Daudé 5 years, 5 months ago

On 1/15/19 12:10 PM, Stefan Hajnoczi wrote:
> The LUKS payload has a significant size (>1 MB).  It must be included in the
> qemu-img measure calculation so we arrive at the correct minimum image size.
> 
> Stefan Hajnoczi (2):
>   qcow2: include LUKS payload overhead in qemu-img measure
>   iotests: add LUKS payload overhead to 178 qemu-img measure test
> 
>  block/qcow2.c                    | 51 +++++++++++++++++++++++++++++++-
>  tests/qemu-iotests/178           |  8 +++++
>  tests/qemu-iotests/178.out.qcow2 | 24 +++++++++++++++
>  3 files changed, 82 insertions(+), 1 deletion(-)
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [PATCH 0/2] qcow2: include LUKS payload overhead in qemu-img measure

Posted by no-reply@patchew.org 5 years, 4 months ago

Patchew URL: https://patchew.org/QEMU/20190115111007.27159-1-stefanha@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=14
=== TEST SCRIPT END ===

  CC      crypto/pbkdf-nettle.o
  CC      crypto/ivgen.o
/tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':
/tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
     strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


The full log is available at
http://patchew.org/logs/20190115111007.27159-1-stefanha@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] qcow2: include LUKS payload overhead in qemu-img measure

Posted by Stefan Hajnoczi 5 years, 4 months ago

On Sun, Jan 20, 2019 at 05:51:06PM -0800, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190115111007.27159-1-stefanha@redhat.com/
...
> /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name':
> /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
>      strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN);
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors

Wasn't me, I swear!

Stefan