[v3] qcow2: include LUKS payload overhead in qemu-img measure

[Qemu-devel] [PATCH v3 0/2] qcow2: include LUKS payload overhead in qemu-img measure

Stefan Hajnoczi posted 2 patches 5 years, 2 months ago

Diff against v1 v2
Download series mbox

Test docker-clang@ubuntu failed

Test asan failed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190218104525.23674-1-stefanha@redhat.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

block/qcow2.c                    | 72 +++++++++++++++++++++++++++++++-
tests/qemu-iotests/178           |  8 ++++
tests/qemu-iotests/178.out.qcow2 | 24 +++++++++++
3 files changed, 103 insertions(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH v3 0/2] qcow2: include LUKS payload overhead in qemu-img measure

Posted by Stefan Hajnoczi 5 years, 2 months ago

v3:
 * Use encrypt.iter-time=10 to speed up qemu-iotests 178 [Max]
v2:
 * Take into account all "encrypt." image creation options since the LUKS
   payload size varies depending on the cipher [Max]

The LUKS payload has a significant size (>1 MB).  It must be included in the
qemu-img measure calculation so we arrive at the correct minimum image size.

Stefan Hajnoczi (2):
  qcow2: include LUKS payload overhead in qemu-img measure
  iotests: add LUKS payload overhead to 178 qemu-img measure test

 block/qcow2.c                    | 72 +++++++++++++++++++++++++++++++-
 tests/qemu-iotests/178           |  8 ++++
 tests/qemu-iotests/178.out.qcow2 | 24 +++++++++++
 3 files changed, 103 insertions(+), 1 deletion(-)

-- 
2.20.1

Re: [Qemu-devel] [PATCH v3 0/2] qcow2: include LUKS payload overhead in qemu-img measure

Posted by Max Reitz 5 years, 2 months ago

On 18.02.19 11:45, Stefan Hajnoczi wrote:
> v3:
>  * Use encrypt.iter-time=10 to speed up qemu-iotests 178 [Max]

Thanks!

> v2:
>  * Take into account all "encrypt." image creation options since the LUKS
>    payload size varies depending on the cipher [Max]
> 
> The LUKS payload has a significant size (>1 MB).  It must be included in the
> qemu-img measure calculation so we arrive at the correct minimum image size.
> 
> Stefan Hajnoczi (2):
>   qcow2: include LUKS payload overhead in qemu-img measure
>   iotests: add LUKS payload overhead to 178 qemu-img measure test
> 
>  block/qcow2.c                    | 72 +++++++++++++++++++++++++++++++-
>  tests/qemu-iotests/178           |  8 ++++
>  tests/qemu-iotests/178.out.qcow2 | 24 +++++++++++
>  3 files changed, 103 insertions(+), 1 deletion(-)

Applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max