Spotted by Coverity: CID 1397074

Signed-off-by: Li Qiang <liq3ea@163.com>
---
 hw/usb/dev-mtp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 6098005cd4..b19b576278 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -1729,6 +1729,7 @@ static void usb_mtp_write_metadata(MTPState *s, uint64_t dlen)
     if (strchr(filename, '/')) {
         usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans,
                              0, 0, 0, 0);
+        g_free(filename);
         return;
     }
 
-- 
2.17.1

On 1/3/19 2:26 PM, Li Qiang wrote:
> Spotted by Coverity: CID 1397074
> 

Gerd, if you take this, can you add:

Fixes: c52d46e041b

> Signed-off-by: Li Qiang <liq3ea@163.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  hw/usb/dev-mtp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 6098005cd4..b19b576278 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -1729,6 +1729,7 @@ static void usb_mtp_write_metadata(MTPState *s, uint64_t dlen)
>      if (strchr(filename, '/')) {
>          usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans,
>                               0, 0, 0, 0);
> +        g_free(filename);
>          return;
>      }
>  
> 

Oh, sorry, I always forget to add this “Fixs: xxx” for these small issues.

Thanks,
Li Qiang


发件人: Philippe Mathieu-Daudé
发送时间: 2019年1月3日 21:38
收件人: Li Qiang; kraxel@redhat.com
抄送: peter.maydell@linaro.org; qemu-devel@nongnu.org
主题: Re: [Qemu-devel] [PATCH] usb: dev-mtp: fix memory leak in error path

On 1/3/19 2:26 PM, Li Qiang wrote:
> Spotted by Coverity: CID 1397074
> 

Gerd, if you take this, can you add:

Fixes: c52d46e041b
> Signed-off-by: Li Qiang <liq3ea@163.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  hw/usb/dev-mtp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 6098005cd4..b19b576278 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -1729,6 +1729,7 @@ static void usb_mtp_write_metadata(MTPState *s, uint64_t dlen)
>      if (strchr(filename, '/')) {
>          usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans,
>                               0, 0, 0, 0);
> +        g_free(filename);
>          return;
>      }
>  
> 

On Thu, Jan 03, 2019 at 02:38:25PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/3/19 2:26 PM, Li Qiang wrote:
> > Spotted by Coverity: CID 1397074
> > 
> 
> Gerd, if you take this, can you add:
> 
> Fixes: c52d46e041b

Done. Thanks for looking up.

cheers,
  Gerd