From nobody Mon May 6 01:08:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=163.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1546522129104750.3913924830455; Thu, 3 Jan 2019 05:28:49 -0800 (PST) Received: from localhost ([127.0.0.1]:53756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf33C-00037C-HZ for importer@patchew.org; Thu, 03 Jan 2019 08:28:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf320-0002Xp-PG for qemu-devel@nongnu.org; Thu, 03 Jan 2019 08:27:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gf31x-0003fX-Im for qemu-devel@nongnu.org; Thu, 03 Jan 2019 08:27:28 -0500 Received: from m12-16.163.com ([220.181.12.16]:34678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gf31w-0003ek-TO for qemu-devel@nongnu.org; Thu, 03 Jan 2019 08:27:25 -0500 Received: from localhost.localdomain (unknown [183.134.169.2]) by smtp12 (Coremail) with SMTP id EMCowADn+HywDS5c7rYqBA--.149S2; Thu, 03 Jan 2019 21:27:17 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=Oa5YF/7HQpVSYZiSjq JY5OXzxudrR+dnMJAQGe3pgLg=; b=A1nBqR0GEWzDzDRdPQBU+FNu9ZAK6mk+My WR4I7qD6wvEWmvNYxnm6X4djLTnoH9sOICpWwtSs+JJ2809SM9C2Og7ZqPyifcyn tFdSHfaZ5aG+Qs0L0h+u2f79+3Ju0gLyidFrGz1S+YpsEZXiJRiuvNmJJwr8pyal ERWsu+Nu0= From: Li Qiang To: kraxel@redhat.com Date: Thu, 3 Jan 2019 05:26:05 -0800 Message-Id: <20190103132605.49476-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: EMCowADn+HywDS5c7rYqBA--.149S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUw0PSDUUUU X-Originating-IP: [183.134.169.2] X-CM-SenderInfo: 5oltjvrd6rljoofrz/xtbBoR0xbVQHDGniwAAAs0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.12.16 Subject: [Qemu-devel] [PATCH] usb: dev-mtp: fix memory leak in error path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Spotted by Coverity: CID 1397074 Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 6098005cd4..b19b576278 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1729,6 +1729,7 @@ static void usb_mtp_write_metadata(MTPState *s, uint6= 4_t dlen) if (strchr(filename, '/')) { usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans, 0, 0, 0, 0); + g_free(filename); return; } =20 --=20 2.17.1