[Qemu-devel] [PATCH v2 1/8] qcow2.h: add missing include

Vladimir Sementsov-Ogievskiy posted 8 patches 6 years, 11 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v2 1/8] qcow2.h: add missing include
Posted by Vladimir Sementsov-Ogievskiy 6 years, 11 months ago
qcow2.h depends on block_int.h. Compilation isn't broken currently only
due to block_int.h always included before qcow2.h. Though, it seems
better to directly include block_int.h in qcow2.h.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block/qcow2.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/qcow2.h b/block/qcow2.h
index a98d24500b..5095f893a0 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -28,6 +28,7 @@
 #include "crypto/block.h"
 #include "qemu/coroutine.h"
 #include "qemu/units.h"
+#include "block/block_int.h"
 
 //#define DEBUG_ALLOC
 //#define DEBUG_ALLOC2
-- 
2.18.0


Re: [Qemu-devel] [PATCH v2 1/8] qcow2.h: add missing include
Posted by Alberto Garcia 6 years, 10 months ago
On Tue 11 Dec 2018 05:43:10 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> qcow2.h depends on block_int.h. Compilation isn't broken currently only
> due to block_int.h always included before qcow2.h. Though, it seems
> better to directly include block_int.h in qcow2.h.

If you include block_int.h in qcow2.h then I guess there's no need to do
it again in qcow2.c

Berto