[Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads

Vladimir Sementsov-Ogievskiy posted 8 patches 4 years, 10 months ago
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190506142741.41731-1-vsementsov@virtuozzo.com
Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
block/qcow2.h          |  20 ++-
block/qcow2-bitmap.c   |   1 -
block/qcow2-cache.c    |   1 -
block/qcow2-cluster.c  |   8 +-
block/qcow2-refcount.c |   1 -
block/qcow2-snapshot.c |   1 -
block/qcow2-threads.c  | 268 +++++++++++++++++++++++++++++++++++++++++
block/qcow2.c          | 241 +++++-------------------------------
block/Makefile.objs    |   2 +-
9 files changed, 321 insertions(+), 222 deletions(-)
create mode 100644 block/qcow2-threads.c
[Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads
Posted by Vladimir Sementsov-Ogievskiy 4 years, 10 months ago
v6:
 - Rebase on master, so 02 changed to reflect changes in
   qcow2_compress(), keep r-b.
 - Rewrite 06 to even simpler locking [Max], drop r-b
   Drop following
   "qcow2: qcow2_co_preadv: skip using hd_qiov when possible", I'll do
   it in my other coming soon series, and it is actually unrelated to
   current.
 - Drop controversial perf test, hope I'll return to this topic, but not
   in context of these series.
 - Add Max's r-b's to all here, except 06

Vladimir Sementsov-Ogievskiy (8):
  qcow2.h: add missing include
  qcow2: add separate file for threaded data processing functions
  qcow2-threads: use thread_pool_submit_co
  qcow2-threads: qcow2_co_do_compress: protect queuing by mutex
  qcow2-threads: split out generic path
  qcow2: qcow2_co_preadv: improve locking
  qcow2: bdrv_co_pwritev: move encryption code out of the lock
  qcow2: do encryption in threads

 block/qcow2.h          |  20 ++-
 block/qcow2-bitmap.c   |   1 -
 block/qcow2-cache.c    |   1 -
 block/qcow2-cluster.c  |   8 +-
 block/qcow2-refcount.c |   1 -
 block/qcow2-snapshot.c |   1 -
 block/qcow2-threads.c  | 268 +++++++++++++++++++++++++++++++++++++++++
 block/qcow2.c          | 241 +++++-------------------------------
 block/Makefile.objs    |   2 +-
 9 files changed, 321 insertions(+), 222 deletions(-)
 create mode 100644 block/qcow2-threads.c

-- 
2.18.0


Re: [Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads
Posted by Max Reitz 4 years, 10 months ago
On 06.05.19 16:27, Vladimir Sementsov-Ogievskiy wrote:
> v6:
>  - Rebase on master, so 02 changed to reflect changes in
>    qcow2_compress(), keep r-b.
>  - Rewrite 06 to even simpler locking [Max], drop r-b
>    Drop following
>    "qcow2: qcow2_co_preadv: skip using hd_qiov when possible", I'll do
>    it in my other coming soon series, and it is actually unrelated to
>    current.
>  - Drop controversial perf test, hope I'll return to this topic, but not
>    in context of these series.
>  - Add Max's r-b's to all here, except 06
> 
> Vladimir Sementsov-Ogievskiy (8):
>   qcow2.h: add missing include
>   qcow2: add separate file for threaded data processing functions
>   qcow2-threads: use thread_pool_submit_co
>   qcow2-threads: qcow2_co_do_compress: protect queuing by mutex
>   qcow2-threads: split out generic path
>   qcow2: qcow2_co_preadv: improve locking
>   qcow2: bdrv_co_pwritev: move encryption code out of the lock
>   qcow2: do encryption in threads
> 
>  block/qcow2.h          |  20 ++-
>  block/qcow2-bitmap.c   |   1 -
>  block/qcow2-cache.c    |   1 -
>  block/qcow2-cluster.c  |   8 +-
>  block/qcow2-refcount.c |   1 -
>  block/qcow2-snapshot.c |   1 -
>  block/qcow2-threads.c  | 268 +++++++++++++++++++++++++++++++++++++++++
>  block/qcow2.c          | 241 +++++-------------------------------
>  block/Makefile.objs    |   2 +-
>  9 files changed, 321 insertions(+), 222 deletions(-)
>  create mode 100644 block/qcow2-threads.c

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max

Re: [Qemu-devel] [PATCH v6 0/8] qcow2: encryption threads
Posted by Vladimir Sementsov-Ogievskiy 4 years, 10 months ago
09.05.2019 17:56, Max Reitz wrote:
> On 06.05.19 16:27, Vladimir Sementsov-Ogievskiy wrote:
>> v6:
>>   - Rebase on master, so 02 changed to reflect changes in
>>     qcow2_compress(), keep r-b.
>>   - Rewrite 06 to even simpler locking [Max], drop r-b
>>     Drop following
>>     "qcow2: qcow2_co_preadv: skip using hd_qiov when possible", I'll do
>>     it in my other coming soon series, and it is actually unrelated to
>>     current.
>>   - Drop controversial perf test, hope I'll return to this topic, but not
>>     in context of these series.
>>   - Add Max's r-b's to all here, except 06
>>
>> Vladimir Sementsov-Ogievskiy (8):
>>    qcow2.h: add missing include
>>    qcow2: add separate file for threaded data processing functions
>>    qcow2-threads: use thread_pool_submit_co
>>    qcow2-threads: qcow2_co_do_compress: protect queuing by mutex
>>    qcow2-threads: split out generic path
>>    qcow2: qcow2_co_preadv: improve locking
>>    qcow2: bdrv_co_pwritev: move encryption code out of the lock
>>    qcow2: do encryption in threads
>>
>>   block/qcow2.h          |  20 ++-
>>   block/qcow2-bitmap.c   |   1 -
>>   block/qcow2-cache.c    |   1 -
>>   block/qcow2-cluster.c  |   8 +-
>>   block/qcow2-refcount.c |   1 -
>>   block/qcow2-snapshot.c |   1 -
>>   block/qcow2-threads.c  | 268 +++++++++++++++++++++++++++++++++++++++++
>>   block/qcow2.c          | 241 +++++-------------------------------
>>   block/Makefile.objs    |   2 +-
>>   9 files changed, 321 insertions(+), 222 deletions(-)
>>   create mode 100644 block/qcow2-threads.c
> 
> Thanks, applied to my block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 

Thank you!!


-- 
Best regards,
Vladimir