[Qemu-devel] [PATCH v3 0/6] monitor: misc fixes

Marc-André Lureau posted 6 patches 6 years, 11 months ago
Test asan passed
Test checkpatch passed
Test docker-quick@centos7 passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181204131802.16885-1-marcandre.lureau@redhat.com
There is a newer version of this series
include/chardev/char.h |  3 ++
chardev/char.c         | 11 +++++++
monitor.c              | 71 ++++++++++++++++++++++++++----------------
3 files changed, 59 insertions(+), 26 deletions(-)
[Qemu-devel] [PATCH v3 0/6] monitor: misc fixes
Posted by Marc-André Lureau 6 years, 11 months ago
Hi,

Here is a small series of fixes for the monitor, mostly related to
threading issues.

v3:
 - replaced an error_report() with an assert()
 - simplify a mon->use_io_thread condition, removing needless QMP check
 - modify/add some code comments
 - update commit messages

v2 bis:
 - update comments/commit messages
 - add Peter r-b

v2: after Peter review
 - patch 2: fix resuming with oob=off
 - patch 4: keep MUX case explicit, improve commit message

Marc-André Lureau (6):
  monitor: inline ambiguous helper functions
  monitor: accept chardev input from iothread
  char: add a QEMU_CHAR_FEATURE_GCONTEXT flag
  monitor: check if chardev can switch gcontext for OOB
  monitor: prevent inserting new monitors after cleanup
  monitor: avoid potential dead-lock when cleaning up

 include/chardev/char.h |  3 ++
 chardev/char.c         | 11 +++++++
 monitor.c              | 71 ++++++++++++++++++++++++++----------------
 3 files changed, 59 insertions(+), 26 deletions(-)

-- 
2.20.0.rc1


Re: [Qemu-devel] [PATCH v3 0/6] monitor: misc fixes
Posted by Markus Armbruster 6 years, 11 months ago
Looks ready except for a few commit message tweaks and the proposed
assertion tweak in 3/6.