[Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes

Marc-André Lureau posted 7 patches 1 week ago
Test checkpatch passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181205203737.9011-1-marcandre.lureau@redhat.com
include/chardev/char.h |  3 ++
chardev/char.c         | 11 +++++++
monitor.c              | 71 ++++++++++++++++++++++++++----------------
net/colo-compare.c     |  6 ++++
4 files changed, 65 insertions(+), 26 deletions(-)

[Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes

Posted by Marc-André Lureau 1 week ago
Hi,

Here is a small series of fixes for the monitor, mostly related to
threading issues.

v4:
 - added "colo: check chardev can switch context"
 - replaced an assert_not_reached() with a better assert
 - commit message updates & rb tags

v3:
 - replaced an error_report() with an assert()
 - simplify a mon->use_io_thread condition, removing needless QMP check
 - modify/add some code comments
 - update commit messages

v2 bis:
 - update comments/commit messages
 - add Peter r-b

v2: after Peter review
 - patch 2: fix resuming with oob=off
 - patch 4: keep MUX case explicit, improve commit message

Marc-André Lureau (7):
  monitor: inline ambiguous helper functions
  monitor: accept chardev input from iothread
  char: add a QEMU_CHAR_FEATURE_GCONTEXT flag
  monitor: check if chardev can switch gcontext for OOB
  colo: check chardev can switch context
  monitor: prevent inserting new monitors after cleanup
  monitor: avoid potential dead-lock when cleaning up

 include/chardev/char.h |  3 ++
 chardev/char.c         | 11 +++++++
 monitor.c              | 71 ++++++++++++++++++++++++++----------------
 net/colo-compare.c     |  6 ++++
 4 files changed, 65 insertions(+), 26 deletions(-)

-- 
2.20.0.rc1


Re: [Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes

Posted by Markus Armbruster 1 week ago
Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Hi,
>
> Here is a small series of fixes for the monitor, mostly related to
> threading issues.

Queued, thanks!