[v1] Break down the MTP write operation

[Qemu-devel] [PATCH 0/2] Break down the MTP write operation

Bandan Das posted 2 patches 6 years, 11 months ago

Diff against v2 v3 v4
Download series mbox

Test asan passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181115220132.6531-1-bsd@redhat.com

There is a newer version of this series

hw/usb/dev-mtp.c | 153 +++++++++++++++++++++++++++++++++++--------------------
1 file changed, 99 insertions(+), 54 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/2] Break down the MTP write operation

Posted by Bandan Das 6 years, 11 months ago

For larger files, not only do we keep reallocating to increase the mtp buffer
size, the write also happens in one go. This does two things:

Write to file upto a certain data size we have received so far and second,
reuse the buffer again instead of reallocating to a larger buffer size.

Tested with different file sizes on a Linux guest.

Bandan Das (2):
  usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ
  usb-mtp: breakup MTP write into smaller chunks

 hw/usb/dev-mtp.c | 153 +++++++++++++++++++++++++++++++++++--------------------
 1 file changed, 99 insertions(+), 54 deletions(-)

-- 
2.14.4

Re: [Qemu-devel] [PATCH 0/2] Break down the MTP write operation

Posted by Gerd Hoffmann 6 years, 10 months ago

  Hi,

> For larger files, not only do we keep reallocating to increase the mtp buffer
> size, the write also happens in one go. This does two things:
> 
> Write to file upto a certain data size we have received so far and second,
> reuse the buffer again instead of reallocating to a larger buffer size.
> 
> Tested with different file sizes on a Linux guest.

Doesn't apply to master, please rebase.

thanks,
  Gerd