From nobody Thu Nov 6 16:00:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 154231942468483.33183190381123; Thu, 15 Nov 2018 14:03:44 -0800 (PST) Received: from localhost ([::1]:40956 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNPjj-0003xT-5i for importer@patchew.org; Thu, 15 Nov 2018 17:03:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNPi2-0002zL-NS for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:01:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNPhz-0000N7-Ia for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:01:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59138) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNPhy-0000IJ-SG for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:01:55 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 891CA1556B for ; Thu, 15 Nov 2018 22:01:51 +0000 (UTC) Received: from gigantic.usersys.redhat.com (dhcp-17-169.bos.redhat.com [10.18.17.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28A2719747; Thu, 15 Nov 2018 22:01:51 +0000 (UTC) From: Bandan Das To: qemu-devel@nongnu.org Date: Thu, 15 Nov 2018 17:01:31 -0500 Message-Id: <20181115220132.6531-2-bsd@redhat.com> In-Reply-To: <20181115220132.6531-1-bsd@redhat.com> References: <20181115220132.6531-1-bsd@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 15 Nov 2018 22:01:51 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/2] usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This is a "pre-patch" to breaking up the write buffer for MTP writes. Instead of allocating a mtp buffer equal to size sent by the initiator, we start with a small size and reallocate multiples (of that small size) as needed. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 00a3691bae..de941d649c 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -152,7 +152,6 @@ struct MTPData { bool first; /* Used for >4G file sizes */ bool pending; - uint64_t cached_length; int fd; }; =20 @@ -244,6 +243,7 @@ typedef struct { =20 #define MTP_MANUFACTURER "QEMU" #define MTP_PRODUCT "QEMU filesharing" +#define MTP_WRITE_BUF_SZ 512000 =20 enum { STR_MANUFACTURER =3D 1, @@ -1647,7 +1647,7 @@ static void usb_mtp_write_data(MTPState *s) d->fd =3D mkdir(path, mask); goto free; } - if ((s->dataset.size !=3D 0xFFFFFFFF) && (s->dataset.size < d->len= gth)) { + if ((s->dataset.size !=3D 0xFFFFFFFF) && (s->dataset.size !=3D d->= offset)) { usb_mtp_queue_result(s, RES_STORE_FULL, d->trans, 0, 0, 0, 0); goto done; @@ -1757,17 +1757,21 @@ static void usb_mtp_get_data(MTPState *s, mtp_conta= iner *container, total_len =3D cpu_to_le32(container->length) - sizeof(mtp_containe= r); /* Length of data in this packet */ data_len -=3D sizeof(mtp_container); - usb_mtp_realloc(d, total_len); - d->length +=3D total_len; + if (total_len < MTP_WRITE_BUF_SZ) { + usb_mtp_realloc(d, total_len); + d->length +=3D total_len; + } else { + usb_mtp_realloc(d, MTP_WRITE_BUF_SZ - sizeof(mtp_container= )); + d->length +=3D MTP_WRITE_BUF_SZ - sizeof(mtp_container); + } d->offset =3D 0; - d->cached_length =3D total_len; d->first =3D false; d->pending =3D false; } =20 if (d->pending) { - usb_mtp_realloc(d, d->cached_length); - d->length +=3D d->cached_length; + usb_mtp_realloc(d, MTP_WRITE_BUF_SZ); + d->length +=3D MTP_WRITE_BUF_SZ; d->pending =3D false; } =20 @@ -1775,12 +1779,6 @@ static void usb_mtp_get_data(MTPState *s, mtp_contai= ner *container, dlen =3D data_len; } else { dlen =3D d->length - d->offset; - /* Check for cached data for large files */ - if ((s->dataset.size =3D=3D 0xFFFFFFFF) && (dlen < p->iov.size)) { - usb_mtp_realloc(d, p->iov.size - dlen); - d->length +=3D p->iov.size - dlen; - dlen =3D p->iov.size; - } } =20 switch (d->code) { @@ -1802,7 +1800,7 @@ static void usb_mtp_get_data(MTPState *s, mtp_contain= er *container, d->offset +=3D dlen; if ((p->iov.size % 64) || !p->iov.size) { assert((s->dataset.size =3D=3D 0xFFFFFFFF) || - (s->dataset.size =3D=3D d->length)); + (s->dataset.size =3D=3D d->offset)); =20 usb_mtp_write_data(s); usb_mtp_data_free(s->data_out); --=20 2.14.4 From nobody Thu Nov 6 16:00:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1542319439553997.5864689913195; Thu, 15 Nov 2018 14:03:59 -0800 (PST) Received: from localhost ([::1]:40957 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNPjy-00048f-6m for importer@patchew.org; Thu, 15 Nov 2018 17:03:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNPi7-00032g-At for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:02:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNPi4-0000RE-QO for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:02:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41290) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gNPi2-0000OS-RT for qemu-devel@nongnu.org; Thu, 15 Nov 2018 17:02:00 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2159307D856 for ; Thu, 15 Nov 2018 22:01:56 +0000 (UTC) Received: from gigantic.usersys.redhat.com (dhcp-17-169.bos.redhat.com [10.18.17.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6149F19747; Thu, 15 Nov 2018 22:01:56 +0000 (UTC) From: Bandan Das To: qemu-devel@nongnu.org Date: Thu, 15 Nov 2018 17:01:32 -0500 Message-Id: <20181115220132.6531-3-bsd@redhat.com> In-Reply-To: <20181115220132.6531-1-bsd@redhat.com> References: <20181115220132.6531-1-bsd@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 15 Nov 2018 22:01:56 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/2] usb-mtp: breakup MTP write into smaller chunks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kraxel@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" For every MTP_WRITE_BUF_SZ copied, this patch writes it to file before getting the next block of data. The file is kept opened for the duration of the operation but the sanity checks on the write operation are performed only once when the write operation starts. Additionally, we also update the file size in the object metadata once the file has completely been written. Suggested-by: Gerd Hoffman Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 133 +++++++++++++++++++++++++++++++++++++--------------= ---- 1 file changed, 90 insertions(+), 43 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index de941d649c..fce6029df0 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -35,6 +35,13 @@ enum mtp_container_type { TYPE_EVENT =3D 4, }; =20 +/* MTP write stage, for internal use only */ +enum mtp_write_status { + WRITE_START =3D 1, + WRITE_CONTINUE =3D 2, + WRITE_END =3D 3, +}; + enum mtp_code { /* command codes */ CMD_GET_DEVICE_INFO =3D 0x1001, @@ -153,6 +160,9 @@ struct MTPData { /* Used for >4G file sizes */ bool pending; int fd; + uint8_t write_status; + /* Internal pointer per every MTP_WRITE_BUF_SZ */ + uint64_t data_offset; }; =20 struct MTPObject { @@ -1607,10 +1617,14 @@ static void utf16_to_str(uint8_t len, uint16_t *arr= , char *name) } =20 /* Wrapper around write, returns 0 on failure */ -static uint64_t write_retry(int fd, void *buf, uint64_t size) +static uint64_t write_retry(int fd, void *buf, uint64_t size, off_t offset) { uint64_t bytes_left =3D size, ret; =20 + if (lseek(fd, offset, SEEK_SET) < 0) { + goto done; + } + while (bytes_left > 0) { ret =3D write(fd, buf, bytes_left); if ((ret =3D=3D -1) && (errno !=3D EINTR || errno !=3D EAG= AIN || @@ -1621,9 +1635,20 @@ static uint64_t write_retry(int fd, void *buf, uint6= 4_t size) buf +=3D ret; } =20 +done: return size - bytes_left; } =20 +static void usb_mtp_update_object(MTPObject *parent, char *name) +{ + MTPObject *o =3D + usb_mtp_object_lookup_name(parent, name, strlen(name)); + + if (o) { + lstat(o->path, &o->stat); + } +} + static void usb_mtp_write_data(MTPState *s) { MTPData *d =3D s->data_out; @@ -1635,48 +1660,55 @@ static void usb_mtp_write_data(MTPState *s) =20 assert(d !=3D NULL); =20 - if (parent =3D=3D NULL || !s->write_pending) { - usb_mtp_queue_result(s, RES_INVALID_OBJECTINFO, d->trans, - 0, 0, 0, 0); + switch (d->write_status) { + case WRITE_START: + if (!parent || !s->write_pending) { + usb_mtp_queue_result(s, RES_INVALID_OBJECTINFO, d->trans, + 0, 0, 0, 0); return; - } - - if (s->dataset.filename) { - path =3D g_strdup_printf("%s/%s", parent->path, s->dataset.filenam= e); - if (s->dataset.format =3D=3D FMT_ASSOCIATION) { - d->fd =3D mkdir(path, mask); - goto free; - } - if ((s->dataset.size !=3D 0xFFFFFFFF) && (s->dataset.size !=3D d->= offset)) { - usb_mtp_queue_result(s, RES_STORE_FULL, d->trans, - 0, 0, 0, 0); - goto done; - } - d->fd =3D open(path, O_CREAT | O_WRONLY, mask); - if (d->fd =3D=3D -1) { - usb_mtp_queue_result(s, RES_STORE_FULL, d->trans, - 0, 0, 0, 0); - goto done; } =20 - /* - * Return success if initiator sent 0 sized data - */ - if (!s->dataset.size) { - goto success; - } + if (s->dataset.filename) { + path =3D g_strdup_printf("%s/%s", parent->path, s->dataset.fil= ename); + if (s->dataset.format =3D=3D FMT_ASSOCIATION) { + d->fd =3D mkdir(path, mask); + goto free; + } + d->fd =3D open(path, O_CREAT | O_WRONLY, mask); + if (d->fd =3D=3D -1) { + usb_mtp_queue_result(s, RES_STORE_FULL, d->trans, + 0, 0, 0, 0); + goto done; + } =20 - rc =3D write_retry(d->fd, d->data, d->offset); - if (rc !=3D d->offset) { + /* Return success if initiator sent 0 sized data */ + if (!s->dataset.size) { + goto success; + } + if (d->length !=3D MTP_WRITE_BUF_SZ && !d->pending) { + d->write_status =3D WRITE_END; + } + } + /* fall through */ + case WRITE_CONTINUE: + case WRITE_END: + rc =3D write_retry(d->fd, d->data, d->data_offset, + d->offset - d->data_offset); + if (rc !=3D d->data_offset) { usb_mtp_queue_result(s, RES_STORE_FULL, d->trans, 0, 0, 0, 0); goto done; + } + if (d->write_status !=3D WRITE_END) { + return; + } else { + /* Only for < 4G file sizes */ + if (s->dataset.size !=3D 0xFFFFFFFF && d->offset !=3D s->datas= et.size) { + usb_mtp_queue_result(s, RES_INCOMPLETE_TRANSFER, d->trans, + 0, 0, 0, 0); + goto done; } - /* Only for < 4G file sizes */ - if (s->dataset.size !=3D 0xFFFFFFFF && rc !=3D s->dataset.size) { - usb_mtp_queue_result(s, RES_INCOMPLETE_TRANSFER, d->trans, - 0, 0, 0, 0); - goto done; + usb_mtp_update_object(parent, s->dataset.filename); } } =20 @@ -1767,25 +1799,33 @@ static void usb_mtp_get_data(MTPState *s, mtp_conta= iner *container, d->offset =3D 0; d->first =3D false; d->pending =3D false; + d->data_offset =3D 0; + d->write_status =3D WRITE_START; } =20 if (d->pending) { - usb_mtp_realloc(d, MTP_WRITE_BUF_SZ); - d->length +=3D MTP_WRITE_BUF_SZ; + memset(d->data, 0, d->length); + if (d->length !=3D MTP_WRITE_BUF_SZ) { + usb_mtp_realloc(d, MTP_WRITE_BUF_SZ - d->length); + d->length +=3D (MTP_WRITE_BUF_SZ - d->length); + } d->pending =3D false; + d->write_status =3D WRITE_CONTINUE; + d->data_offset =3D 0; } =20 - if (d->length - d->offset > data_len) { + if (d->length - d->data_offset > data_len) { dlen =3D data_len; } else { - dlen =3D d->length - d->offset; + dlen =3D d->length - d->data_offset; } =20 switch (d->code) { case CMD_SEND_OBJECT_INFO: - usb_packet_copy(p, d->data + d->offset, dlen); + usb_packet_copy(p, d->data + d->data_offset, dlen); d->offset +=3D dlen; - if (d->offset =3D=3D d->length) { + d->data_offset +=3D dlen; + if (d->data_offset =3D=3D d->length) { /* The operation might have already failed */ if (!s->result) { usb_mtp_write_metadata(s); @@ -1796,19 +1836,26 @@ static void usb_mtp_get_data(MTPState *s, mtp_conta= iner *container, } break; case CMD_SEND_OBJECT: - usb_packet_copy(p, d->data + d->offset, dlen); + usb_packet_copy(p, d->data + d->data_offset, dlen); d->offset +=3D dlen; + d->data_offset +=3D dlen; if ((p->iov.size % 64) || !p->iov.size) { assert((s->dataset.size =3D=3D 0xFFFFFFFF) || (s->dataset.size =3D=3D d->offset)); =20 + if (d->length =3D=3D MTP_WRITE_BUF_SZ) { + d->write_status =3D WRITE_END; + } else { + d->write_status =3D WRITE_START; + } usb_mtp_write_data(s); usb_mtp_data_free(s->data_out); s->data_out =3D NULL; return; } - if (d->offset =3D=3D d->length) { + if (d->data_offset =3D=3D d->length) { d->pending =3D true; + usb_mtp_write_data(s); } break; default: --=20 2.14.4