[v1] another SysBusDevice::init to Device::realize cleanup

[Qemu-devel] [PATCH 00/15] another SysBusDevice::init to Device::realize cleanup

Philippe Mathieu-Daudé posted 15 patches 7 years, 1 month ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181001220942.2382-1-f4bug@amsat.org

Test docker-clang@ubuntu failed

Test checkpatch passed

There is a newer version of this series

default-configs/mips-softmmu-common.mak |   1 -
default-configs/sparc-softmmu.mak       |   1 -
default-configs/sparc64-softmmu.mak     |   1 -
include/hw/empty_slot.h                 |   7 --
hw/alpha/typhoon.c                      |  13 ---
hw/core/empty_slot.c                    | 103 ------------------------
hw/hppa/dino.c                          |   7 --
hw/mips/gt64xxx_pci.c                   |  18 +----
hw/mips/mips_malta.c                    |  17 +---
hw/pci-host/bonito.c                    |   9 +--
hw/sh4/sh_pci.c                         |  20 +++--
hw/sparc/sun4m.c                        |  24 +++---
hw/sparc64/niagara.c                    |   4 +-
hw/ssi/xilinx_spi.c                     |   9 +--
hw/timer/sun4v-rtc.c                    |  23 ++----
hw/core/Makefile.objs                   |   1 -
hw/timer/trace-events                   |   6 +-
17 files changed, 50 insertions(+), 214 deletions(-)
delete mode 100644 include/hw/empty_slot.h
delete mode 100644 hw/core/empty_slot.c

Expand all Fold all

[Qemu-devel] [PATCH 00/15] another SysBusDevice::init to Device::realize cleanup

Posted by Philippe Mathieu-Daudé 7 years, 1 month ago

Peter suggested [1] another crusade for this merge window,
then Cédric jumped on his horse [2]. My turn on my dromedary.

- convert few devices to DeviceState::realize,
- kill the empty_slot device,
- remove unuseful class_init() code [RFC, do we want to keep this?]
- few other minor fixes catched while editing

Regards,

Phil.

[1] https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03605.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00001.html

Philippe Mathieu-Daudé (15):
  trace-events: Fix copy/paste typo
  hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events
  hw/timer/sun4v-rtc: Use DeviceState::realize rather than
    SysBusDevice::init
  hw/ssi/xilinx_spi: Use DeviceState::realize rather than
    SysBusDevice::init
  hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init
  hw/pci-host/bonito: Use DeviceState::realize rather than
    SysBusDevice::init
  hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device
    reset method
  hw/mips/gt64xxx_pci: Mark as bridge device
  hw/mips/malta: Replace 'empty_slot' by 'unimplemented_device'
  hw/sparc64/niagara: Replace 'empty_slot' by 'unimplemented_device'
  hw/sparc/sun4m: Replace 'empty_slot' by 'unimplemented_device'
  hw/core: Remove the 'empty_slot' device
  hw/alpha/typhoon: Remove unuseful code
  hw/hppa/dino: Remove unuseful code
  hw/mips/malta: Remove unuseful code

 default-configs/mips-softmmu-common.mak |   1 -
 default-configs/sparc-softmmu.mak       |   1 -
 default-configs/sparc64-softmmu.mak     |   1 -
 include/hw/empty_slot.h                 |   7 --
 hw/alpha/typhoon.c                      |  13 ---
 hw/core/empty_slot.c                    | 103 ------------------------
 hw/hppa/dino.c                          |   7 --
 hw/mips/gt64xxx_pci.c                   |  18 +----
 hw/mips/mips_malta.c                    |  17 +---
 hw/pci-host/bonito.c                    |   9 +--
 hw/sh4/sh_pci.c                         |  20 +++--
 hw/sparc/sun4m.c                        |  24 +++---
 hw/sparc64/niagara.c                    |   4 +-
 hw/ssi/xilinx_spi.c                     |   9 +--
 hw/timer/sun4v-rtc.c                    |  23 ++----
 hw/core/Makefile.objs                   |   1 -
 hw/timer/trace-events                   |   6 +-
 17 files changed, 50 insertions(+), 214 deletions(-)
 delete mode 100644 include/hw/empty_slot.h
 delete mode 100644 hw/core/empty_slot.c

-- 
2.19.0