[Qemu-devel] [PATCH v2 00/12] another SysBusDevice::init to Device::realize cleanup

Philippe Mathieu-Daudé posted 12 patches 5 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181002212522.23303-1-f4bug@amsat.org
Test docker-clang@ubuntu failed
Test checkpatch passed
default-configs/sparc64-softmmu.mak |  1 -
hw/alpha/typhoon.c                  | 13 -------------
hw/hppa/dino.c                      |  7 -------
hw/mips/gt64xxx_pci.c               | 18 ++++--------------
hw/mips/mips_malta.c                | 13 -------------
hw/pci-host/bonito.c                |  9 +++------
hw/sh4/sh_pci.c                     | 20 +++++++++-----------
hw/sparc64/niagara.c                |  4 ++--
hw/ssi/xilinx_spi.c                 |  9 +++------
hw/timer/sun4v-rtc.c                | 23 ++++++++---------------
hw/timer/trace-events               |  6 +++++-
11 files changed, 34 insertions(+), 89 deletions(-)
[Qemu-devel] [PATCH v2 00/12] another SysBusDevice::init to Device::realize cleanup
Posted by Philippe Mathieu-Daudé 5 years, 5 months ago
Peter suggested [1] another crusade for this merge window,
then Cédric jumped on his horse [2]. My turn on my dromedary.

since v1:
- let the empty_slot
- sh4_pci and bonito use DeviceState::realize instead of PCIDevice::realize
- reword niagara-iob commit message

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00220.html
- convert few devices to DeviceState::realize,
- kill the empty_slot device,
- remove unuseful class_init() code [RFC, do we want to keep this?]
- few other minor fixes catched while editing

Regards,

Phil.

[1] https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03605.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00001.html

001/12:[----] [--] 'trace-events: Fix copy/paste typo'
002/12:[----] [--] 'hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events'
003/12:[----] [--] 'hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init'
004/12:[----] [--] 'hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init'
005/12:[0006] [FC] 'hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init'
006/12:[0006] [FC] 'hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init'
007/12:[----] [--] 'hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method'
008/12:[----] [--] 'hw/mips/gt64xxx_pci: Mark as bridge device'
009/12:[----] [--] 'hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device''
010/12:[----] [--] 'hw/alpha/typhoon: Remove unuseful code'
011/12:[----] [--] 'hw/hppa/dino: Remove unuseful code'
012/12:[----] [--] 'hw/mips/malta: Remove unuseful code'

Philippe Mathieu-Daudé (12):
  trace-events: Fix copy/paste typo
  hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events
  hw/timer/sun4v-rtc: Use DeviceState::realize rather than
    SysBusDevice::init
  hw/ssi/xilinx_spi: Use DeviceState::realize rather than
    SysBusDevice::init
  hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init
  hw/pci-host/bonito: Use DeviceState::realize rather than
    SysBusDevice::init
  hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device
    reset method
  hw/mips/gt64xxx_pci: Mark as bridge device
  hw/sparc64/niagara: Model the I/O Bridge with the
    'unimplemented_device'
  hw/alpha/typhoon: Remove unuseful code
  hw/hppa/dino: Remove unuseful code
  hw/mips/malta: Remove unuseful code

 default-configs/sparc64-softmmu.mak |  1 -
 hw/alpha/typhoon.c                  | 13 -------------
 hw/hppa/dino.c                      |  7 -------
 hw/mips/gt64xxx_pci.c               | 18 ++++--------------
 hw/mips/mips_malta.c                | 13 -------------
 hw/pci-host/bonito.c                |  9 +++------
 hw/sh4/sh_pci.c                     | 20 +++++++++-----------
 hw/sparc64/niagara.c                |  4 ++--
 hw/ssi/xilinx_spi.c                 |  9 +++------
 hw/timer/sun4v-rtc.c                | 23 ++++++++---------------
 hw/timer/trace-events               |  6 +++++-
 11 files changed, 34 insertions(+), 89 deletions(-)

-- 
2.19.0


Re: [Qemu-devel] [PATCH v2 00/12] another SysBusDevice::init to Device::realize cleanup
Posted by Philippe Mathieu-Daudé 5 years, 5 months ago
Hi Eduardo,

On 02/10/2018 23:25, Philippe Mathieu-Daudé wrote:
> Peter suggested [1] another crusade for this merge window,
> then Cédric jumped on his horse [2]. My turn on my dromedary.
> 
> since v1:
> - let the empty_slot
> - sh4_pci and bonito use DeviceState::realize instead of PCIDevice::realize
> - reword niagara-iob commit message
> 
> v1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00220.html
> - convert few devices to DeviceState::realize,
> - kill the empty_slot device,
> - remove unuseful class_init() code [RFC, do we want to keep this?]
> - few other minor fixes catched while editing
> 
> Regards,
> 
> Phil.
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03605.html
> [2] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00001.html
> 
> 001/12:[----] [--] 'trace-events: Fix copy/paste typo'
> 002/12:[----] [--] 'hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events'
> 003/12:[----] [--] 'hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init'
> 004/12:[----] [--] 'hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init'
> 005/12:[0006] [FC] 'hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init'
> 006/12:[0006] [FC] 'hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init'
> 007/12:[----] [--] 'hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method'
> 008/12:[----] [--] 'hw/mips/gt64xxx_pci: Mark as bridge device'
> 009/12:[----] [--] 'hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device''
> 010/12:[----] [--] 'hw/alpha/typhoon: Remove unuseful code'
> 011/12:[----] [--] 'hw/hppa/dino: Remove unuseful code'
> 012/12:[----] [--] 'hw/mips/malta: Remove unuseful code'

Can you take this via your machine-next tree?

Thanks,

Phil.

Re: [Qemu-devel] [PATCH v2 00/12] another SysBusDevice::init to Device::realize cleanup
Posted by Eduardo Habkost 5 years, 5 months ago
On Tue, Oct 09, 2018 at 05:01:49PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Eduardo,
> 
> On 02/10/2018 23:25, Philippe Mathieu-Daudé wrote:
> > Peter suggested [1] another crusade for this merge window,
> > then Cédric jumped on his horse [2]. My turn on my dromedary.
> > 
> > since v1:
> > - let the empty_slot
> > - sh4_pci and bonito use DeviceState::realize instead of PCIDevice::realize
> > - reword niagara-iob commit message
> > 
> > v1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00220.html
> > - convert few devices to DeviceState::realize,
> > - kill the empty_slot device,
> > - remove unuseful class_init() code [RFC, do we want to keep this?]
> > - few other minor fixes catched while editing
> > 
> > Regards,
> > 
> > Phil.
> > 
> > [1] https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03605.html
> > [2] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00001.html
> > 
> > 001/12:[----] [--] 'trace-events: Fix copy/paste typo'
> > 002/12:[----] [--] 'hw/timer/sun4v-rtc: Convert from DPRINTF() macro to trace events'
> > 003/12:[----] [--] 'hw/timer/sun4v-rtc: Use DeviceState::realize rather than SysBusDevice::init'
> > 004/12:[----] [--] 'hw/ssi/xilinx_spi: Use DeviceState::realize rather than SysBusDevice::init'
> > 005/12:[0006] [FC] 'hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init'
> > 006/12:[0006] [FC] 'hw/pci-host/bonito: Use DeviceState::realize rather than SysBusDevice::init'
> > 007/12:[----] [--] 'hw/mips/gt64xxx_pci: Convert gt64120_reset() function into Device reset method'
> > 008/12:[----] [--] 'hw/mips/gt64xxx_pci: Mark as bridge device'
> > 009/12:[----] [--] 'hw/sparc64/niagara: Model the I/O Bridge with the 'unimplemented_device''
> > 010/12:[----] [--] 'hw/alpha/typhoon: Remove unuseful code'
> > 011/12:[----] [--] 'hw/hppa/dino: Remove unuseful code'
> > 012/12:[----] [--] 'hw/mips/malta: Remove unuseful code'
> 
> Can you take this via your machine-next tree?

I'll do it.  Thanks!

-- 
Eduardo