mips: Increase the insn_flags holder size and clean mips-defs.h

[Qemu-devel] [PATCH v3 0/4] mips: Increase the insn_flags holder size and clean mips-defs.h

Philippe Mathieu-Daudé posted 4 patches 7 years, 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180930214744.27580-1-f4bug@amsat.org

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora failed

Test docker-quick@centos7 passed

target/mips/cpu.h                |  2 +-
target/mips/internal.h           |  2 +-
target/mips/mips-defs.h          | 89 ++++++++++++++++++--------------
target/mips/translate.c          |  6 +--
target/mips/translate_init.inc.c |  6 +--
MAINTAINERS                      |  2 +
6 files changed, 61 insertions(+), 46 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v3 0/4] mips: Increase the insn_flags holder size and clean mips-defs.h

Posted by Philippe Mathieu-Daudé 7 years, 1 month ago

After noticing Fredrik patch [1] clashes with an ongoing work, I shared my
concerns after the current limitations of CPUMIPSState::insn_flags, having
1 bit left to store more 'Chip specific instructions'.

Since v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg04064.html

- rebased on upstream/master (previous was based on Fredrik's R5900)

Since v1: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00933.html

- update "int insn_flags;" in target/mips/translate.c::DisasContext
- cleaned the 'insn_flags' namespace per Aleksandar suggestion
- drop cpu defs used once
- add my email in MAINTAINERS:MIPS to help me catch patches to review

Regards,

Phil.

[1] http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg01978.html
[2] http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg00901.html

Philippe Mathieu-Daudé (4):
  target/mips: Increase the 'supported instructions' flags holder size
  target/mips: Remove definitions that are only used once
  target/mips: Clean the 'insn_flags' namespace
  MAINTAINERS: Voluntary to review hobbyist MIPS contributions

 target/mips/cpu.h                |  2 +-
 target/mips/internal.h           |  2 +-
 target/mips/mips-defs.h          | 89 ++++++++++++++++++--------------
 target/mips/translate.c          |  6 +--
 target/mips/translate_init.inc.c |  6 +--
 MAINTAINERS                      |  2 +
 6 files changed, 61 insertions(+), 46 deletions(-)

-- 
2.19.0

Re: [Qemu-devel] [PATCH v3 0/4] mips: Increase the insn_flags holder size and clean mips-defs.h

Posted by Philippe Mathieu-Daudé 7 years ago

Ping?

On 9/30/18 11:47 PM, Philippe Mathieu-Daudé wrote:
> After noticing Fredrik patch [1] clashes with an ongoing work, I shared my
> concerns after the current limitations of CPUMIPSState::insn_flags, having
> 1 bit left to store more 'Chip specific instructions'.
> 
> Since v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg04064.html
> 
> - rebased on upstream/master (previous was based on Fredrik's R5900)>
> Since v1: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00933.html
> 
> - update "int insn_flags;" in target/mips/translate.c::DisasContext
> - cleaned the 'insn_flags' namespace per Aleksandar suggestion
> - drop cpu defs used once
> - add my email in MAINTAINERS:MIPS to help me catch patches to review
> 
> Regards,
> 
> Phil.
> 
> [1] http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg01978.html
> [2] http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg00901.html
> 
> Philippe Mathieu-Daudé (4):
>   target/mips: Increase the 'supported instructions' flags holder size
>   target/mips: Remove definitions that are only used once
>   target/mips: Clean the 'insn_flags' namespace
>   MAINTAINERS: Voluntary to review hobbyist MIPS contributions
> 
>  target/mips/cpu.h                |  2 +-
>  target/mips/internal.h           |  2 +-
>  target/mips/mips-defs.h          | 89 ++++++++++++++++++--------------
>  target/mips/translate.c          |  6 +--
>  target/mips/translate_init.inc.c |  6 +--
>  MAINTAINERS                      |  2 +
>  6 files changed, 61 insertions(+), 46 deletions(-)
>

Re: [Qemu-devel] [PATCH v3 0/4] mips: Increase the insn_flags holder size and clean mips-defs.h

Posted by Aleksandar Markovic 7 years ago

> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> on behalf of Philippe Mathieu-Daudé <f4bug@amsat.org>
>  Subject: Re: [PATCH v3 0/4] mips: Increase the insn_flags holder size and clean mips-defs.h
>
> Ping?

I will get back to this series in next few days.

Thanks,
Aleksandar