exec: drop BQL from interrupt handling

[Qemu-devel] [PATCH 15/35] target/lm32: access cpu->interrupt_request with atomics

Posted by Emilio G. Cota 7 years, 1 month ago

From: Paolo Bonzini <pbonzini@redhat.com>

Cc: Michael Walle <michael@walle.cc>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 target/lm32/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/lm32/cpu.c b/target/lm32/cpu.c
index b7499cb627..6c0178e1ea 100644
--- a/target/lm32/cpu.c
+++ b/target/lm32/cpu.c
@@ -101,7 +101,7 @@ static void lm32_cpu_init_cfg_reg(LM32CPU *cpu)
 
 static bool lm32_cpu_has_work(CPUState *cs)
 {
-    return cs->interrupt_request & CPU_INTERRUPT_HARD;
+    return atomic_read(&cs->interrupt_request) & CPU_INTERRUPT_HARD;
 }
 
 /* CPUClass::reset() */
-- 
2.17.1

Re: [Qemu-devel] [PATCH 15/35] target/lm32: access cpu->interrupt_request with atomics

Posted by Philippe Mathieu-Daudé 7 years, 1 month ago

On 9/17/18 6:30 PM, Emilio G. Cota wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Cc: Michael Walle <michael@walle.cc>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  target/lm32/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/lm32/cpu.c b/target/lm32/cpu.c
> index b7499cb627..6c0178e1ea 100644
> --- a/target/lm32/cpu.c
> +++ b/target/lm32/cpu.c
> @@ -101,7 +101,7 @@ static void lm32_cpu_init_cfg_reg(LM32CPU *cpu)
>  
>  static bool lm32_cpu_has_work(CPUState *cs)
>  {
> -    return cs->interrupt_request & CPU_INTERRUPT_HARD;
> +    return atomic_read(&cs->interrupt_request) & CPU_INTERRUPT_HARD;
>  }
>  
>  /* CPUClass::reset() */
>

Re: [Qemu-devel] [PATCH 15/35] target/lm32: access cpu->interrupt_request with atomics

Posted by Michael Walle 7 years, 1 month ago

Am 2018-09-17 18:30, schrieb Emilio G. Cota:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Cc: Michael Walle <michael@walle.cc>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  target/lm32/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/lm32/cpu.c b/target/lm32/cpu.c
> index b7499cb627..6c0178e1ea 100644
> --- a/target/lm32/cpu.c
> +++ b/target/lm32/cpu.c
> @@ -101,7 +101,7 @@ static void lm32_cpu_init_cfg_reg(LM32CPU *cpu)
> 
>  static bool lm32_cpu_has_work(CPUState *cs)
>  {
> -    return cs->interrupt_request & CPU_INTERRUPT_HARD;
> +    return atomic_read(&cs->interrupt_request) & CPU_INTERRUPT_HARD;
>  }
> 
>  /* CPUClass::reset() */


Acked-by: Michael Walle <michael@walle.cc>