On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/sd/omap_mmc.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/hw/sd/omap_mmc.c b/hw/sd/omap_mmc.c
> index 5b47cadf11..aa2a816f76 100644
> --- a/hw/sd/omap_mmc.c
> +++ b/hw/sd/omap_mmc.c
> @@ -17,6 +17,7 @@
> * with this program; if not, see <http://www.gnu.org/licenses/>.
> */
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/hw.h"
> #include "hw/arm/omap.h"
> #include "hw/sd/sd.h"
> @@ -449,10 +450,14 @@ static void omap_mmc_write(void *opaque, hwaddr offset,
> s->enable = (value >> 11) & 1;
> s->be = (value >> 10) & 1;
> s->clkdiv = (value >> 0) & (s->rev >= 2 ? 0x3ff : 0xff);
> - if (s->mode != 0)
> - printf("SD mode %i unimplemented!\n", s->mode);
> - if (s->be != 0)
> - printf("SD FIFO byte sex unimplemented!\n");
> + if (s->mode != 0) {
> + qemu_log_mask(LOG_UNIMP,
> + "omap_mmc_wr: mode #%i unimplemented\n", s->mode);
> + }
> + if (s->be != 0) {
> + qemu_log_mask(LOG_UNIMP,
> + "omap_mmc_wr: Big Endian not implemented\n");
> + }
> if (s->dw != 0 && s->lines < 4)
> printf("4-bit SD bus enabled\n");
> if (!s->enable)
Reviewed-by: Thomas Huth <thuth@redhat.com>