From nobody Tue Feb 10 02:43:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529604742934841.9178652340362; Thu, 21 Jun 2018 11:12:22 -0700 (PDT) Received: from localhost ([::1]:57066 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fW44E-0007xu-1K for importer@patchew.org; Thu, 21 Jun 2018 14:12:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fW3v7-0000cu-Cn for qemu-devel@nongnu.org; Thu, 21 Jun 2018 14:02:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fW3v4-0006YL-A7 for qemu-devel@nongnu.org; Thu, 21 Jun 2018 14:02:57 -0400 Received: from mail-qt0-x229.google.com ([2607:f8b0:400d:c0d::229]:43344) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fW3v4-0006Y6-50; Thu, 21 Jun 2018 14:02:54 -0400 Received: by mail-qt0-x229.google.com with SMTP id y89-v6so3654524qtd.10; Thu, 21 Jun 2018 11:02:53 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id w51-v6sm2469469qta.12.2018.06.21.11.02.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jun 2018 11:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zGA7Hc9q0oL5P8/T0PP2RkTpDI0zmJwsuY+vQQNtTZc=; b=lu0oe8BDLDxcM2JxR2p0cyeClXRsmjS/KjNlMuP9MjD1STX1YwHZqujO1NtdmIYdWB oYeubUT7HgV0R5YzvdmoJATGXQN5rWJlhvoHsPMz+t1k0uJDKmZZbltc/H0PsKCU70WO zeTp1xGcP+OQYsfDeBxpRxKBaq8dF2tunEBi+FKdqcfU8aKjgJ5v/cwbZaXeOjU5kdhe bAz+ZPnv/DOF2g0m5CDcBp3oOvAHY2RwQy7hVfejZgxmP3KCq6LJjoZebw5ZjERJhXV/ wyteXY9l0GIhjAc/1oNpWqHtomtq+ZbUHvI+DQoal0eAuxlbxWK4OGWTl80s7dGcFtrt QrWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zGA7Hc9q0oL5P8/T0PP2RkTpDI0zmJwsuY+vQQNtTZc=; b=Z5gISRYmPyQiOQOZSN0VElUmG0T0avtFfE3tLywXAkYglN4gjFbTHNHf00x6yNh0o5 loZPc1iOqh6/+dUCl5k5Hb/W0S58kWJOTdlT3H1NlrHTPGoKSZnkkYM2lZvkXHZy2CPA I/OUM2GI6q+3c8MEBJ43wA4CuccTlUiBwQGRqYNJ7yad6dSytxgzVvFx7pNV9J27bpZm dhkygB82P6nKeOKuJZf9IoudBeUhndfG+ygIl+nqbhAs3L4YLT+P3A96uVrnoO+jeJ6y XYQKKNJALpij6vxj+ReJ1iEZkKeyfVOdxvjygyKK3ADKTqXIp5Ap8W/GV7lnRWQl7Wul 2yRA== X-Gm-Message-State: APt69E2omZdtiZsepthYXoAI6J5CPEDlO//a2he4DioX3nZXDGYKyz2Z I2LQ1m61BLjbHEnsI0Eblso= X-Google-Smtp-Source: ADUXVKL59FmIOmOOByOrWO6IglA7mQGs9bxZTmT0BWBvcWKjKS/bTr1FPnWZbfY7tuRmxgrsvdeKAA== X-Received: by 2002:aed:3f6d:: with SMTP id q42-v6mr24126262qtf.375.1529604173428; Thu, 21 Jun 2018 11:02:53 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell Date: Thu, 21 Jun 2018 15:02:19 -0300 Message-Id: <20180621180224.8312-7-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0.rc2 In-Reply-To: <20180621180224.8312-1-f4bug@amsat.org> References: <20180621180224.8312-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::229 Subject: [Qemu-devel] [PATCH 06/11] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/sd/omap_mmc.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/sd/omap_mmc.c b/hw/sd/omap_mmc.c index 5b47cadf11..aa2a816f76 100644 --- a/hw/sd/omap_mmc.c +++ b/hw/sd/omap_mmc.c @@ -17,6 +17,7 @@ * with this program; if not, see . */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/arm/omap.h" #include "hw/sd/sd.h" @@ -449,10 +450,14 @@ static void omap_mmc_write(void *opaque, hwaddr offse= t, s->enable =3D (value >> 11) & 1; s->be =3D (value >> 10) & 1; s->clkdiv =3D (value >> 0) & (s->rev >=3D 2 ? 0x3ff : 0xff); - if (s->mode !=3D 0) - printf("SD mode %i unimplemented!\n", s->mode); - if (s->be !=3D 0) - printf("SD FIFO byte sex unimplemented!\n"); + if (s->mode !=3D 0) { + qemu_log_mask(LOG_UNIMP, + "omap_mmc_wr: mode #%i unimplemented\n", s->mode= ); + } + if (s->be !=3D 0) { + qemu_log_mask(LOG_UNIMP, + "omap_mmc_wr: Big Endian not implemented\n"); + } if (s->dw !=3D 0 && s->lines < 4) printf("4-bit SD bus enabled\n"); if (!s->enable) --=20 2.18.0.rc2