[Qemu-devel] [PATCH v4 0/2] error-report: introduce {error|warn}_report_once

Peter Xu posted 2 patches 7 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180524044454.11792-1-peterx@redhat.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
There is a newer version of this series
include/qemu/error-report.h | 32 ++++++++++++++++++++
hw/i386/intel_iommu.c       | 59 +++++++++++++++++++++----------------
hw/i386/trace-events        |  1 -
3 files changed, 65 insertions(+), 27 deletions(-)
[Qemu-devel] [PATCH v4 0/2] error-report: introduce {error|warn}_report_once
Posted by Peter Xu 7 years, 5 months ago
v4:
- patch 2: pick r-b from Philippe
- patch 1: replace all __* variables into *_ [Eric]
- patch 1: enhance the commit message of patch 1, mention return code
  of macros [Markus]

v3:
- reindent in patch 2, dump more things [Philippe]

v2:
- for patch 1: replace tabs, add trivial comment [Markus]
  (I didn't add much comment otherwise I'll need to duplicate what's
   there in error_report())
- add patch 2

Patch 1 introduce the helpers.

Patch 2 use it to replace VT-d trace_vtd_err().

Please review.  Thanks.

Peter Xu (2):
  qemu-error: introduce {error|warn}_report_once
  intel-iommu: start to use error_report_once

 include/qemu/error-report.h | 32 ++++++++++++++++++++
 hw/i386/intel_iommu.c       | 59 +++++++++++++++++++++----------------
 hw/i386/trace-events        |  1 -
 3 files changed, 65 insertions(+), 27 deletions(-)

-- 
2.17.0


Re: [Qemu-devel] [PATCH v4 0/2] error-report: introduce {error|warn}_report_once
Posted by Markus Armbruster 7 years, 2 months ago
I'm afraid I let this fall through the cracks.  Sorry about that!

PATCH 2 conflicts semantically with commmit 63b88968f13: the latter adds
a trace_vtd_err() the former doesn't replace.  Please respin.

Re: [Qemu-devel] [PATCH v4 0/2] error-report: introduce {error|warn}_report_once
Posted by Peter Xu 7 years, 2 months ago
On Wed, Aug 15, 2018 at 07:58:52AM +0200, Markus Armbruster wrote:
> I'm afraid I let this fall through the cracks.  Sorry about that!
> 
> PATCH 2 conflicts semantically with commmit 63b88968f13: the latter adds
> a trace_vtd_err() the former doesn't replace.  Please respin.

Will do.

Regards,

-- 
Peter Xu