[Qemu-devel] [PATCH v5 0/3] error-report: introduce {error|warn}_report_once

Peter Xu posted 3 patches 5 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180815095328.32414-1-peterx@redhat.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
hw/i386/intel_iommu.c       | 127 +++++++++++++++++++++++-------------
hw/i386/trace-events        |  13 ----
include/qemu/error-report.h |  32 +++++++++
3 files changed, 113 insertions(+), 59 deletions(-)
[Qemu-devel] [PATCH v5 0/3] error-report: introduce {error|warn}_report_once
Posted by Peter Xu 5 years, 8 months ago
v5:
- rebase to master, especially fix up the last one trace_vtd_err()
  introduced in commit 63b88968f13 [Markus]
- add one more patch to replace the rest of trace_vtd_err*() hooks too

v4:
- patch 2: pick r-b from Philippe
- patch 1: replace all __* variables into *_ [Eric]
- patch 1: enhance the commit message of patch 1, mention return code
  of macros [Markus]

v3:
- reindent in patch 2, dump more things [Philippe]

v2:
- for patch 1: replace tabs, add trivial comment [Markus]
  (I didn't add much comment otherwise I'll need to duplicate what's
   there in error_report())
- add patch 2

Patch 1 introduce the helpers.

Patch 2&3 firstly uses it.

Please review.  Thanks.

Peter Xu (3):
  qemu-error: introduce {error|warn}_report_once
  intel-iommu: start to use error_report_once
  intel-iommu: replace more vtd_err_* traces

 hw/i386/intel_iommu.c       | 127 +++++++++++++++++++++++-------------
 hw/i386/trace-events        |  13 ----
 include/qemu/error-report.h |  32 +++++++++
 3 files changed, 113 insertions(+), 59 deletions(-)

-- 
2.17.1


Re: [Qemu-devel] [PATCH v5 0/3] error-report: introduce {error|warn}_report_once
Posted by Markus Armbruster 5 years, 8 months ago
An ACK from Michael Tsirkin would be nice.  But silence won't keep this
series out for long.