include/hw/boards.h | 1 - include/hw/i386/pc.h | 2 +- include/qom/cpu.h | 16 +------- target/alpha/cpu.h | 3 +- target/arm/cpu.h | 3 +- target/cris/cpu.h | 3 +- target/hppa/cpu.h | 2 +- target/i386/cpu.h | 3 +- target/lm32/cpu.h | 3 +- target/m68k/cpu.h | 3 +- target/microblaze/cpu.h | 2 +- target/mips/cpu.h | 3 +- target/moxie/cpu.h | 3 +- target/nios2/cpu.h | 2 +- target/openrisc/cpu.h | 3 +- target/ppc/cpu.h | 3 +- target/riscv/cpu.h | 1 + target/s390x/cpu.h | 3 +- target/sh4/cpu.h | 3 +- target/sparc/cpu.h | 5 +-- target/tilegx/cpu.h | 2 +- target/tricore/cpu.h | 3 +- target/unicore32/cpu.h | 3 +- target/xtensa/cpu.h | 3 +- bsd-user/main.c | 4 +- exec.c | 23 +++++++++++ hw/core/null-machine.c | 6 +-- hw/nios2/10m50_devboard.c | 2 +- linux-user/main.c | 8 +++- qom/cpu.c | 61 +++------------------------- target/i386/cpu.c | 8 +--- tests/machine-none-test.c | 101 ++++++++++++++++++++++++++++++++++++++++++++++ vl.c | 10 ++--- tests/Makefile.include | 2 + 34 files changed, 173 insertions(+), 130 deletions(-) create mode 100644 tests/machine-none-test.c
The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +0000) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next-pull-request for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6: cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-12 19:33:32 -0300) ---------------------------------------------------------------- Machine queue, 2018-03-12 ---------------------------------------------------------------- Igor Mammedov (6): nios2: 10m50_devboard: replace cpu_model with cpu_type tests: add machine 'none' with -cpu test cpu: add CPU_RESOLVING_TYPE macro Use cpu_create(type) instead of cpu_init(cpu_model) cpu: get rid of unused cpu_init() defines cpu: drop unnecessary NULL check and cpu_common_class_by_name() Wang Xin (1): pc: correct misspelled CPU model-id for pc 2.2 include/hw/boards.h | 1 - include/hw/i386/pc.h | 2 +- include/qom/cpu.h | 16 +------- target/alpha/cpu.h | 3 +- target/arm/cpu.h | 3 +- target/cris/cpu.h | 3 +- target/hppa/cpu.h | 2 +- target/i386/cpu.h | 3 +- target/lm32/cpu.h | 3 +- target/m68k/cpu.h | 3 +- target/microblaze/cpu.h | 2 +- target/mips/cpu.h | 3 +- target/moxie/cpu.h | 3 +- target/nios2/cpu.h | 2 +- target/openrisc/cpu.h | 3 +- target/ppc/cpu.h | 3 +- target/riscv/cpu.h | 1 + target/s390x/cpu.h | 3 +- target/sh4/cpu.h | 3 +- target/sparc/cpu.h | 5 +-- target/tilegx/cpu.h | 2 +- target/tricore/cpu.h | 3 +- target/unicore32/cpu.h | 3 +- target/xtensa/cpu.h | 3 +- bsd-user/main.c | 4 +- exec.c | 23 +++++++++++ hw/core/null-machine.c | 6 +-- hw/nios2/10m50_devboard.c | 2 +- linux-user/main.c | 8 +++- qom/cpu.c | 61 +++------------------------- target/i386/cpu.c | 8 +--- tests/machine-none-test.c | 101 ++++++++++++++++++++++++++++++++++++++++++++++ vl.c | 10 ++--- tests/Makefile.include | 2 + 34 files changed, 173 insertions(+), 130 deletions(-) create mode 100644 tests/machine-none-test.c -- 2.14.3
On 12 March 2018 at 22:34, Eduardo Habkost <ehabkost@redhat.com> wrote:
> The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +0000)
>
> are available in the Git repository at:
>
> git://github.com/ehabkost/qemu.git tags/machine-next-pull-request
>
> for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6:
>
> cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-12 19:33:32 -0300)
>
> ----------------------------------------------------------------
> Machine queue, 2018-03-12
>
Hi. It looks like this breaks bsd-user compilation:
/root/qemu/bsd-user/main.c: In function 'main':
/root/qemu/bsd-user/main.c:905:5: warning: implicit declaration of
function 'create' [-Wimplicit-function-declaration]
cpu = create(cpu_type);
^
/root/qemu/bsd-user/main.c:905:5: warning: nested extern declaration
of 'create' [-Wnested-externs]
/root/qemu/bsd-user/main.c:905:9: warning: assignment makes pointer
from integer without a cast [enabled by default]
cpu = create(cpu_type);
^
and then later it fails to link with
/root/qemu/bsd-user/main.c:905: undefined reference to `create'
thanks
-- PMM
On Tue, Mar 13, 2018 at 06:29:10PM +0000, Peter Maydell wrote: > On 12 March 2018 at 22:34, Eduardo Habkost <ehabkost@redhat.com> wrote: > > The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +0000) > > > > are available in the Git repository at: > > > > git://github.com/ehabkost/qemu.git tags/machine-next-pull-request > > > > for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6: > > > > cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-12 19:33:32 -0300) > > > > ---------------------------------------------------------------- > > Machine queue, 2018-03-12 > > > > Hi. It looks like this breaks bsd-user compilation: > > /root/qemu/bsd-user/main.c: In function 'main': > /root/qemu/bsd-user/main.c:905:5: warning: implicit declaration of > function 'create' [-Wimplicit-function-declaration] > cpu = create(cpu_type); > ^ > /root/qemu/bsd-user/main.c:905:5: warning: nested extern declaration > of 'create' [-Wnested-externs] > /root/qemu/bsd-user/main.c:905:9: warning: assignment makes pointer > from integer without a cast [enabled by default] > cpu = create(cpu_type); > ^ > > and then later it fails to link with > /root/qemu/bsd-user/main.c:905: undefined reference to `create' Oops, sorry. I don't have a BSD host handy right now, are you able to confirm if the new tag I pushed fixes it? The following changes since commit 026aaf47c02b79036feb830206cfebb2a726510d: Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2018-03-13 16:26:44 +0000) are available in the Git repository at: git://github.com/ehabkost/qemu.git tags/machine-next-pull-request for you to fetch changes up to e291aefcd38ca3d048e45f644e9321d02fc253cc: cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-13 15:33:26 -0300) ---------------------------------------------------------------- machine queue, 2018-03-13 ---------------------------------------------------------------- Igor Mammedov (6): nios2: 10m50_devboard: replace cpu_model with cpu_type tests: add machine 'none' with -cpu test cpu: add CPU_RESOLVING_TYPE macro Use cpu_create(type) instead of cpu_init(cpu_model) cpu: get rid of unused cpu_init() defines cpu: drop unnecessary NULL check and cpu_common_class_by_name() Wang Xin (1): pc: correct misspelled CPU model-id for pc 2.2 -- Eduardo
On Tue, Mar 13, 2018 at 03:37:04PM -0300, Eduardo Habkost wrote:
> On Tue, Mar 13, 2018 at 06:29:10PM +0000, Peter Maydell wrote:
> > On 12 March 2018 at 22:34, Eduardo Habkost <ehabkost@redhat.com> wrote:
> > > The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e:
> > >
> > > Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +0000)
> > >
> > > are available in the Git repository at:
> > >
> > > git://github.com/ehabkost/qemu.git tags/machine-next-pull-request
> > >
> > > for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6:
> > >
> > > cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-12 19:33:32 -0300)
> > >
> > > ----------------------------------------------------------------
> > > Machine queue, 2018-03-12
> > >
> >
> > Hi. It looks like this breaks bsd-user compilation:
> >
> > /root/qemu/bsd-user/main.c: In function 'main':
> > /root/qemu/bsd-user/main.c:905:5: warning: implicit declaration of
> > function 'create' [-Wimplicit-function-declaration]
> > cpu = create(cpu_type);
> > ^
> > /root/qemu/bsd-user/main.c:905:5: warning: nested extern declaration
> > of 'create' [-Wnested-externs]
> > /root/qemu/bsd-user/main.c:905:9: warning: assignment makes pointer
> > from integer without a cast [enabled by default]
> > cpu = create(cpu_type);
> > ^
> >
> > and then later it fails to link with
> > /root/qemu/bsd-user/main.c:905: undefined reference to `create'
>
> Oops, sorry. I don't have a BSD host handy right now, are you able to confirm
> if the new tag I pushed fixes it?
I didn't get test results on BSD, but as the fix was obvious I sent a
new pull request today ("[PULL v2 0/7] Machine queue, 2018-03-15").
>
> The following changes since commit 026aaf47c02b79036feb830206cfebb2a726510d:
>
> Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2018-03-13 16:26:44 +0000)
>
> are available in the Git repository at:
>
> git://github.com/ehabkost/qemu.git tags/machine-next-pull-request
>
> for you to fetch changes up to e291aefcd38ca3d048e45f644e9321d02fc253cc:
>
> cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-13 15:33:26 -0300)
>
> ----------------------------------------------------------------
> machine queue, 2018-03-13
>
> ----------------------------------------------------------------
>
> Igor Mammedov (6):
> nios2: 10m50_devboard: replace cpu_model with cpu_type
> tests: add machine 'none' with -cpu test
> cpu: add CPU_RESOLVING_TYPE macro
> Use cpu_create(type) instead of cpu_init(cpu_model)
> cpu: get rid of unused cpu_init() defines
> cpu: drop unnecessary NULL check and cpu_common_class_by_name()
>
> Wang Xin (1):
> pc: correct misspelled CPU model-id for pc 2.2
>
> --
> Eduardo
>
--
Eduardo
Hi Eduardo, On 03/13/2018 07:37 PM, Eduardo Habkost wrote: > On Tue, Mar 13, 2018 at 06:29:10PM +0000, Peter Maydell wrote: >> On 12 March 2018 at 22:34, Eduardo Habkost <ehabkost@redhat.com> wrote: >>> The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: >>> >>> Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +0000) >>> >>> are available in the Git repository at: >>> >>> git://github.com/ehabkost/qemu.git tags/machine-next-pull-request >>> >>> for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6: >>> >>> cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-12 19:33:32 -0300) >>> >>> ---------------------------------------------------------------- >>> Machine queue, 2018-03-12 >>> >> >> Hi. It looks like this breaks bsd-user compilation: >> >> /root/qemu/bsd-user/main.c: In function 'main': >> /root/qemu/bsd-user/main.c:905:5: warning: implicit declaration of >> function 'create' [-Wimplicit-function-declaration] >> cpu = create(cpu_type); >> ^ >> /root/qemu/bsd-user/main.c:905:5: warning: nested extern declaration >> of 'create' [-Wnested-externs] >> /root/qemu/bsd-user/main.c:905:9: warning: assignment makes pointer >> from integer without a cast [enabled by default] >> cpu = create(cpu_type); >> ^ >> >> and then later it fails to link with >> /root/qemu/bsd-user/main.c:905: undefined reference to `create' > > Oops, sorry. I don't have a BSD host handy right now, are you able to confirm > if the new tag I pushed fixes it? You might try: $ make vm-test vm-test: Test QEMU in preconfigured virtual machines vm-build-ubuntu.i386 - Build QEMU in ubuntu i386 VM vm-build-freebsd - Build QEMU in FreeBSD VM vm-build-netbsd - Build QEMU in NetBSD VM vm-build-openbsd - Build QEMU in OpenBSD VM Regards, Phil.
On Thu, Mar 15, 2018 at 07:31:09PM +0100, Philippe Mathieu-Daudé wrote: > Hi Eduardo, > > On 03/13/2018 07:37 PM, Eduardo Habkost wrote: > > On Tue, Mar 13, 2018 at 06:29:10PM +0000, Peter Maydell wrote: > >> On 12 March 2018 at 22:34, Eduardo Habkost <ehabkost@redhat.com> wrote: > >>> The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > >>> > >>> Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +0000) > >>> > >>> are available in the Git repository at: > >>> > >>> git://github.com/ehabkost/qemu.git tags/machine-next-pull-request > >>> > >>> for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6: > >>> > >>> cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-12 19:33:32 -0300) > >>> > >>> ---------------------------------------------------------------- > >>> Machine queue, 2018-03-12 > >>> > >> > >> Hi. It looks like this breaks bsd-user compilation: > >> > >> /root/qemu/bsd-user/main.c: In function 'main': > >> /root/qemu/bsd-user/main.c:905:5: warning: implicit declaration of > >> function 'create' [-Wimplicit-function-declaration] > >> cpu = create(cpu_type); > >> ^ > >> /root/qemu/bsd-user/main.c:905:5: warning: nested extern declaration > >> of 'create' [-Wnested-externs] > >> /root/qemu/bsd-user/main.c:905:9: warning: assignment makes pointer > >> from integer without a cast [enabled by default] > >> cpu = create(cpu_type); > >> ^ > >> > >> and then later it fails to link with > >> /root/qemu/bsd-user/main.c:905: undefined reference to `create' > > > > Oops, sorry. I don't have a BSD host handy right now, are you able to confirm > > if the new tag I pushed fixes it? > > You might try: > > $ make vm-test > vm-test: Test QEMU in preconfigured virtual machines > > vm-build-ubuntu.i386 - Build QEMU in ubuntu i386 VM > vm-build-freebsd - Build QEMU in FreeBSD VM > vm-build-netbsd - Build QEMU in NetBSD VM > vm-build-openbsd - Build QEMU in OpenBSD VM This is awesome, thanks for the pointer! -- Eduardo
On Tue, 13 Mar 2018 18:29:10 +0000 Peter Maydell <peter.maydell@linaro.org> wrote: > On 12 March 2018 at 22:34, Eduardo Habkost <ehabkost@redhat.com> wrote: > > The following changes since commit 6ceb1b51f05f9e1892d082960ed602dca7b6696e: > > > > Merge remote-tracking branch 'remotes/kraxel/tags/audio-20180312-pull-request' into staging (2018-03-12 16:14:37 +0000) > > > > are available in the Git repository at: > > > > git://github.com/ehabkost/qemu.git tags/machine-next-pull-request > > > > for you to fetch changes up to a82664f2f8b1ce2db90e644df01d7ca7845881a6: > > > > cpu: drop unnecessary NULL check and cpu_common_class_by_name() (2018-03-12 19:33:32 -0300) > > > > ---------------------------------------------------------------- > > Machine queue, 2018-03-12 > > > > Hi. It looks like this breaks bsd-user compilation: > > /root/qemu/bsd-user/main.c: In function 'main': > /root/qemu/bsd-user/main.c:905:5: warning: implicit declaration of > function 'create' [-Wimplicit-function-declaration] > cpu = create(cpu_type); > ^ > /root/qemu/bsd-user/main.c:905:5: warning: nested extern declaration > of 'create' [-Wnested-externs] > /root/qemu/bsd-user/main.c:905:9: warning: assignment makes pointer > from integer without a cast [enabled by default] > cpu = create(cpu_type); > ^ > > and then later it fails to link with > /root/qemu/bsd-user/main.c:905: undefined reference to `create' Sorry, it was my mistake not testing series on BSD after the last rewriting fix should be s/create/create_cpu/. Eduardo fixed it up in his updated pull req. > > thanks > -- PMM >
© 2016 - 2024 Red Hat, Inc.