io: fix QIONetListener memory leak

[Qemu-devel] [PATCH] io: fix QIONetListener memory leak

Paolo Bonzini posted 1 patch 7 years, 10 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20171218085308.23241-1-pbonzini@redhat.com

Test checkpatch passed

Test docker passed

Test ppc passed

Test s390x passed

io/net-listener.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] io: fix QIONetListener memory leak

Posted by Paolo Bonzini 7 years, 10 months ago

The sources array does not escape out of qio_net_listener_wait_client, so
we have to free it.

Reported by Coverity.

Cc: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 io/net-listener.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/io/net-listener.c b/io/net-listener.c
index 77a4e2831c..de38dfae99 100644
--- a/io/net-listener.c
+++ b/io/net-listener.c
@@ -234,6 +234,7 @@ QIOChannelSocket *qio_net_listener_wait_client(QIONetListener *listener)
     for (i = 0; i < listener->nsioc; i++) {
         g_source_unref(sources[i]);
     }
+    g_free(sources);
     g_main_loop_unref(loop);
     g_main_context_unref(ctxt);
 
-- 
2.14.3

Re: [Qemu-devel] [PATCH] io: fix QIONetListener memory leak

Posted by Daniel P. Berrange 7 years, 10 months ago

On Mon, Dec 18, 2017 at 09:53:08AM +0100, Paolo Bonzini wrote:
> The sources array does not escape out of qio_net_listener_wait_client, so
> we have to free it.
> 
> Reported by Coverity.
> 
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  io/net-listener.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, queued.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|