From nobody Tue Oct 28 20:58:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1513587270927404.8866658974057; Mon, 18 Dec 2017 00:54:30 -0800 (PST) Received: from localhost ([::1]:57314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQrBf-0000U0-QP for importer@patchew.org; Mon, 18 Dec 2017 03:54:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQrAh-00009W-VE for qemu-devel@nongnu.org; Mon, 18 Dec 2017 03:53:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQrAe-0007rQ-U4 for qemu-devel@nongnu.org; Mon, 18 Dec 2017 03:53:16 -0500 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:41295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQrAe-0007qp-N5 for qemu-devel@nongnu.org; Mon, 18 Dec 2017 03:53:12 -0500 Received: by mail-wm0-x244.google.com with SMTP id g75so27737966wme.0 for ; Mon, 18 Dec 2017 00:53:12 -0800 (PST) Received: from donizetti.lan (dynamic-adsl-78-12-251-125.clienti.tiscali.it. [78.12.251.125]) by smtp.gmail.com with ESMTPSA id p29sm16420568wmf.20.2017.12.18.00.53.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Dec 2017 00:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=p7BOP7TbAT24E1LVrSvMx1cVhhrHycAeNabCKlQAXJw=; b=DJA6onvks22/TtgvGr2Uk2OQgsgiqhpiCkWHBXjrdzO6ncR4yUzFjxHEwc4rpXq72b P7eLeZvwtiYo/jNzgp2il9d7UL0A7BjvrcfUKaqio2x9XVUJZAq9irrKu30A7UUwpkqL 5M8/JpTi63A1V0Go0xUmpqOUFTMZ8/OdoomiwNIAK7GRBh75HPz7eThseOKDKYkiHcHf HDGetk3wLSIQ3A0TzUvWA8sXgVk1X54UqHSIX9agUmDG6kBGmvWiUMRzcrWoPe2lzSzq 7/NyDzZjP7qQsp5W1u6Cwi5yGUg7ogMLmFXZ+jWm3mWkrPNEtryEzobjrGEpavPk4OGf qoDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=p7BOP7TbAT24E1LVrSvMx1cVhhrHycAeNabCKlQAXJw=; b=OGZTMqm2+SeIu2RralSPR5GaUpLUnFF6qg2hJPyJr9whw4RWESRJ9k8Il///hhF7rG O80JiS3tT0e437DyV5Nk6QBYZtuICrHAemcb9QOMDYFqbGm5QSj8jS9NtCOhwBZ9qFEW DkqwyQfuO+wLNCcypWOpK/GcQV/joywE1SXfphyYLiQvgGHYC+KJvqHabouWo+CK561F yGdqVhpvABAgruaMC08nKQJPsQHzuWMDPkxbSLm3x5CTrLl+fFRkyy4tUQqV9zdgSrDG xwwjy4JYD9MEmf0HMA3eq7AkCYylwqDJw8s/xRmvBy3ZbZWRh0CENQXshVQ4+x+3Ubfb psIw== X-Gm-Message-State: AKGB3mL5V5t+8bzvim16VoHPcaZL59fMWpiyLLwPFRECC8g0BWkmZSQ2 NjAI0d0c1UOpl/CJQG5dFL0ums6Y X-Google-Smtp-Source: ACJfBouRwyMelqAD6TPu/sbka69T/wj0WnlpxK3CIS4NqN6rXL2b3sLitlRLLX9cUmZL48203vGKvQ== X-Received: by 10.28.153.150 with SMTP id b144mr12425762wme.93.1513587190640; Mon, 18 Dec 2017 00:53:10 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 18 Dec 2017 09:53:08 +0100 Message-Id: <20171218085308.23241-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.14.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [PATCH] io: fix QIONetListener memory leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The sources array does not escape out of qio_net_listener_wait_client, so we have to free it. Reported by Coverity. Cc: Daniel P. Berrange Signed-off-by: Paolo Bonzini --- io/net-listener.c | 1 + 1 file changed, 1 insertion(+) diff --git a/io/net-listener.c b/io/net-listener.c index 77a4e2831c..de38dfae99 100644 --- a/io/net-listener.c +++ b/io/net-listener.c @@ -234,6 +234,7 @@ QIOChannelSocket *qio_net_listener_wait_client(QIONetLi= stener *listener) for (i =3D 0; i < listener->nsioc; i++) { g_source_unref(sources[i]); } + g_free(sources); g_main_loop_unref(loop); g_main_context_unref(ctxt); =20 --=20 2.14.3